From patchwork Mon May 27 19:52:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Vollmert X-Patchwork-Id: 14092 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 13B651701A; Mon, 27 May 2019 20:54:13 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id A1FB616CC8 for ; Mon, 27 May 2019 20:54:12 +0100 (BST) Received: from localhost ([127.0.0.1]:50023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVLhE-00022Z-4w for patchwork@mira.cbaines.net; Mon, 27 May 2019 15:54:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVLh7-00020M-De for guix-patches@gnu.org; Mon, 27 May 2019 15:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVLh6-0003tq-AT for guix-patches@gnu.org; Mon, 27 May 2019 15:54:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40620) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVLh6-0003td-7j for guix-patches@gnu.org; Mon, 27 May 2019 15:54:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVLh6-0005zp-61 for guix-patches@gnu.org; Mon, 27 May 2019 15:54:04 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35932] [PATCH 3/4] guix: haskell-build-system: generate Setup.hs if not exists Resent-From: Robert Vollmert Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 May 2019 19:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35932 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35932@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.155898680822955 (code B ref -1); Mon, 27 May 2019 19:54:03 +0000 Received: (at submit) by debbugs.gnu.org; 27 May 2019 19:53:28 +0000 Received: from localhost ([127.0.0.1]:54155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLgW-0005y8-40 for submit@debbugs.gnu.org; Mon, 27 May 2019 15:53:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVLgS-0005xT-3C for submit@debbugs.gnu.org; Mon, 27 May 2019 15:53:24 -0400 Received: from lists.gnu.org ([209.51.188.17]:36183) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVLgM-0003PN-5Y for submit@debbugs.gnu.org; Mon, 27 May 2019 15:53:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVLgL-0001x9-29 for guix-patches@gnu.org; Mon, 27 May 2019 15:53:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVLgH-0003MJ-AZ for guix-patches@gnu.org; Mon, 27 May 2019 15:53:15 -0400 Received: from mx1.mailbox.org ([2001:67c:2050:104:0:1:25:1]:11180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hVLgF-0003Iy-EK for guix-patches@gnu.org; Mon, 27 May 2019 15:53:13 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx1.mailbox.org (Postfix) with ESMTPS id 3D8884FBC4; Mon, 27 May 2019 21:53:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id UWPPlkQqEckD; Mon, 27 May 2019 21:53:05 +0200 (CEST) From: Robert Vollmert Date: Mon, 27 May 2019 21:52:50 +0200 Message-Id: <20190527195251.59801-4-rob@vllmrt.net> In-Reply-To: <20190527195251.59801-1-rob@vllmrt.net> References: <20190527195251.59801-1-rob@vllmrt.net> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Robert Vollmert Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches The default Setup.hs is boilerplate that is frequently left out of source packages, causing build failure for package definitions as generated by `guix import hackage`. Compare * guix/build/haskell-build-system.scm: Generate Setup.hs if missing, after unpack phase. --- guix/build/haskell-build-system.scm | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/guix/build/haskell-build-system.scm b/guix/build/haskell-build-system.scm index 5c5b32322b..0c648e510f 100644 --- a/guix/build/haskell-build-system.scm +++ b/guix/build/haskell-build-system.scm @@ -275,9 +275,21 @@ given Haskell package." (_ (error "Could not find a Cabal file to patch.")))) #t) +(define* (generate-setup #:rest empty) + "Generate boilerplate Setup.hs if missing." + (when (not (or (file-exists? "Setup.hs") + (file-exists? "Setup.lhs"))) + (format #t "generating missing Setup.hs~%") + (with-output-to-file "Setup.hs" + (lambda () + (format #t "import Distribution.Simple~%") + (format #t "main = defaultMain~%")))) + #t) + (define %standard-phases (modify-phases gnu:%standard-phases (add-after 'unpack 'patch-cabal-file patch-cabal-file) + (add-after 'unpack 'generate-setup generate-setup) (delete 'bootstrap) (add-before 'configure 'setup-compiler setup-compiler) (add-before 'install 'haddock haddock)