From patchwork Fri May 3 09:10:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Baines X-Patchwork-Id: 13842 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1F2B916F8A; Fri, 3 May 2019 10:11:08 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id B883716EF4 for ; Fri, 3 May 2019 10:11:07 +0100 (BST) Received: from localhost ([127.0.0.1]:36959 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMUDj-0005ER-6T for patchwork@mira.cbaines.net; Fri, 03 May 2019 05:11:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMUDh-0005EI-2N for guix-patches@gnu.org; Fri, 03 May 2019 05:11:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMUDe-0000c8-Bn for guix-patches@gnu.org; Fri, 03 May 2019 05:11:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34167) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMUDe-0000bw-5p for guix-patches@gnu.org; Fri, 03 May 2019 05:11:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMUDd-0002Pw-Nn for guix-patches@gnu.org; Fri, 03 May 2019 05:11:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35544] [PATCH] services: dovecot: Rename auth-verbose-passwords?. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 May 2019 09:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 35544 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 35544@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15568746529276 (code B ref -1); Fri, 03 May 2019 09:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 3 May 2019 09:10:52 +0000 Received: from localhost ([127.0.0.1]:47711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUDT-0002PX-W9 for submit@debbugs.gnu.org; Fri, 03 May 2019 05:10:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMUDR-0002PK-W2 for submit@debbugs.gnu.org; Fri, 03 May 2019 05:10:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:48450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMUDM-0000Tg-U0 for submit@debbugs.gnu.org; Fri, 03 May 2019 05:10:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMUDL-00051A-Tx for guix-patches@gnu.org; Fri, 03 May 2019 05:10:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMUDL-0000SU-1A for guix-patches@gnu.org; Fri, 03 May 2019 05:10:43 -0400 Received: from mira.cbaines.net ([2a01:7e00::f03c:91ff:fe69:8da9]:39124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMUDK-0000Qd-S1 for guix-patches@gnu.org; Fri, 03 May 2019 05:10:42 -0400 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id A4CD616ECC for ; Fri, 3 May 2019 10:10:39 +0100 (BST) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id f6c71e58 for ; Fri, 3 May 2019 09:10:39 +0000 (UTC) From: Christopher Baines Date: Fri, 3 May 2019 10:10:39 +0100 Message-Id: <20190503091039.12424-1-mail@cbaines.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/services/mail.scm (dovecot-configuration)[auth-verbose-passwords?]: Rename to auth-verbose-passwords, and change the type to a string, as this parameter can take one of three string values. * doc/guix.texi (Dovecot service): Update the corresponding documentation. --- doc/guix.texi | 4 ++-- gnu/services/mail.scm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 7cda06de5c..1fe4618742 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -15845,13 +15845,13 @@ failed. Defaults to @samp{#f}. @end deftypevr -@deftypevr {@code{dovecot-configuration} parameter} boolean auth-verbose-passwords? +@deftypevr {@code{dovecot-configuration} parameter} string auth-verbose-passwords In case of password mismatches, log the attempted password. Valid values are no, plain and sha1. sha1 can be useful for detecting brute force password attempts vs. user simply trying the same password over and over again. You can also truncate the value to n chars by appending ":n" (e.g.@: sha1:6). -Defaults to @samp{#f}. +Defaults to @samp{"no"}. @end deftypevr @deftypevr {@code{dovecot-configuration} parameter} boolean auth-debug? diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index 0dabfed4cb..216b2c80b0 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -806,8 +806,8 @@ standard facilities are supported.") "Log unsuccessful authentication attempts and the reasons why they failed.") - (auth-verbose-passwords? - (boolean #f) + (auth-verbose-passwords + (string "no") "In case of password mismatches, log the attempted password. Valid values are no, plain and sha1. sha1 can be useful for detecting brute force password attempts vs. user simply trying the same password over