From patchwork Tue Feb 19 04:23:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 1190 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EAAB216C61; Tue, 19 Feb 2019 04:28:32 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 6231716C5F for ; Tue, 19 Feb 2019 04:25:32 +0000 (GMT) Received: from localhost ([127.0.0.1]:41333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvwyA-0001gF-3a for patchwork@mira.cbaines.net; Mon, 18 Feb 2019 23:25:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvwy5-0001fz-0T for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvwxx-00049b-0V for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:10 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54409) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gvwxt-00048F-AX for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:07 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gvwxq-0000A0-JX for guix-patches@gnu.org; Mon, 18 Feb 2019 23:25:05 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#34515] [PATCH 10/13] gnu: Add python-autobahn. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Feb 2019 04:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34515 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ricardo Wurmus Received: via spool by 34515-submit@debbugs.gnu.org id=B34515.1550550242474 (code B ref 34515); Tue, 19 Feb 2019 04:25:02 +0000 Received: (at 34515) by debbugs.gnu.org; 19 Feb 2019 04:24:02 +0000 Received: from localhost ([127.0.0.1]:53690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvwws-00007X-7x for submit@debbugs.gnu.org; Mon, 18 Feb 2019 23:24:02 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gvwwo-00006s-Qb for 34515@debbugs.gnu.org; Mon, 18 Feb 2019 23:24:00 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7D8DC221FC; Mon, 18 Feb 2019 23:23:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 18 Feb 2019 23:23:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=GpCBK7TP/9LcXZpnw4k9xRgv Ef0hyqcw5AHtnGCTNp4=; b=aPBXKGaczvIB/iyUZaUJZvYm5ecwktcRpBkVnkPa t7wB6FDUoJ2DDDP8Gs+f5dZM+kYaYu14HdE2MmxbeQhSUVk0U3M+YzU10PAvMXuv 343yh8U6ezDnvRXLfstYiFtHIYDxZPPdkhllyzo8Z6ghYZdD5Vngc4c483gN8VRT qCk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GpCBK7 TP/9LcXZpnw4k9xRgvEf0hyqcw5AHtnGCTNp4=; b=S0wUdNAzr7JZCY6Jo0Bkbn mKmO+NrfMafx5BOaIyqUAn/N1QdeV9jHcuYO3UVFhTGsb/HVyc4xgqaPi4tRx9K3 9MTRPKfnXBm7o5hiSelfwlKPDgWr0uwGj0c4Daj9lM6cdZNx+dWX8NWAyuAQYXFw ROeliTDw/QxCYhnYA6kS0oBB6PVCxFj+eZjrG2bRcOHKtAfCHPAVLgKfKgqzHp9v 6nzlMszmpn8MVhgzicuWkiAi6PW3D1jpWq/X9Rq55dcIrJTG/JzH0KMshfWjhU8T DYpeza2WFId2L7OHkhyjCqmXQ4B+Tl6x7S7sQAEEuOBQqXsBQb0yO7r7nfFjkKmA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrtddvgdehheculddtuddrgedtledrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehgtd erredtreejnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeejie druddvgedrvddtvddrudefjeenucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgr mhhulhgrrhhirdhnrghmvgenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (c-76-124-202-137.hsd1.pa.comcast.net [76.124.202.137]) by mail.messagingengine.com (Postfix) with ESMTPA id DC4F1E44D4; Mon, 18 Feb 2019 23:23:50 -0500 (EST) Date: Mon, 18 Feb 2019 23:23:49 -0500 From: Leo Famulari Message-ID: <20190219042349.GD2718@jasmine.lan> References: <44e542e83121ab7fe02f134d349fbb484396ce30.1550437064.git.leo@famulari.name> <87wolxwlfd.fsf@elephly.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87wolxwlfd.fsf@elephly.net> User-Agent: Mutt/1.11.2 (2019-01-07) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 34515@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches On Mon, Feb 18, 2019 at 09:27:50AM +0100, Ricardo Wurmus wrote: > Leo Famulari writes: > > * gnu/packages/python-web.scm (python-autobahn): New variable. > […] > > + (arguments > > + `(#:tests? #f)) ; fail mysteriously > > Mysteriously, eh? Do you have any more information about this that > might help us debug this? Basically, the tests quit early after several errors like this: ------ ______ ERROR collecting build/lib/autobahn/nvx/test/test_utf8validator.py ______ import file mismatch: imported module 'test_utf8validator' has this __file__ attribute: /tmp/guix-build-python-autobahn-19.2.1.drv-0/autobahn-19.2.1/autobahn/nvx/test/test_utf8validator.py which is not the same as the test file we want to collect: /tmp/guix-build-python-autobahn-19.2.1.drv-0/autobahn-19.2.1/build/lib/autobahn/nvx/test/test_utf8validator.py HINT: remove __pycache__ / .pyc files and/or use a unique basename for your test file modules ------ I don't fully understand the issue but it's discussed in the pytest bug tracker as a general issue: https://github.com/pytest-dev/pytest/issues/529 What do you think? My opinion is that the test suite is broken. The failure can be reproduced by adding this patch: diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm index c58f358c63..e4ca630498 100644 --- a/gnu/packages/python-web.scm +++ b/gnu/packages/python-web.scm @@ -3014,7 +3014,23 @@ high level API for making HTTP requests when using Twisted.") "1mm7j24ls01c7jb1ad5p5cpyxvzgydiyf8b04ihykh2v8g98j0x7")))) (build-system python-build-system) (arguments - `(#:tests? #f)) ; fail mysteriously + `(#:tests? #t + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'adjust-tests + (lambda _ + ;; This variable chooses whether to use Twisted or + ;; asyncio for the tests. + (setenv "USE_TWISTED" "true") + ;; The require an old pytest because they aim to support + ;; Python 3.3. + (substitute* "setup.py" + (("pytest>=2.8.6,<3.3.0") + "pytest")) + #t))))) + (native-inputs + `(("python-mock" ,python-mock) + ("python-pytest" ,python-pytest))) (propagated-inputs `(("python-cffi" ,python-cffi) ("python-twisted" ,python-twisted)