From patchwork Sun Dec 30 02:42:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Timothy Sample X-Patchwork-Id: 591 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 13FFD169CD; Sun, 30 Dec 2018 02:59:43 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id 99EA0169B9 for ; Sun, 30 Dec 2018 02:59:42 +0000 (GMT) Received: from localhost ([127.0.0.1]:42520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdRKI-0003Zw-2s for patchwork@mira.cbaines.net; Sat, 29 Dec 2018 21:59:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gdRJy-0003R6-Sm for guix-patches@gnu.org; Sat, 29 Dec 2018 21:59:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gdR4B-00042h-3f for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gdR4A-00042G-Ti for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gdR4A-0004vh-Q0 for guix-patches@gnu.org; Sat, 29 Dec 2018 21:43:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33916] [PATCH 3/4] services: gdm: Remove 'allow-root?' option. Resent-From: Timothy Sample Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 30 Dec 2018 02:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33916 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33916@debbugs.gnu.org Received: via spool by 33916-submit@debbugs.gnu.org id=B33916.154613777018901 (code B ref 33916); Sun, 30 Dec 2018 02:43:02 +0000 Received: (at 33916) by debbugs.gnu.org; 30 Dec 2018 02:42:50 +0000 Received: from localhost ([127.0.0.1]:41763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gdR3x-0004um-Lf for submit@debbugs.gnu.org; Sat, 29 Dec 2018 21:42:49 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:40053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gdR3v-0004uY-Pb for 33916@debbugs.gnu.org; Sat, 29 Dec 2018 21:42:48 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A757C21286; Sat, 29 Dec 2018 21:42:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 29 Dec 2018 21:42:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=mbdorA4t+HgQBTN4Rtnva+Af8NHOvuxJoMYdfvgIl cc=; b=eQ2dw0iehmL3QSnjQ1Lw3tunA69sSsXBaGLBuA8SiKonLDpXzJ7vEJ87P tbHEIXBz1doa/K7Farp4w75jxFyjSAHkddpsnsOkGipBOr5icuQtDot9+vXmrvh+ 0ea7Z+aPcxhxSdMqHxHcsIeCGY4oZaCTr9TuznEJhb9tF1t18ulzgYktpDFkFr+p IgsMgwZiufmI2N+a2FtXC6WxfBlyJh+G+NTc8t71eduv+cKeyrX2SVDuPU+hMkxK 4OsBxnUhSsgYL54iIQsOx1wt5yrcLoHgbavqD5UL0ZosoJwF5uCe373+pGI4Hy5E 0cWel9ALRoqlLzGiW1t4cLrQE+NdA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrtdelgdegleculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhggtgfgsehtke ertdertdejnecuhfhrohhmpefvihhmohhthhihucfurghmphhlvgcuoehsrghmphhlvght sehnghihrhhordgtohhmqeenucfkphepjeegrdduudeirddukeeirdeggeenucfrrghrrg hmpehmrghilhhfrhhomhepshgrmhhplhgvthesnhhghihrohdrtghomhenucevlhhushht vghrufhiiigvpedt X-ME-Proxy: Received: from mrblack.lan (74-116-186-44.qc.dsl.ebox.net [74.116.186.44]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A7A5100BB; Sat, 29 Dec 2018 21:42:42 -0500 (EST) From: Timothy Sample Date: Sat, 29 Dec 2018 21:42:03 -0500 Message-Id: <20181230024204.4230-3-samplet@ngyro.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <87bm53n3iu.fsf@ngyro.com> References: <87bm53n3iu.fsf@ngyro.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This option results in allowing all login attempts without asking for credentials. The name is confusing, but rather than rename it, we will remove it, since it seems like a feature that no one would want. * gnu/services/xorg.scm (): Remove 'allow-root?'. (gdm-pam-service): Do not use 'gdm-configuration-allow-root?'. --- gnu/services/xorg.scm | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index ea8433af3..48aa8f68c 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2017 Andy Wingo ;;; Copyright © 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Sou Bunnbu +;;; Copyright © 2018 Timothy Sample ;;; ;;; This file is part of GNU Guix. ;;; @@ -625,7 +626,6 @@ makes the good ol' XlockMore usable." gdm-configuration? (gdm gdm-configuration-gdm (default gdm)) (allow-empty-passwords? gdm-configuration-allow-empty-passwords? (default #t)) - (allow-root? gdm-configuration-allow-root? (default #t)) (auto-login? gdm-configuration-auto-login? (default #f)) (default-user gdm-configuration-default-user (default #f)) (x-server gdm-configuration-x-server)) @@ -680,10 +680,9 @@ makes the good ol' XlockMore usable." (auth (list (pam-entry (control "required") (module "pam_permit.so"))))) - (unix-pam-service - "gdm-password" - #:allow-empty-passwords? (gdm-configuration-allow-empty-passwords? config) - #:allow-root? (gdm-configuration-allow-root? config)))) + (unix-pam-service "gdm-password" + #:allow-empty-passwords? + (gdm-configuration-allow-empty-passwords? config)))) (define (gdm-shepherd-service config) (list (shepherd-service