diff mbox series

[bug#33308,2/2] gnu: capnproto: Update to 0.7.0.

Message ID 20181107195654.22832-2-mail@cbaines.net
State Accepted
Headers show
Series None | expand

Checks

Context Check Description
cbaines/applying patch success Successfully applied
cbaines/applying patch success Successfully applied

Commit Message

Christopher Baines Nov. 7, 2018, 7:56 p.m. UTC 
* gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
[source]: Update sha256 hash.
[arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
use /tmp for tempory files, as the default /var/tmp directory doesn't exist.
---
 gnu/packages/serialization.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

Comments

Ludovic Courtès Nov. 10, 2018, 10:22 p.m. UTC | #1 
Hello,

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
> [source]: Update sha256 hash.
> [arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
> use /tmp for tempory files, as the default /var/tmp directory doesn't exist.

I’d suggest moving the /var/tmp explanation in a comment but otherwise
LGTM, thanks!

Ludo’.
Christopher Baines Nov. 26, 2018, 7:27 p.m. UTC | #2 
Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/serialization.scm (capnproto)[version]: Change to 0.7.0.
>> [source]: Update sha256 hash.
>> [arguments]: Add new 'use-tmp-for-tempory-files phase, to patch some tests to
>> use /tmp for tempory files, as the default /var/tmp directory doesn't exist.
>
> I’d suggest moving the /var/tmp explanation in a comment but otherwise
> LGTM, thanks!

Great, I've done this now, and sent some updated patches.
diff mbox series

Patch

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 40b3d1bae0..77fd070bc7 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -314,7 +314,7 @@  it a convenient format to store user input files.")
 (define-public capnproto
   (package
     (name "capnproto")
-    (version "0.6.1")
+    (version "0.7.0")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -322,7 +322,7 @@  it a convenient format to store user input files.")
                     version ".tar.gz"))
               (sha256
                (base32
-                "010s9yhq4531wvdfrdf2477zswhck6cjfby79w73rff3v06090l0"))))
+                "0hfdnhlbskagzgvby8wy6lrxj53zfzpfqimbhga68c0ji2yw1969"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
@@ -332,6 +332,12 @@  it a convenient format to store user input files.")
              ;; Workaround for test that tries to resolve port name from
              ;; /etc/services, which is not present in build environment.
              (substitute* "src/kj/async-io-test.c++" ((":http") ":80"))
+             #t))
+         (add-before 'check 'use-tmp-for-tempory-files
+           (lambda _
+             (substitute* "src/kj/filesystem-disk-test.c++"
+               (("VAR\\_TMP \"/var/tmp\"")
+                "VAR_TMP \"/tmp\""))
              #t)))))
     (home-page "https://capnproto.org")
     (synopsis "Capability-based RPC and serialization system")