From patchwork Tue Nov 12 16:25:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Janneke Nieuwenhuizen X-Patchwork-Id: 70322 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 92F6B27BBEA; Tue, 12 Nov 2024 16:32:11 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3ECE427BBE2 for ; Tue, 12 Nov 2024 16:32:11 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tAtmO-0003jy-RX; Tue, 12 Nov 2024 11:30:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAtmL-0003be-Oz for guix-patches@gnu.org; Tue, 12 Nov 2024 11:30:09 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tAtmL-0005t3-F0 for guix-patches@gnu.org; Tue, 12 Nov 2024 11:30:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=ZxI/gq58eWCTS4TrSRJVe5AfDbAQNW+5TBQK2EriJ8w=; b=WLJvSnp0XQpKvqLXe6d0sFRTfQO4clKUFr8jQ01CK2YdmMdj9k5h3SQd6R+ajJsknEhy0byeutpcZJZhoyDJCuqmgNkySsUlxoqkKDI11lMkBmTDYtYomWcsapd44MiK5YThFX0iH6qqJ/crqMmZXnUgLUsktOC5XnzcNSkUcVLtIpbQALU8gS4xL721UcGDe6g/VMea13zfuYh1yDmTb/lSk4SOscOuvpPZtdjsxbCta7rK2EPsuZyoo33OSEbM9P0jyEStdzeZfDh1omkjZb6F3+4pBocGq+J4yheR8pKFkjyCxryQrLAvHRU1ctGi1MWPr2MiEq6zqYk7Rnd77w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tAtmL-0000Rr-9H for guix-patches@gnu.org; Tue, 12 Nov 2024 11:30:09 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74290] [PATCH v2 07/40] gnu: bash-minimal: Fix build for 64bit Hurd. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 12 Nov 2024 16:30:09 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74290 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74290@debbugs.gnu.org Received: via spool by 74290-submit@debbugs.gnu.org id=B74290.17314289631153 (code B ref 74290); Tue, 12 Nov 2024 16:30:09 +0000 Received: (at 74290) by debbugs.gnu.org; 12 Nov 2024 16:29:23 +0000 Received: from localhost ([127.0.0.1]:39083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAtlb-0000IQ-3a for submit@debbugs.gnu.org; Tue, 12 Nov 2024 11:29:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tAtlR-0000GA-7C for 74290@debbugs.gnu.org; Tue, 12 Nov 2024 11:29:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tAtjF-0005L0-9i; Tue, 12 Nov 2024 11:26:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=ZxI/gq58eWCTS4TrSRJVe5AfDbAQNW+5TBQK2EriJ8w=; b=XDA3IZwSiuj6PtApzIyt 7vb3nlMUk1a3eW3/JVVW5s+KdAAT/i5GzIY/6uFcZpm3fVKGyAUGZ+MJEOjCxeR9j+jjRLQn+axZF oc4ygHcpUY7FU0vjem8D9bhTmQhfTULy+znNidCHvM9mZQRPCRH0Ko/ky3SPS7jTl75x/J8tKagkd z10axtLPe/kiNoBK2GIF8NHY6CndMKIN7SNkXO5JULzJi1ApLC5bgDWlG5mqlnrDtFJN/sLlHgOud 2m1QBNtFnL6pVwwnfn2YdZokxy7XeQBwyoM2sFQ9+fjqwOj7ExPFTwovhDfrS/NTyfj4w3tvM0dah g3vtPG+3g714bA==; From: Janneke Nieuwenhuizen Date: Tue, 12 Nov 2024 17:25:16 +0100 Message-ID: <1f92fed3939c2be15f88c5952cb79eaafd23e7dc.1731427612.git.janneke@gnu.org> X-Mailer: git-send-email 2.46.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/bash-minimal.scm (bash)[arguments]: When building with gcc >= 14 use "CFLAGS=-Wno-implicit-function-declaration". Change-Id: I3fd2da7a1d9011b155084dceadbad649dbb2a1b9 --- gnu/packages/bash.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gnu/packages/bash.scm b/gnu/packages/bash.scm index 93641a78d5..1a3b014ad7 100644 --- a/gnu/packages/bash.scm +++ b/gnu/packages/bash.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2020 Zhu Zihao ;;; Copyright © 2021 Marius Bakke ;;; Copyright © 2024 Oleg Pykhalov +;;; Copyright © 2024 Janneke Nieuwenhuizen ;;; ;;; This file is part of GNU Guix. ;;; @@ -30,6 +31,7 @@ (define-module (gnu packages bash) #:use-module (gnu packages base) #:use-module (gnu packages bootstrap) #:use-module (gnu packages compression) + #:use-module (gnu packages gcc) #:use-module (gnu packages elf) #:use-module (gnu packages ncurses) #:use-module (gnu packages readline) @@ -251,6 +253,13 @@ (define-public bash-minimal ;; modules and related code. "ac_cv_func_dlopen=no" + ,@(if (version>=? (package-version (current-gcc)) "14") + ;; gcc-14 implictly uses -Wimplicit-function-declaration + ;; which together with -Werror causes: + ;; ./enable.def:492:11: error: implicit declaration of function ‘dlclose’; + '("CFLAGS=-Wno-implicit-function-declaration") + '()) + ,@(if (%current-target-system) '("bash_cv_job_control_missing=no" "bash_cv_getcwd_malloc=yes")