diff mbox series

[bug#76775] gnu: emacs-disproject: Update to 2.0.0.

Message ID 1c9f7829312837a1d202c36d87621a67cac62431.1741251109.git.aurtzy@gmail.com
State New
Headers
Series [bug#76775] gnu: emacs-disproject: Update to 2.0.0. |

Commit Message

aurtzy March 6, 2025, 8:51 a.m. UTC 
  * gnu/packages/emacs-xyz.scm (emacs-disproject): Update to 2.0.0.

Change-Id: I4fae2020fb9e2ce1f68f76791931368c90c84e93
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 310adf4ce70cbb864859274fcc7842bd519bbddc

Comments

Cayetano Santos March 6, 2025, 9:21 a.m. UTC | #1 
>jeu. 06 mars 2025 at 03:51, aurtzy <aurtzy@gmail.com> wrote:

> * gnu/packages/emacs-xyz.scm (emacs-disproject): Update to 2.0.0.

>      (propagated-inputs (list emacs-transient))

This package requires emacs 29.4, which already includes transient. No
need to propagate it, then.

Other than this, looks good to me.

Thanks !

C.
aurtzy March 6, 2025, 8:13 p.m. UTC | #2 
Hey Cayetano,

On 3/6/25 04:21, Cayetano Santos wrote:
>> * gnu/packages/emacs-xyz.scm (emacs-disproject): Update to 2.0.0.
> 
>>       (propagated-inputs (list emacs-transient))
> 
> This package requires emacs 29.4, which already includes transient. No
> need to propagate it, then.

Does this apply if the package requires a newer version? It looks like the 
built-in Transient version is 0.4.3, but off the top of my head at least 0.7.8 
is required to fix a bug that breaks some functionality.

Cheers,

aurtzy
Cayetano Santos March 6, 2025, 8:54 p.m. UTC | #3 
>jeu. 06 mars 2025 at 15:13, aurtzy <aurtzy@gmail.com> wrote:

> Does this apply if the package requires a newer version? It looks like the built-in
> Transient version is 0.4.3, but off the top of my head at least 0.7.8 is required to fix a
> bug that breaks some functionality.

You’re absolutely right: "0.8.0" is required here.
Cayetano Santos March 6, 2025, 9:17 p.m. UTC | #4 
user guix
usertag 76775 + reviewed-looks-good
thanks

Items marked as checked:

- Commit messages
- Package builds
- Lint warnings
- Package style
- There are no package tests
- No dependent packages build
- Licenses
- Synopsis and descriptions
Nicolas Goaziou March 7, 2025, 9:38 a.m. UTC | #5 
> user guix
> usertag 76775 + reviewed-looks-good
> thanks
> 
> Items marked as checked:
> 
> - Commit messages
> - Package builds
> - Lint warnings
> - Package style
> - There are no package tests
> - No dependent packages build
> - Licenses
> - Synopsis and descriptions

Applied. Thanks!
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f5876a342c..8281835632 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1640,7 +1640,7 @@  (define-public emacs-discourse-mode
 (define-public emacs-disproject
   (package
     (name "emacs-disproject")
-    (version "1.3.1")
+    (version "2.0.0")
     (source
      (origin
        (method git-fetch)
@@ -1649,7 +1649,7 @@  (define-public emacs-disproject
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "03wf14vilnysj9szcffsadhw86p68v3083dv98d99c8axm51n6hz"))))
+        (base32 "0550bfqbprbr9s36xgyrwdg2mrry28j5cbd7fms980ixn6a4vcx5"))))
     (build-system emacs-build-system)
     (propagated-inputs (list emacs-transient))
     (home-page "https://github.com/aurtzy/disproject")