From patchwork Fri Nov 17 12:15:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sharlatan Hellseher X-Patchwork-Id: 56567 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EDA5327BBEE; Fri, 17 Nov 2023 10:22:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D1D7F27BBEA for ; Fri, 17 Nov 2023 10:22:06 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r3vyk-000162-Fg; Fri, 17 Nov 2023 05:21:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r3vyE-0000uQ-Bx for guix-patches@gnu.org; Fri, 17 Nov 2023 05:21:06 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r3vyE-0004vy-2n for guix-patches@gnu.org; Fri, 17 Nov 2023 05:21:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r3vyA-0001EA-Rj; Fri, 17 Nov 2023 05:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67237] [PATCH 02/32] gnu: gpredict: Improve package style. Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: andreas@enge.fr, efraim@flashner.co.il, bavier@posteo.net, guix-patches@gnu.org Resent-Date: Fri, 17 Nov 2023 10:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67237 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 67237@debbugs.gnu.org Cc: Sharlatan Hellseher , Andreas Enge , Efraim Flashner , Eric Bavier X-Debbugs-Original-Xcc: Andreas Enge , Efraim Flashner , Eric Bavier Received: via spool by 67237-submit@debbugs.gnu.org id=B67237.17002164234280 (code B ref 67237); Fri, 17 Nov 2023 10:21:02 +0000 Received: (at 67237) by debbugs.gnu.org; 17 Nov 2023 10:20:23 +0000 Received: from localhost ([127.0.0.1]:45161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3vxX-00016t-7M for submit@debbugs.gnu.org; Fri, 17 Nov 2023 05:20:23 -0500 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:56426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r3vxT-000167-0H for 67237@debbugs.gnu.org; Fri, 17 Nov 2023 05:20:21 -0500 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-40836ea8cbaso13323955e9.0 for <67237@debbugs.gnu.org>; Fri, 17 Nov 2023 02:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700216413; x=1700821213; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i9MKIIQFIecjNwq4Vm2p0xAPxSXPY3hzQIvJacFnhZk=; b=Uqm30SWcwr4ewb5a/FGjU1L/JYNmJWPKR4670qzslLvEwzjsn7geSdqtSv4buuqamy O919g1XGD2mUrv/ssLvuRMJEzngRJwDrwZN7J7LB4YZlAZYLWSHjV/rtbncyB7yWuOPC qYY3trksgVRtuUoDsrn0BkgoxpJSvUqBwUu1NvSabm1gD54PlBuHBqyRHt6ehhJTbFp5 GUeAZNp0clbnFYWmpQxCnJXeOYlSOfIKCBK87FtjV1yj9CR8j5q8yuQHBIIDUIrXM6t/ aCQhIuKkmqZOywy1UsiZmCyUMO+j4KPLztIoviYUUe3ND1qjYxC8XA8mp1hTAsoAnNPg 3BOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700216413; x=1700821213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i9MKIIQFIecjNwq4Vm2p0xAPxSXPY3hzQIvJacFnhZk=; b=w+Za2wLau4tyQe8e0Cbj/yYHmVD4croNQKcGtNFzQGbe6mNV8J+w/AvUrnCXagALa6 UirqFpP2uBi2AyqXMb1LCUu1DIBlAFQz8Y6EWeWCxtZNMcj0gqEDrRgC+5BB6XCjPX5S 7A519j0Xe0PUnu3ThW5Y0gqu9zdEvqrRpl34xKlylnfstf6QNwrsLR0CAiwnsmnD9JLB 0XAXam4PiGc0kknGJwHHLufy4CKaA7lNv0ySLZuh8FJa2FU95QQvUAWn+tj0/VaLXp0l jlt9m01wJBF77MCQdESJ7dFi9Woblj7R+IgixfnxtI2xgNOela8L6zeK9uBT1i2O+09E J2Sw== X-Gm-Message-State: AOJu0YxQXqciQulRcHpMnCQ4IMICDjb0F+u9BG2a9c6ytREbJADXympa AVQbOW6exALqSt9fwKzVViDvXbouG3JprA== X-Google-Smtp-Source: AGHT+IHbcRLDwTgt4gDOY+cDaKZntO6XQcxdpkWnTGRLEY+XhrPQSWHgbeLCn1/uyZse01gA2V3RTA== X-Received: by 2002:adf:e402:0:b0:32d:8b1a:31ad with SMTP id g2-20020adfe402000000b0032d8b1a31admr13665643wrm.24.1700216412910; Fri, 17 Nov 2023 02:20:12 -0800 (PST) Received: from localhost.localdomain (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id t4-20020a5d4604000000b0032fbd0c7d04sm1858856wrq.55.2023.11.17.02.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 02:20:12 -0800 (PST) From: Sharlatan Hellseher Date: Fri, 17 Nov 2023 12:15:51 +0000 Message-ID: <1bbfc260ff2278cb6ee4fa88818098c419bf7073.1700222319.git.sharlatanus@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/packages/astronomy.scm (gpredict): Improve package style. Reorder fields to be similar with others to ease review. [native-inputs]: Remove labels. [arguments]: Use G-expressions. Drop trailing #t in phases. Change-Id: I0e0216825ce2c9e77632a43dd604ab4abbdf3e83 --- gnu/packages/astronomy.scm | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index 386a5302d6..e03660969b 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -3153,23 +3153,21 @@ (define-public gpredict (sha256 (base32 "0hwf97kng1zy8rxyglw04x89p0bg07zq30hgghm20yxiw2xc8ng7")))) (build-system gnu-build-system) + (arguments + (list + #:configure-flags #~(list "CFLAGS=-O2 -g -fcommon") + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-tests + (lambda _ + ;; Remove reference to non-existent file. + (substitute* "po/POTFILES.in" + (("src/gtk-sat-tree\\.c") ""))))))) (native-inputs - `(("intltool" ,intltool) - ("gettext" ,gettext-minimal) - ("pkg-config" ,pkg-config))) + (list gettext-minimal intltool pkg-config)) (inputs (list curl glib goocanvas gtk+)) - (arguments - `(#:configure-flags '("CFLAGS=-O2 -g -fcommon") - #:phases - (modify-phases %standard-phases - (add-after 'unpack 'fix-tests - (lambda _ - ;; Remove reference to non-existent file. - (substitute* "po/POTFILES.in" - (("src/gtk-sat-tree\\.c") - "")) - #t))))) + (home-page "http://gpredict.oz9aec.net/index.php") (synopsis "Satellite tracking and orbit prediction application") (description "Gpredict is a real-time satellite tracking and orbit prediction @@ -3177,7 +3175,6 @@ (define-public gpredict position and other data in lists, tables, maps, and polar plots (radar view). Gpredict can also predict the time of future passes for a satellite, and provide you with detailed information about each pass.") - (home-page "http://gpredict.oz9aec.net/index.php") (license license:gpl2+))) (define-public sgp4