diff mbox series

[bug#47870,1/2] gnu: polkit-gnome: Add autostart .desktop file.

Message ID 1945027116.9867.1618983112546@office.mailbox.org
State Accepted
Headers show
Series [bug#47870,1/2] gnu: polkit-gnome: Add autostart .desktop file. | expand

Commit Message

Brendan Tildesley April 21, 2021, 5:31 a.m. UTC 
> On 04/19/2021 3:47 PM Leo Prikler <leo.prikler@student.tugraz.at> wrote:
[...]
> Fair enough, so it's either gnome or mate for XFCE.
> 
> > At this point I just want to pick one and get it done with. If you
> > like
> > I can make mate-polkit like your suggestion but rename the desktop
> > file
> > so it doesn't conflict.
> It's your choice, what you want to implement:
> 1. gnome-polkit with an added desktop file (but please use an aux file
> or make-desktop-file-entry instead of an origin pointing into the
> aether)
> 2. mate-polkit-for-xfce with the renamed desktop file.
> 3. something completely else

I made a patch for mate-polkit-for-xfce.



> > Debian's package says this on gnome-polkit:
> > "This implementation was originally designed for GNOME 2, but most
> > GNOME-based desktop environments, including GNOME 3, GNOME Flashback,
> > and MATE, have their own built-in PolicyKit agents and no longer use
> > this one. The remaining users of this implementation are Cinnamon,
> > XFCE and Unity. "
> Hmm, in that case keeping gnome-polkit around longer might be desirable
> if people want to port Cinnamon or Unity.  What does Debian's desktop
> file look like and could we port it over?

It has OnlyShowIn=XFCE;Unity;X-Cinnamon;

It also applies four patches of course
0001-Select-the-current-user-to-authenticate-with-by-defa.patch
0002-Auth-dialog-Make-the-label-wrap-at-70-chars.patch
0003-Get-user-icon-from-accountsservice-instead-of-lookin.patch
0004-Use-fresh-X11-timestamps-when-displaying-authenticat.patch
http://deb.debian.org/debian/pool/main/p/policykit-1-gnome/policykit-1-gnome_0.105-7.debian.tar.xz

Comments

Leo Prikler April 21, 2021, 8:44 a.m. UTC | #1 
Hi,

Am Mittwoch, den 21.04.2021, 07:31 +0200 schrieb Brendan Tildesley:
> > On 04/19/2021 3:47 PM Leo Prikler <leo.prikler@student.tugraz.at>
> > wrote:
> [...]
> > Fair enough, so it's either gnome or mate for XFCE.
> > 
> > > At this point I just want to pick one and get it done with. If
> > > you
> > > like
> > > I can make mate-polkit like your suggestion but rename the
> > > desktop
> > > file
> > > so it doesn't conflict.
> > It's your choice, what you want to implement:
> > 1. gnome-polkit with an added desktop file (but please use an aux
> > file
> > or make-desktop-file-entry instead of an origin pointing into the
> > aether)
> > 2. mate-polkit-for-xfce with the renamed desktop file.
> > 3. something completely else
> 
> I made a patch for mate-polkit-for-xfce.
> 
Thanks.  I've pushed them with some slight changes.
> 
> > > Debian's package says this on gnome-polkit:
> > > "This implementation was originally designed for GNOME 2, but
> > > most
> > > GNOME-based desktop environments, including GNOME 3, GNOME
> > > Flashback,
> > > and MATE, have their own built-in PolicyKit agents and no longer
> > > use
> > > this one. The remaining users of this implementation are
> > > Cinnamon,
> > > XFCE and Unity. "
> > Hmm, in that case keeping gnome-polkit around longer might be
> > desirable
> > if people want to port Cinnamon or Unity.  What does Debian's
> > desktop
> > file look like and could we port it over?
> 
> It has OnlyShowIn=XFCE;Unity;X-Cinnamon;
> 
> It also applies four patches of course
> 0001-Select-the-current-user-to-authenticate-with-by-defa.patch
> 0002-Auth-dialog-Make-the-label-wrap-at-70-chars.patch
> 0003-Get-user-icon-from-accountsservice-instead-of-lookin.patch
> 0004-Use-fresh-X11-timestamps-when-displaying-authenticat.patch
> http://deb.debian.org/debian/pool/main/p/policykit-1-gnome/policykit-1-gnome_0.105-7.debian.tar.xz
That still looks reasonable imo.  If at some point you're dissatisfied
with MATE's polkit agent, feel free to package it.

Regards,
Leo
diff mbox series

Patch

From ccfd8c55472d9af3050d27c9b151d12323d728ce Mon Sep 17 00:00:00 2001
From: Brendan Tildesley <mail@brendan.scot>
Date: Mon, 19 Apr 2021 20:16:05 +1000
Subject: [PATCH 2/2] gnu: xfce: Autostart mate-polkit.

* gnu/packages/xfce.scm (xfce):[inputs]: Add mate-polkit-for-xfce.
---
 gnu/packages/xfce.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 6d272a74ac..0d38649024 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -990,6 +990,7 @@  on your desktop.")
        ("gnome-icon-theme"     ,gnome-icon-theme)
        ("gtk-xfce-engine"      ,gtk-xfce-engine)
        ("hicolor-icon-theme"   ,hicolor-icon-theme)
+       ("mate-polkit-for-xfce" ,mate-polkit-for-xfce)
        ("ristretto"            ,ristretto)
        ("shared-mime-info"     ,shared-mime-info)
        ("thunar"               ,thunar)
-- 
2.31.1