From patchwork Thu Jan 9 14:00:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghav Gururajan X-Patchwork-Id: 19717 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2768517A59; Thu, 9 Jan 2020 14:01:17 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id CCE2B17A4F for ; Thu, 9 Jan 2020 14:01:16 +0000 (GMT) Received: from localhost ([::1]:60930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipYNA-0007VC-73 for patchwork@mira.cbaines.net; Thu, 09 Jan 2020 09:01:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44759) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ipYMy-0007TV-Rt for guix-patches@gnu.org; Thu, 09 Jan 2020 09:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ipYMx-0003se-7f for guix-patches@gnu.org; Thu, 09 Jan 2020 09:01:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46025) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ipYMw-0003pT-Bl for guix-patches@gnu.org; Thu, 09 Jan 2020 09:01:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ipYMw-00064A-Az for guix-patches@gnu.org; Thu, 09 Jan 2020 09:01:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#38905] gnu: Add gnome-initial-setup. (v2) Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 09 Jan 2020 14:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38905 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Julien Lepiller Cc: 38905@debbugs.gnu.org Received: via spool by 38905-submit@debbugs.gnu.org id=B38905.157857844523284 (code B ref 38905); Thu, 09 Jan 2020 14:01:02 +0000 Received: (at 38905) by debbugs.gnu.org; 9 Jan 2020 14:00:45 +0000 Received: from localhost ([127.0.0.1]:51998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipYMe-00063U-Je for submit@debbugs.gnu.org; Thu, 09 Jan 2020 09:00:44 -0500 Received: from knopi.disroot.org ([178.21.23.139]:43472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ipYMb-00063G-ET for 38905@debbugs.gnu.org; Thu, 09 Jan 2020 09:00:42 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 828C523F0F; Thu, 9 Jan 2020 15:00:36 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LGpiK0CfPQ7o; Thu, 9 Jan 2020 15:00:34 +0100 (CET) Message-ID: <191935eb66340d8573e30df8286c0f6a14efa99f.camel@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1578578433; bh=cI4gQsak4SdmAg09I5SBLVCuZOIUJ/IPRRs/vJ2D7Os=; h=Subject:From:To:Cc:In-Reply-To:References:Date; b=WEsaXN3xNB3jzQBhTyBc2lRpDgYW1x/AaK0FvTtkR67/9sWOCo3Yt7ERTZfp2tJE6 FnlLF5WlpmJe9EZorhGzSgndgBm7fNy+SRZdPEerfJQ8gy2ImyQRaHcKqsVDY5ZDj3 awxPWqxUiFJpZOJIKXIvhpEAzfFFwFA39E9FENgHwQ+TdWEsJhFhwSe7mQ/js0JKpE 98wQAZvnJK4BoLRZnNsjUywRTrTp4L/FuVkzZIAIJ3RWh1LJzG7swQFmydAhaP8C0A slTNQVKaedbQbl+lDBpzZkZKGJ1v49wb4ImVSTLty8UgNlTTkWjb7s4qXuYBAJx/qJ 0TI7OgU4CBr8g== From: Raghav Gururajan In-Reply-To: <20200108003114.25d65184@tachikoma.lepiller.eu> References: <20200108003114.25d65184@tachikoma.lepiller.eu> X-Priority: 1 Date: Thu, 09 Jan 2020 09:00:22 -0500 Mime-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Julien! > Thanks for the patch! My pleasure. :-) > I have a few questions about it, even though I didn't try to build it > yet. What is optional in configure-flags? You should probably remove > the comment in the inputs (the package doesn't exist, right?). I have revised the patch. -Dcheese=auto is for camera support for the new user to set profile picture by taking selfie via camera. -Dsystemd=false is to disable systemd dependency. > I'm a bit puzzled by how this package works. Should some of these > inputs be propagated or hard-coded in the code of the package? > Shouldn't they be available at runtime? What does ibus, upower and > the > like do for the build itself? The application starts up as a set-up wizard when new user login for first time, to configure the GNOME desktop. It typically provides a tour of all gnome components and allows the user set settings for each. I have built, installed and ran it for testing. Works good. Those dependencies need not be propagated. I think the application uses data/information from those packages and present it to user during the tour. > I think pkg-config should be a native-input. Yeah, I revised the patch. > The description is a bit vague. What does it do exactly? Maybe > there's > some things that guix cannot setup and that's what it's used for? I'm > not sure what the policy for "aims to" is, but I think I would remove > it. I am not able come up with better one at this time. Let me leave it as it is for now, as I will be revising all gnome packages in the near future. :-) Please find the revised patch (v2) attached with this email. Regards, RG. From fbb0281b7265feb5b5237bbfaf1d771de961c51e Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Thu, 9 Jan 2020 08:46:14 -0500 Subject: [PATCH] gnu: Add gnome-initial-setup * gnu/packages/gnome.scm (gnome-initial-setup): New variable. --- gnu/packages/gnome.scm | 50 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index e71cc2fee2..0d0c71ad05 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -246,6 +246,56 @@ Desktop. It is designed to be as simple as possible and has some unique features to enable users to create their discs easily and quickly.") (license license:gpl2+))) +(define-public gnome-initial-setup + (package + (name "gnome-initial-setup") + (version "3.32.1") + (source (origin + (method url-fetch) + (uri (string-append "mirror://gnome/sources/gnome-initial-setup/" + (version-major+minor version) + "/gnome-initial-setup-" version ".tar.xz")) + (sha256 + (base32 + "1gwhp7dalyc8zsb2pa66cmpdrj2d6drbq5p331sq6zp8ds10k9ry")))) + (build-system meson-build-system) + (arguments + '(#:configure-flags '("-Dcheese=auto" "-Dsystemd=false"))) + (native-inputs + `(("gettext" ,gettext-minimal) + ("glib:bin" ,glib "bin") + ("gtk+:bin" ,gtk+ "bin") + ("pkg-config" ,pkg-config))) + (inputs + `(("accountsservice" ,accountsservice) + ("adwaita-icon-theme" ,adwaita-icon-theme) + ("gdm" ,gdm) + ("geoclue" ,geoclue) + ("gnome-desktop" ,gnome-desktop) + ("gnome-getting-started-docs" ,gnome-getting-started-docs) + ("gnome-online-accounts" ,gnome-online-accounts) + ("gnome-online-accounts:lib" ,gnome-online-accounts "lib") + ("gobject-introspection" ,gobject-introspection) + ("gstreamer" ,gstreamer) + ("ibus" ,ibus) + ("json-glib" ,json-glib) + ("krb5" ,mit-krb5) + ("libgweather" ,libgweather) + ("libsecret" ,libsecret) + ("network-manager" ,network-manager) + ("network-manager-applet" ,network-manager-applet) + ("packagekit" ,packagekit) + ("polkit" ,polkit) + ("pwquality" ,libpwquality) + ("rest" ,rest) + ("upower" ,upower) + ("webkitgtk" ,webkitgtk))) + (synopsis "Initial setup wizard for GNOME desktop") + (description "GNOME Initial Setup aims to provide a simple, easy, +and safe way to prepare a new system.") + (home-page "https://gitlab.gnome.org/GNOME/gnome-initial-setup") + (license license:gpl2))) + (define-public gnome-menus (package (name "gnome-menus") -- 2.24.1