From patchwork Mon Apr 19 06:56:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Brendan Tildesley X-Patchwork-Id: 28651 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 59FC527BC6C; Mon, 19 Apr 2021 07:58:31 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 97C1427BC77 for ; Mon, 19 Apr 2021 07:58:30 +0100 (BST) Received: from localhost ([::1]:49884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYNrZ-00019n-O5 for patchwork@mira.cbaines.net; Mon, 19 Apr 2021 02:58:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYNr8-00019T-OS for guix-patches@gnu.org; Mon, 19 Apr 2021 02:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYNr8-0004eD-GH for guix-patches@gnu.org; Mon, 19 Apr 2021 02:58:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYNr8-0003SK-EW for guix-patches@gnu.org; Mon, 19 Apr 2021 02:58:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47870] [PATCH 1/2] gnu: polkit-gnome: Add autostart .desktop file. Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Apr 2021 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47870 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47870@debbugs.gnu.org Cc: Leo Prikler Received: via spool by 47870-submit@debbugs.gnu.org id=B47870.161881542813222 (code B ref 47870); Mon, 19 Apr 2021 06:58:02 +0000 Received: (at 47870) by debbugs.gnu.org; 19 Apr 2021 06:57:08 +0000 Received: from localhost ([127.0.0.1]:48234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYNqG-0003RC-3z for submit@debbugs.gnu.org; Mon, 19 Apr 2021 02:57:08 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:46004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYNqD-0003Qg-8l for 47870@debbugs.gnu.org; Mon, 19 Apr 2021 02:57:06 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4FNyKk4DTSzQjnM; Mon, 19 Apr 2021 08:56:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1618815416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GTkGZ85FCylz3UDuTmJC4Yp85pvGLuLO3+RRi3p3RyQ=; b=r4I3MvrTG/WByoQpiarxREjFxn8mOuNWJUAuuXfWOJUaW9IAk10PgwvcdC3bsVpoTO5b8a 8mJa5GyNB4UOYJn/lRhSnAN8JirCKFIATEfV72jo1kDHAcNmiQlGFgv9CNg8YoZ/NVDlbw 0yO3EzC5tCkjkY43NFoWdbFfpy8z1FnDJZ9j+jCiTe/VgzKStwxkFj2fWZ5gqtSOiM7uKz /hpt9f3d8uxhF14tTWKukuZ7hiWe1k0OT/qmKLQBP/PpaidMt3owxLJGnH33dKXV6g9jnw wVat5mkAu1rS+FRxX9vWZhuRTPJCO1eJi9IdLd9wuwRrqiSncVrIAIu+5oNUzQ== Received: from smtp2.mailbox.org ([80.241.60.241]) by hefe.heinlein-support.de (hefe.heinlein-support.de [91.198.250.172]) (amavisd-new, port 10030) with ESMTP id OIO4kW6Fojua; Mon, 19 Apr 2021 08:56:54 +0200 (CEST) Date: Mon, 19 Apr 2021 08:56:54 +0200 (CEST) From: Brendan Tildesley Message-ID: <1897089617.84042.1618815414259@office.mailbox.org> In-Reply-To: References: <20210418131727.6104-1-mail@brendan.scot> <687049384.78340.1618758931217@office.mailbox.org> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -4.37 / 15.00 / 15.00 X-Rspamd-Queue-Id: 39E661800 X-Rspamd-UID: 629242 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches > On 04/18/2021 5:52 PM Leo Prikler wrote: > > > Hi, > > Am Sonntag, den 18.04.2021, 17:15 +0200 schrieb Brendan Tildesley: > > > On 04/18/2021 4:47 PM Leo Prikler > > > wrote: [...] > > On second thought perhaps another option is just to use the MATE > > polkit > > agent instead? I tested it for changing network manager and it worked > > just the same, only the GUI looks slightly different. I was searching > > What do you think? > If it works for XFCE, why not? Given that polkit-gnome has no > dependents other than itself, should we perhaps also look into removing > it? > One issue is that mate-polkit's .desktop file has the line OnlyShowIn=MATE; This prevents it from being launched in any other desktop. When multiple desktops are installed all these files sit in /run/current-desktop/profile/etc/ and rely these lines to make them not appear in other desktops. I made a couple patches [attached] that adds XFCE to the the .desktop's OnlyShowIn. It's a little ugly though. > Regards, > Leo From ef20e6422cea8089a4ecf2e7b0293c27bc71a56b Mon Sep 17 00:00:00 2001 From: Brendan Tildesley Date: Mon, 19 Apr 2021 16:37:55 +1000 Subject: [PATCH 1/2] gnu: polkit-mate: Enable autostarting in XFCE. * gnu/packages/mate.scm (polkit-mate): Add XFCE to the OnlyShowIn field of the autostart .desktop file so it will be started by XFCE too. This is for the same of making polkit-mate the de facto agent for XFCE in Guix, since XFCE does not have it's own official one. One downside of this is that since all these .desktop files end up in /run/current-system/profile/etc/, if a user for some reasons wants to have MATE installed, plus an XFCE that doesn't include mate-polkit, this cause XFCE to start it anyway. Not sure if that is a big deal. --- gnu/packages/mate.scm | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm index 44420147a3..1a8a268cc9 100644 --- a/gnu/packages/mate.scm +++ b/gnu/packages/mate.scm @@ -7,6 +7,7 @@ ;;; Copyright © 2019 Guy Fleury Iteriteka ;;; Copyright © 2020 Jonathan Brielmaier ;;; Copyright © 2020 Mathieu Othacehe +;;; Copyright © 2021 Brendan Tildesley ;;; ;;; This file is part of GNU Guix. ;;; @@ -1511,6 +1512,14 @@ MATE Desktop to monitor your system resources and usage.") ("gtk+" ,gtk+) ("gdk-pixbuf" ,gdk-pixbuf) ("polkit" ,polkit))) + ;; This will allow mate-polkit to be used with XFCE too. + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-desktop-for-xfce + (lambda _ + (substitute* "src/polkit-mate-authentication-agent-1.desktop.in.in" + (("MATE;") "MATE;XFCE;"))))))) (home-page "https://mate-desktop.org/") (synopsis "DBus specific service for MATE") (description -- 2.31.1