Message ID | 13b0be17-7d6d-dc37-c5d7-44171301f477@disroot.org |
---|---|
State | Accepted |
Headers | show |
Series | [bug#43348] Profanity | expand |
Context | Check | Description |
---|---|---|
cbaines/applying patch | fail | View Laminar job |
Hi RG, thank you! That's almost perfect. I still don't get it why python-wrapper is a *native* input in order to support Python plugins. That would mean the Python plugins are only used at build time and not used at runtime. Is that correct?
Hi Danny! > thank you! That's almost perfect. \o/ :-) > I still don't get it why python-wrapper is a *native* input in order to support > Python plugins. That would mean the Python plugins are only used at build time > and not used at runtime. Is that correct? As far as I understand, the package uses the python binary to compile a component, which will be used to add/remove python plugins. Regards, RG.
Hi RG, On Sun, 13 Sep 2020 05:12:04 -0400 Raghav Gururajan <raghavgururajan@disroot.org> wrote: > > I still don't get it why python-wrapper is a *native* input in order to support > > Python plugins. That would mean the Python plugins are only used at build time > > and not used at runtime. Is that correct? > > As far as I understand, the package uses the python binary to compile a > component, which will be used to add/remove python plugins. I doubt it. $ ./pre-inst-env guix gc --references `./pre-inst-env guix build profanity` [...] /gnu/store/09a5iq080g9b641jyl363dr5jkkvnhcn-python-3.8.2 So it keeps a runtime reference to python. I suspect it just embeds a Python interpreter. So it should probably be a regular input. The question is whether the plugins written in Python actually work or not. Usually they require some extra PYTHONPATH or whatever setting in order to find stuff. Just raw Python is often not enough. But we'll see. Moved python-wrapper to regular input. Pushed patchset to master. I edited the commit messages not to include internal rationale like that that change is the correct change (for glib-or-gtk-build-system) or whatever. If we need that it should go in the source code as a comment--where it can be easily seen.
From 1c777d5bd598f97bf6978f863d6752e0942ab236 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan <raghavgururajan@disroot.org> Date: Sun, 13 Sep 2020 00:30:10 -0400 Subject: [PATCH 4/4] gnu: profanity: Change build system. * gnu/package/messaging.scm (profanity) [build-system]: Change from gnu to glib-or-gtk. Glib-or-gtk is the appropriate build system, as the package depends on glib and gtk+. --- gnu/packages/messaging.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 232d80a5fc..ef553e2acb 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1783,7 +1783,7 @@ are both supported).") (sha256 (base32 "00j9l9v62rz9hprgiy1vrz8v3v59ph18h8kskqxr31fgqvjv5xr3")))) - (build-system gnu-build-system) + (build-system glib-or-gtk-build-system) (arguments `(#:configure-flags (list -- 2.28.0