From patchwork Sat Mar 25 05:36:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip McGrath X-Patchwork-Id: 48663 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 611C516FBE; Sat, 25 Mar 2023 11:51:24 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D4ACF16D87 for ; Sat, 25 Mar 2023 11:51:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pg2QP-0002g0-Ni; Sat, 25 Mar 2023 07:51:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2QO-0002fp-F4 for guix-patches@gnu.org; Sat, 25 Mar 2023 07:51:08 -0400 Received: from [209.51.188.43] (helo=debbugs.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pg2QO-0007YU-6e for guix-patches@gnu.org; Sat, 25 Mar 2023 07:51:08 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pg2QH-0003qj-MP for guix-patches@gnu.org; Sat, 25 Mar 2023 07:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62231] Chez Scheme for Racket build on aarch64 (patch attached) Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Mar 2023 11:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 62231@debbugs.gnu.org, Tim Johann Cc: ludo@gnu.org, liliana.prikler@gmail.com Received: via spool by 62231-submit@debbugs.gnu.org id=B62231.167974505414785 (code B ref 62231); Sat, 25 Mar 2023 11:51:01 +0000 Received: (at 62231) by debbugs.gnu.org; 25 Mar 2023 11:50:54 +0000 Received: from localhost ([127.0.0.1]:41877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2QA-0003qO-2u for submit@debbugs.gnu.org; Sat, 25 Mar 2023 07:50:54 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:55829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2Q8-0003qB-HR for 62231@debbugs.gnu.org; Sat, 25 Mar 2023 07:50:53 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id DB24058226F; Sat, 25 Mar 2023 01:36:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 25 Mar 2023 01:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= philipmcgrath.com; h=cc:cc:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1679722595; x=1679729795; bh=/kVa1/JW8Gie/Mm3gdp6WVGWKJPJXys8WOl wm4x5HGc=; b=dPRTKs9GObTmQZYKDMhL2eworHIkij29yDJzB5Z0nPiEN4vrOK5 lQXOaPyY0uJRh158KHA4xcEPtddjUf+j34mTRc9/AEpfxtWFh1w+9I0HbDSZ0gB/ g4PvktyZoqI9lHLY257CLoi89owwD5/d7P/U4GIPZskTCHn2O6wXJNC1gYw59Tm9 plu1MqWLmv/eLmiBCgj9DEJgVOjyQMVbqiCzP6wWqipxOWRNJJxrsl7aFA2abEJi hrSkYfsv2WwDnkjEmG9KbK3OkGUceY/o/OncdAYkJOCpK7tc7VPZgyANrL5XrAwW NVJfdaW0XCamt7AG5GILYgXqwFAKQSFkAJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679722595; x=1679729795; bh=/kVa1/JW8Gie/ Mm3gdp6WVGWKJPJXys8WOlwm4x5HGc=; b=Smd0NU9kgWviUgdoQgubRuOjYhbMZ UpzyGQpZ0Km3lHyjbRYHimY/zCDtabEZFQozyqWsGOUm/1RrQ7Sif4y+NOrNJ5GY Hy6reANbC4neUOIuO/a0xxit4RH92UkW6nrmPxmJKPfNr6zvTSNGwweH/W7YNBoN 2k/8Sp2NlBLrRJr1iJZY0MU3tOXukYQFjUBVQuHT9H201W0zH2I+Hg6Mpjtlfr3D u7c0BjfWiRBYXlkUVTnmdP5NPBdUmVExIshyomnF/QoyG2IgAR19x8zohSYlDWVy K+EFKmHzMCKFe37XgJfP5EcRESyz2J/IiQ2YZ3NIEcHVDxJ3QkgdyWkXg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegjedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhggtgesghdtre ertddtvdenucfhrhhomheprfhhihhlihhpucfotgfirhgrthhhuceophhhihhlihhpsehp hhhilhhiphhmtghgrhgrthhhrdgtohhmqeenucggtffrrghtthgvrhhnpeffkeduueeute ejjefggfdvhfegffetgfekgedtteeitdekhfelueeludehleefhfenucevlhhushhtvghr ufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehphhhilhhiphesphhhihhlih hpmhgtghhrrghthhdrtghomh X-ME-Proxy: Feedback-ID: i2b1146f3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 25 Mar 2023 01:36:25 -0400 (EDT) From: Philip McGrath Date: Sat, 25 Mar 2023 01:36:17 -0400 Message-ID: <13237587.uLZWGnKmhe@bastet> In-Reply-To: <87r0tdq51d.fsf@phrogstar.de> References: <87h6ukntrg.fsf@phrogstar.de> <4267909.iIbC2pHGDl@bastet> <87r0tdq51d.fsf@phrogstar.de> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches On Friday, March 24, 2023 4:03:19 PM EDT Tim Johann wrote: > Hi Philip, > > Happy to be of help. > > Thanks for the pointers, here's the amended patch. I hope it is to your > liking. > Thanks, this addresses my concerns! I'm not a Guix committer, so I'm cc'ing a couple of people who have applied recent patches to this file. They may want to review the commit message for style, also. I expect the underlying issue would also affect riscv64, but I hit some network trouble when trying to look for a build log just now. -Philip commit e3c514db745d48e5ef7f7abb7b45037341298b17 Author: Tim Johann Date: Fri Mar 24 21:09:52 2023 +0100 gnu: chez-scheme-for-racket-bootstrap-bootfiles: change for aarch64. * gnu/packages/chez.scm (chez-scheme-for-racket-bootstrap-bootfiles): Temporary change for build on aarch64, making racket available on aarch64. Architecture autodetect in rktboot only addresses x86 archs, so far. This work-around sets the architecture, looked up in translation table, explicitly. The long term solution should be to fix rktboot to include other natively supported architectures in the autodetect mechanism. cf. https://github.com/racket/racket/issues/3948 [arguments] use --machine even when architecture is supported by Racket's fork of ChezScheme. diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm index c6420a980e..ab6eaba6bd 100644 --- a/gnu/packages/chez.scm +++ b/gnu/packages/chez.scm @@ -692,10 +692,12 @@ (define-public chez-scheme-for-racket-bootstrap-bootfiles (search-input-file (or native-inputs inputs) "/opt/racket-vm/bin/racket") "../rktboot/main.rkt" - #$@(if (racket-cs-native-supported-system?) - #~() - (let ((m (nix-system->pbarch-machine-type))) - #~("--machine" #$m))))))))))))) + ;; Temporary handling of builds on non-x86 architectures, + ;; see https://github.com/racket/racket/issues/3948 + ;; Autodetect in rktboot only addresses x86 archs, so far. + #$@(let ((m (or (racket-cs-native-supported-system?) + (nix-system->pbarch-machine-type)))) + #~("--machine" #$m)))))))))))) (supported-systems (package-supported-systems chez-scheme-for-racket)) (home-page "https://github.com/racket/ChezScheme")