diff mbox series

[bug#54513] gnu: murmur-shepherd-service: Fix binary name

Message ID 12a1c44d-a9b8-d15e-9574-5e899260f66b@gmail.com
State Accepted
Headers show
Series [bug#54513] gnu: murmur-shepherd-service: Fix binary name | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

fesoj000 March 21, 2022, 9:42 p.m. UTC 
* gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
binary path of mumble server, which is now called mumble-server instead
of murmurd since version 1.4.x
---
  gnu/services/telephony.scm | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Liliana Marie Prikler March 23, 2022, 8:01 p.m. UTC | #1 
Am Montag, dem 21.03.2022 um 22:42 +0100 schrieb fesoj000:
> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server
> instead of murmurd since version 1.4.x
Nice catch, but perhaps we should rename the entire service and place a
deprecation notice at the appropriate location.
Ludovic Courtès March 24, 2022, 11:47 a.m. UTC | #2 
Hi,

fesoj000 <fesoj000@gmail.com> skribis:

> * gnu/services/telephony.scm: murmur-shepherd-service (start): fixed
> binary path of mumble server, which is now called mumble-server instead
> of murmurd since version 1.4.x

[...]

>            (start #~(make-forkexec-constructor
>                      '(#$(file-append (murmur-configuration-package config)
> -                                    "/bin/murmurd")
> +                                    "/bin/mumble-server")

There was a second instance of this that I fixed; I adjusted the commit
log and commit that.

Liliana Marie Prikler <liliana.prikler@gmail.com> skribis:

> Nice catch, but perhaps we should rename the entire service and place a
> deprecation notice at the appropriate location.

Yes, that would be a welcome change.

Thanks,
Ludo’.
diff mbox series

Patch

diff --git a/gnu/services/telephony.scm b/gnu/services/telephony.scm
index e678bae87c..d09877aedf 100644
--- a/gnu/services/telephony.scm
+++ b/gnu/services/telephony.scm
@@ -961,7 +961,7 @@  (define (murmur-shepherd-service config)
           (requirement '(networking))
           (start #~(make-forkexec-constructor
                     '(#$(file-append (murmur-configuration-package config)
-                                    "/bin/murmurd")
+                                    "/bin/mumble-server")
                       "-ini"
                       #$(or (murmur-configuration-file config)
                             (default-murmur-config config)))