From patchwork Sun Mar 23 14:25:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 40746 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 828CB27BBEA; Sun, 23 Mar 2025 14:29:06 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4868927BBE2 for ; Sun, 23 Mar 2025 14:29:06 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twMJ4-0003qA-UJ; Sun, 23 Mar 2025 10:28:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMJ1-0003pb-Lr for guix-patches@gnu.org; Sun, 23 Mar 2025 10:28:04 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twMJ1-0005jN-D9 for guix-patches@gnu.org; Sun, 23 Mar 2025 10:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=VxUd1aOcvzD/pYxOxBWjge8/c0+rM0LNoWab4Huyg4s=; b=OAmoG1igK46sAlvBYupjHMsdhMTohIEzRTqAIww8bq3xKqRhrwdFOWqjmyfQnvmo6Q8A6jstkwC8u9cLeIFo+j+XPI8sQ+AWU4YO+Bh31Aub4JK0H/Lg9ZoIo/piif+wR5E2r9no6QY7lxbjrz2GmGyrJ8aONxMwSxMHT715fBdVYoDI7QGjCC/8vOt9gxPJLUcD/ebOV43VtItUAnPo79GwJS3ZXss76d8/Ep9T6rsG+rY8zbhNT30IGLf4uhTxfy5blpvCdsZIWlmEfsh/SWQLspnBUyzD1ucn7Ugz8D3PVGKd7PMENcnvvcichU3AOIx3aZCFltBvAMZU+k0DMA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1twMJ1-0005qE-85 for guix-patches@gnu.org; Sun, 23 Mar 2025 10:28:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#75810] [PATCH v8 11/16] linux-container: =?utf-8?q?=E2=80=98un?= =?utf-8?q?privileged-user-namespace-supported=3F=E2=80=99?= returns #f on non-Linux. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Mar 2025 14:28:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75810 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75810@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Reepca Russelstein Received: via spool by 75810-submit@debbugs.gnu.org id=B75810.174274007722389 (code B ref 75810); Sun, 23 Mar 2025 14:28:03 +0000 Received: (at 75810) by debbugs.gnu.org; 23 Mar 2025 14:27:57 +0000 Received: from localhost ([127.0.0.1]:51909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twMIt-0005ol-Bz for submit@debbugs.gnu.org; Sun, 23 Mar 2025 10:27:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41158) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twMGt-0005Sd-Lv for 75810@debbugs.gnu.org; Sun, 23 Mar 2025 10:25:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twMGn-0005TK-U5; Sun, 23 Mar 2025 10:25:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=VxUd1aOcvzD/pYxOxBWjge8/c0+rM0LNoWab4Huyg4s=; b=Su3HxvVMAZK5ljEaMViv L1ta/0FhfUhd3lGUGrXNcw1yqQ83DAeK2j0w0yPjif+zVXpGxmnUvMRBUEFNJIvB2xmC69r/XkXvp iA+GEMrgdNYxiQ3gY6kgP5WjVmr7/jZYjaEPS6zpRKsNk1F2f41cb6whOypsf83SCXx5UjrNhhbxx Zzhz0icIsFVre3WvLgcfgYM3JKcTkc2HOa2BEJdIg3EX1iGS2YL4XLwxNofD1dMIr8GlNA3aGGNH+ gF/aEMbERBD887adXM46ircWbzpp+c7MYZK4AI+JAsRXFdFwwqr9iFxe7FLB34Skqs7/ous4AuoD/ yqe+bA9eMNjvWA==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Sun, 23 Mar 2025 15:25:04 +0100 Message-ID: <12613de1aa1c0a772ce26b7dc4e484b80a17ffa8.1742739609.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Previously this procedure would return #t on non-Linux systems. * gnu/build/linux-container.scm (unprivileged-user-namespace-supported?): When USERNS-FILE doesn’t exist, return (user-namespace-supported?). Reported-by: Reepca Russelstein Change-Id: I92050338b8b68bc3bd87100317eba69fcdf14a0a --- gnu/build/linux-container.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/build/linux-container.scm b/gnu/build/linux-container.scm index 5c303da8c8..a5c5d8962e 100644 --- a/gnu/build/linux-container.scm +++ b/gnu/build/linux-container.scm @@ -1,6 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2015 David Thompson -;;; Copyright © 2017-2019, 2022, 2023 Ludovic Courtès +;;; Copyright © 2017-2019, 2022-2023, 2025 Ludovic Courtès ;;; ;;; This file is part of GNU Guix. ;;; @@ -44,7 +44,7 @@ (define (unprivileged-user-namespace-supported?) (let ((userns-file "/proc/sys/kernel/unprivileged_userns_clone")) (if (file-exists? userns-file) (eqv? #\1 (call-with-input-file userns-file read-char)) - #t))) + (user-namespace-supported?)))) (define (setgroups-supported?) "Return #t if the setgroups proc file, introduced in Linux-libre 3.19,