[bug#70843] guix-install.sh: Relax check for OpenRC.

Message ID 10938d4d6fa68f33bf4cbf877ca2462e2547542e.1715249659.git.~@wolfsden.cz
State New
Headers
Series [bug#70843] guix-install.sh: Relax check for OpenRC. |

Commit Message

Tomas Volf May 9, 2024, 10:14 a.m. UTC
On my virtual private servers running Alpine, the install script failed to
identify the init system.  The virtual server is LXC based, and OpenRC
identifies itself like this:

    # openrc --version
    openrc (OpenRC [LXC]) 0.52.1

The regular expression failed to match it.  After relaxing the check (by
removing the trailing `)' requirement) the installation went fine and I got
functional Guix installation.

* etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
expression.

Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a
---
 etc/guix-install.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ludovic Courtès June 2, 2024, 9:41 a.m. UTC | #1
Tomas Volf <~@wolfsden.cz> skribis:

> On my virtual private servers running Alpine, the install script failed to
> identify the init system.  The virtual server is LXC based, and OpenRC
> identifies itself like this:
>
>     # openrc --version
>     openrc (OpenRC [LXC]) 0.52.1
>
> The regular expression failed to match it.  After relaxing the check (by
> removing the trailing `)' requirement) the installation went fine and I got
> functional Guix installation.
>
> * etc/guix-install.sh (chk_init_sys): Drop trailing \) from the regular
> expression.
>
> Change-Id: I5f951226341e631fb34cc6c26cfbb87656dab77a

Applied, thanks!
  

Patch

diff --git a/etc/guix-install.sh b/etc/guix-install.sh
index 82accfd5d5..c5a04bb1f4 100755
--- a/etc/guix-install.sh
+++ b/etc/guix-install.sh
@@ -217,7 +217,7 @@  chk_init_sys()
         _msg "${INF}init system is: sysv-init"
         INIT_SYS="sysv-init"
         return 0
-    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC\) ]]; then
+    elif [[ $(openrc --version 2>/dev/null) =~ \(OpenRC ]]; then
         _msg "${INF}init system is: OpenRC"
         INIT_SYS="openrc"
         return 0