diff mbox series

[bug#44957,PIDGIN] : v4

Message ID 0f5a0572-1c6e-cd3b-2253-66d9fdfc2572@raghavgururajan.name
State Accepted
Headers show
Series [bug#44957,PIDGIN] : v4 | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Raghav Gururajan Dec. 30, 2020, 9:08 p.m. UTC 
Hi Danny!

> applied patches 4,5,6 (the ones adding packages).

Thanks!

> The other patches (especially patch 2) currently do not apply to guix master,
> with or without cosmetic changes.  Please update those.

Please find the updated patches attached with this email.

Regards,
RG.

Comments

Danny Milosavljevic Dec. 31, 2020, 12:54 a.m. UTC | #1 
Hi RG,

please, when enabling features, add one feature per patch here and mention the
feature by name per patch.

Also, please keep in mind the issues raised in '"questionable changes" commits'
mailing list thread.
diff mbox series

Patch

From 9da370d9cbad01394dc16f19039503e755c60345 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <rg@raghavgururajan.name>
Date: Wed, 30 Dec 2020 16:05:42 -0500
Subject: [PATCH 10/10] gnu: pidgin-otr: Add some inputs.

* gnu/packages/messaging.scm (pidgin-otr) [native-inputs]: Add
gettext-minimal.
[inputs]: Add perl.
---
 gnu/packages/messaging.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index ebc88e5c3d..8b1481513d 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -664,7 +664,8 @@  many popular chat protocols.")
         (base32 "1i5s9rrgbyss9rszq6c6y53hwqyw1k86s40cpsfx5ccl9bprxdgl"))))
     (build-system gnu-build-system)
     (native-inputs
-     `(("intltool" ,intltool)
+     `(("gettext" ,gettext-minimal)
+       ("intltool" ,intltool)
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("glib" ,glib)
@@ -672,6 +673,7 @@  many popular chat protocols.")
        ("libgcrypt" ,libgcrypt)
        ("libgpg-error" ,libgpg-error)
        ("libotr" ,libotr)
+       ("perl" ,perl)
        ("pidgin" ,pidgin)))
     (home-page "https://otr.cypherpunks.ca/")
     (synopsis "Off-the-Record Messaging plugin for Pidgin")
-- 
2.29.2