Message ID | 0eeef48b6f5e136faac5aaf8c3ba997fa8caba0c.camel@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E657117009; Sun, 26 Mar 2023 07:39:28 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0928B16934 for <patchwork@mira.cbaines.net>; Sun, 26 Mar 2023 07:39:28 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1pgK17-00008Q-0N; Sun, 26 Mar 2023 02:38:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pgK13-00005P-R8 for guix-patches@gnu.org; Sun, 26 Mar 2023 02:38:09 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pgK13-0004f5-JS for guix-patches@gnu.org; Sun, 26 Mar 2023 02:38:09 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1pgK13-0003bu-FY for guix-patches@gnu.org; Sun, 26 Mar 2023 02:38:09 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62252] [PATCH v3 09/19] gnu: python-hatchling: Use upstream homepage. References: <291d52e688bb1d56ecd6561282fd9713bf237ed9.camel@gmail.com> In-Reply-To: <291d52e688bb1d56ecd6561282fd9713bf237ed9.camel@gmail.com> Resent-From: Liliana Marie Prikler <liliana.prikler@gmail.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 26 Mar 2023 06:38:09 +0000 Resent-Message-ID: <handler.62252.B62252.167981266413702@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62252 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62252@debbugs.gnu.org Cc: Ricardo Wurmus <rekado@elephly.net> Received: via spool by 62252-submit@debbugs.gnu.org id=B62252.167981266413702 (code B ref 62252); Sun, 26 Mar 2023 06:38:09 +0000 Received: (at 62252) by debbugs.gnu.org; 26 Mar 2023 06:37:44 +0000 Received: from localhost ([127.0.0.1]:43953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1pgK0d-0003Yp-Tk for submit@debbugs.gnu.org; Sun, 26 Mar 2023 02:37:44 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:38902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <liliana.prikler@gmail.com>) id 1pgK0A-0003Ue-KY for 62252@debbugs.gnu.org; Sun, 26 Mar 2023 02:37:19 -0400 Received: by mail-wr1-f65.google.com with SMTP id q19so2484324wrc.5 for <62252@debbugs.gnu.org>; Sat, 25 Mar 2023 23:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679812629; h=message-id:cc:to:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=OrLPjStS33jCbBfMaU2F+/mK7rNgtdTs+SCFrO0N1ds=; b=cv1Kjmf+kCtDM8tXOolOvQ7AX/2RVW1Yy9m2XhMUrKEji/8Jhq0/9Gc2ucU4lwNjM5 0ptrWx2P3yxOm7MjOPzy0UW2KcoSLG7DS5jJAXf9Ry0dnpmCUW63n/Y9VdRKX2fo9LT4 C7lyfeQjijIcgxDu1Zd10zx2Uu5yMVt0vMwNq4+/egwvnKVjngbDxqTRsY2vef/4PB9A MvtZD3GR3G43BMlRGhbTN0GZ79AhlQxOSOprPSY4jf/gBN1D5ZjC80hz4HzrPgxvcLyA OGzZI9r2h9WhtajUUYX+e7GVIMyqJGFAPNFDsX3aiB1OO7wufcxMPsrazT/UXXIt71Ka 876A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679812629; h=message-id:cc:to:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OrLPjStS33jCbBfMaU2F+/mK7rNgtdTs+SCFrO0N1ds=; b=tJDWEd6Om6VyTceTjHzvk3Ofhdy4SiH9mGlFseu4+0mRrAWzcSwEQEguKXzK12niLp KB/DvAkMIap5zbEFe0Nugi19FL05B4cnDgmcAA6lSkXlZTjBMRzsgU2cfDn0w8XrcOsr yMltmI1rhPeQEQ5HlPdRUlV74ZNmPn80enqubxQFQo9nNVMFXMCQfmtK3GqyYkJiW5NB cYOqZKEFoAGUu2LHFLzV+UmrLLSf+rGZf57fdWcQB3psYknMdjZxCpFx0KPwh5eTHXfZ bZ8Hr/IG8l6VNROVyJeLfzbHZKHE/exGmyrD3VhBHEGPTfquyAY+Ju5OxztzVxzsVdTg T/tw== X-Gm-Message-State: AAQBX9dupsrEUlpWx54Fv8YFjAUIEIvkN1yKG/LDmF8mreSHQdfKRyn2 pGkMYF35Y8s2qd9vCQqiLF6sgrLMBkrW2w== X-Google-Smtp-Source: AKy350bAq9NSyu1D2GfjBzoc0f+3liW9fdnjKxfX5ecZirbn57rOn9NTSAUb+sKrY6ubc3Md+S+VLA== X-Received: by 2002:adf:dc47:0:b0:2c5:5d21:7d4c with SMTP id m7-20020adfdc47000000b002c55d217d4cmr5989849wrj.43.1679812629108; Sat, 25 Mar 2023 23:37:09 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id z6-20020a056000110600b002c557f82e27sm21953707wrw.99.2023.03.25.23.37.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Mar 2023 23:37:08 -0700 (PDT) From: Liliana Marie Prikler <liliana.prikler@gmail.com> Date: Sun, 26 Mar 2023 08:19:53 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Message-ID: <0eeef48b6f5e136faac5aaf8c3ba997fa8caba0c.camel@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
None
|
|
Commit Message
Liliana Marie Prikler
March 26, 2023, 6:19 a.m. UTC
* gnu/packages/python-xyz.scm (python-hatchling)[home-page]: Use “hatch.pypa.io”. --- gnu/packages/python-xyz.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi, I have built python-orjson on wip-rekado-rust-team, which is based on top of the rust-team (but rebased on top of current master). This lets us build python-fastapi without having to remove orjson. (I worked on packaging python-fastapi for python-pytorch-lightning.) My python-fastapi package looks like this: --8<---------------cut here---------------start------------->8--- +(define-public python-fastapi + (package + (name "python-fastapi") + (version "0.95.0") + (source (origin + (method url-fetch) + (uri (pypi-uri "fastapi" version)) + (sha256 + (base32 + "062fy794mv0yfb4ac5yaaqh6a0k7npa0n7dc4x0a5ncx1sqzvm4r")))) + (build-system pyproject-build-system) + (arguments + (list + #:test-flags '(list "tests"))) + (propagated-inputs (list python-pydantic python-starlette)) + (native-inputs (list python-anyio + python-black + python-coverage + python-databases + python-email-validator + python-flask + python-hatchling + python-httpx + python-isort + python-jose + python-multipart + python-mypy + python-orjson + python-passlib + python-peewee + python-pre-commit + python-pytest + python-pyyaml + python-sqlalchemy + python-types-orjson + python-types-ujson + python-ujson + python-uvicorn)) … --8<---------------cut here---------------end--------------->8--- The update of pathspec looks good to me, though with 300+ rebuilds this whole thing should probably be built out on a feature branch first. The starlette update also looks good to me, though you could move it to 0.26.1 (with hash 1gd9pvcfifrlaskqz741n4rbsgljn6jnjgkscvj211paay87knj1). I used the version form pypi which didn’t come with tests, so I don’t know if running the tests of 0.26.1 is more difficult than running those of 0.25. In any case, this whole patch set looks good to me. I’m sorry for stepping on your toes with python-hatchling.
Am Sonntag, dem 26.03.2023 um 09:55 +0200 schrieb Ricardo Wurmus: > Hi, > > I have built python-orjson on wip-rekado-rust-team, which is based on > top of the rust-team (but rebased on top of current master). This > lets us build python-fastapi without having to remove orjson. Do we have an ETA on wip-rekado-rust-team? And most importantly, does it come with antioxidant? :) > (I worked on packaging python-fastapi for python-pytorch-lightning.) > > My python-fastapi package looks like this: > > --8<---------------cut here---------------start------------->8--- > +(define-public python-fastapi > + (package > + (name "python-fastapi") > + (version "0.95.0") > + (source (origin > + (method url-fetch) > + (uri (pypi-uri "fastapi" version)) > + (sha256 > + (base32 > + > "062fy794mv0yfb4ac5yaaqh6a0k7npa0n7dc4x0a5ncx1sqzvm4r")))) > + (build-system pyproject-build-system) > + (arguments > + (list > + #:test-flags '(list "tests"))) > + (propagated-inputs (list python-pydantic python-starlette)) > + (native-inputs (list python-anyio > + python-black > + python-coverage > + python-databases > + python-email-validator > + python-flask > + python-hatchling > + python-httpx > + python-isort > + python-jose > + python-multipart > + python-mypy > + python-orjson > + python-passlib > + python-peewee > + python-pre-commit > + python-pytest > + python-pyyaml > + python-sqlalchemy > + python-types-orjson > + python-types-ujson > + python-ujson > + python-uvicorn)) > … > --8<---------------cut here---------------end--------------->8--- > > The update of pathspec looks good to me, though with 300+ rebuilds > this whole thing should probably be built out on a feature branch > first. Hmm, 380 rebuilds would be fine if it was just python imho, but since it appears to cut into R and Gnome as well, I get your point. Should we do the typical -next dance? > The starlette update also looks good to me, though you could move it > to 0.26.1 (with hash > 1gd9pvcfifrlaskqz741n4rbsgljn6jnjgkscvj211paay87knj1). > I used the version form pypi which didn’t come with tests, so I don’t > know if running the tests of 0.26.1 is more difficult than running > those of 0.25. I actually haven't tested 0.26.1 – the patch was lying around for some while before committing, since I didn't have the other parts running back then. I'll probably send a v4 once I check whether there's an issue and what that issue might be. Cheers
Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Sonntag, dem 26.03.2023 um 09:55 +0200 schrieb Ricardo Wurmus: >> Hi, >> >> I have built python-orjson on wip-rekado-rust-team, which is based on >> top of the rust-team (but rebased on top of current master). This >> lets us build python-fastapi without having to remove orjson. > Do we have an ETA on wip-rekado-rust-team? And most importantly, does > it come with antioxidant? :) wip-rekado-rust-team is held up by the merge of the rust-team branch; that one can only be merged once we’ve built rust on aarch64. This hasn’t succeeded yet as the builds time out or fail due to lack of resources. I’m trying to build it manually on ci.guix.gnu.org (i.e. not through cuirass), so I have more control over options. When rust-team has been merged, we’d build the few extra commits added by wip-rekado-rust-team and merged that too. > Hmm, 380 rebuilds would be fine if it was just python imho, but since > it appears to cut into R and Gnome as well, I get your point. Should > we do the typical -next dance? I don’t know. I thought: rebase a feature branch on top of master, start building it on ci, merge as soon as it’s done. >> The starlette update also looks good to me, though you could move it >> to 0.26.1 (with hash >> 1gd9pvcfifrlaskqz741n4rbsgljn6jnjgkscvj211paay87knj1). >> I used the version form pypi which didn’t come with tests, so I don’t >> know if running the tests of 0.26.1 is more difficult than running >> those of 0.25. > I actually haven't tested 0.26.1 – the patch was lying around for some > while before committing, since I didn't have the other parts running > back then. I'll probably send a v4 once I check whether there's an > issue and what that issue might be. Good good!
Am Sonntag, dem 26.03.2023 um 12:14 +0200 schrieb Ricardo Wurmus: > > Hmm, 380 rebuilds would be fine if it was just python imho, but > > since it appears to cut into R and Gnome as well, I get your point. > > Should we do the typical -next dance? > > I don’t know. I thought: rebase a feature branch on top of master, > start building it on ci, merge as soon as it’s done. I split the series into one part that can go to master and the rest went to the new "clinguin" branch. How do I get that to build on CI? Cheers
diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 81101be1da..659339d2a5 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -1795,7 +1795,7 @@ (define-public python-hatchling python-pathspec python-pluggy python-tomli)) - (home-page "https://pypi.org/project/hatchling/") + (home-page "https://hatch.pypa.io/") (synopsis "Extensible Python build backend") (description "Hatchling is an extensible Python build backend.") (license license:expat)))