From patchwork Wed Jan 8 21:51:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 36792 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 8D04427BBE9; Wed, 8 Jan 2025 21:54:37 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 2166A27BBEA for ; Wed, 8 Jan 2025 21:54:37 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVe0U-0000zF-Sl; Wed, 08 Jan 2025 16:54:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVe03-000069-Oq for guix-patches@gnu.org; Wed, 08 Jan 2025 16:54:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVe03-0004GT-Fc; Wed, 08 Jan 2025 16:54:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=emTGtHy+fK6l0puxRTyccYSeAJFk1ZfY4yWYha0ivCk=; b=Teh13hbBXXQjM+FCuFszZksJYDX2EDf2QrZX8hGGAxop1aUuH+lhauNynV7RcYzVEQJxjZ933DRRETWdE4Z1sCaLe4uc5yeLenLlrocau2vtDi3NZ+g6lmIk6bPDxZNDK4sqd/Ym36rsX3IvoeA8PRrgF1KCD1GSbBcJ7E33gm1hb15uzBKaD0K5W7DjOURO/UwMIyDtue4sHsHP98E3BMPLIDsoDB8ZYdXg36iHMhvBiqQz7bzFKArzTuXqFNMfmAuKzYAwXOFSyE7vcwoN73AAPYiwXAd7Kt8AqmwD7NpRQ4ZSqo0zKsesT9yjoY5rCNjetSbdb+8yPPFg4KELxA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVe03-0005Xh-Ar; Wed, 08 Jan 2025 16:54:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74860] [PATCH v3 07/12] services: rottlog: Deprecate. Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Wed, 08 Jan 2025 21:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74860 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74860@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Ludovic =?utf-8?q?Court?= =?utf-8?q?=C3=A8s?= , Maxim Cournoyer X-Debbugs-Original-Xcc: Ludovic =?utf-8?q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 74860-submit@debbugs.gnu.org id=B74860.173637319121174 (code B ref 74860); Wed, 08 Jan 2025 21:54:03 +0000 Received: (at 74860) by debbugs.gnu.org; 8 Jan 2025 21:53:11 +0000 Received: from localhost ([127.0.0.1]:49312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVdzC-0005VJ-CH for submit@debbugs.gnu.org; Wed, 08 Jan 2025 16:53:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37992) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVdz5-0005Sh-Ck for 74860@debbugs.gnu.org; Wed, 08 Jan 2025 16:53:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVdz0-00046b-1h; Wed, 08 Jan 2025 16:52:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=emTGtHy+fK6l0puxRTyccYSeAJFk1ZfY4yWYha0ivCk=; b=BAyYKBk10aNYZ9ue1S2c 4PUXkj+rsYhzPTXjYYAyCXyAtFg1+Pwt5eRbzGwdkY3P71IqVRjU+0VlMpaWhUO3bCif/KqbuRmvg mmTAv4uNZJkLhT/6VBKpVCISW2AoX8Fi8o/L7Fpy1ulWmVhMU++N7cAry5Od4+SEQH79IG9hdjSW1 zx3Os0nu8RUZWzT5OFPeztaA1Hw3f+IG0nq7bibQbZ7QXg+Y6vGh2cSso9Vo6nKqj3KUGHtKUQrGQ 0MoKlI3nneLpyV48fuiGoEvbsoX/NDcVQmUeVHeUT6jXHrTa0xdvj0Rg+F5KGaSYlhg3487NQN39o FyCsa4AK42AjZg==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Wed, 8 Jan 2025 22:51:55 +0100 Message-ID: <0bc8156ace914dd7e1b8f8a5c7741d8b5af7b8fe.1736373023.git.ludo@gnu.org> X-Mailer: git-send-email 2.47.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * gnu/services/admin.scm (rottlog-service-type): Deprecate. * doc/guix.texi (Log Rotation): Add deprecation warning. Change-Id: I661666ff3de64a69ff4f4982d7f432fd575c36df --- doc/guix.texi | 7 +++++++ gnu/services/admin.scm | 9 +++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 0e8945be16..7bc1d0b9e5 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -20952,6 +20952,13 @@ Log Rotation rotation tool (@pxref{Top,,, rottlog, GNU Rot[t]log Manual}), is also provided. +@quotation Warning +The Rottlog service presented here is deprecated in favor of +@code{log-rotation-service-type} (see above). The +@code{rottlog-service-type} variable and related tools will be removed +after 2025-06-15. +@end quotation + The example below shows how to extend it with an additional @dfn{rotation}, should you need to do that (usually, services that produce log files already take care of that): diff --git a/gnu/services/admin.scm b/gnu/services/admin.scm index f3331ae835..54a22d98dc 100644 --- a/gnu/services/admin.scm +++ b/gnu/services/admin.scm @@ -38,6 +38,7 @@ (define-module (gnu services admin) #:use-module (gnu system accounts) #:use-module ((gnu system shadow) #:select (account-service-type)) #:use-module ((guix store) #:select (%store-prefix)) + #:use-module (guix deprecation) #:use-module (guix gexp) #:use-module (guix modules) #:use-module (guix packages) @@ -334,12 +335,16 @@ (define (rottlog-jobs-or-default config) (or (rottlog-configuration-jobs config) (default-jobs (rottlog-configuration-rottlog config)))) -(define rottlog-service-type +;; TODO: Deprecated; remove sometime after 2025-06-15. +(define-deprecated rottlog-service-type + log-rotation-service-type (service-type (name 'rottlog) (description "Periodically rotate log files using GNU@tie{}Rottlog and GNU@tie{}mcron. -Old log files are removed or compressed according to the configuration.") +Old log files are removed or compressed according to the configuration. + +This service is deprecated and slated for removal after 2025-06-15.") (extensions (list (service-extension etc-service-type rottlog-etc) (service-extension mcron-service-type rottlog-jobs-or-default)