| Message ID | 0b8b70e2ec03a5e37f7fa71946f61c793c95b2ee.1736287537.git.brian@kubisiak.com |
|---|---|
| State | New |
| Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 848C527BBE9; Tue, 7 Jan 2025 22:08:29 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id EDB7827BBE2 for <patchwork@mira.cbaines.net>; Tue, 7 Jan 2025 22:08:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1tVHk6-0003in-Ld; Tue, 07 Jan 2025 17:08:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tVHk2-0003iW-J7 for guix-patches@gnu.org; Tue, 07 Jan 2025 17:08:02 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tVHk2-0000Hf-AP for guix-patches@gnu.org; Tue, 07 Jan 2025 17:08:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:Subject; bh=z3P+xDg4AWC99qk9lv8KbckI1gpKos0hET3VQMy91GI=; b=ZjbB8m3JsQw3afHIkRAMHvCkMBsgYmGNV5AYqx3gPZOqbd/JqEPUYI3WhitPSOI+NrPQ64Ydk6aMC1d1T9yCZNV7S5xtXL61Bzx3CqdcGufmmubp3CM1ZmILuU59vGMebiSLtquf4mGi18BdnAcKVn/SZu8FSOKiQ8/G5oPwxZr2bcapDmmzX5ymx+YFsKudkHnxKT1IpUZF6AqT59wuQTD5SzppPiNu4hRDZXY6Fwt/4rxwMpmoHz/CFGKT4voCZ5BOLXZqtMCwN6uvWfh1aebuZA84nVQNjapXWDY3wf5KPowmG332QiEo1PMmuvyqmvtxAD9RRbJqO6vQSmDNgA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1tVHk1-0001XO-Ud for guix-patches@gnu.org; Tue, 07 Jan 2025 17:08:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#75425] [PATCH] gnu: appimage-type2-runtime: Fix cross-compiling. Resent-From: Brian Kubisiak <brian@kubisiak.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 07 Jan 2025 22:08:01 +0000 Resent-Message-ID: <handler.75425.B.17362876515856@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 75425 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 75425@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17362876515856 (code B ref -1); Tue, 07 Jan 2025 22:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2025 22:07:31 +0000 Received: from localhost ([127.0.0.1]:44953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1tVHjX-0001WN-AV for submit@debbugs.gnu.org; Tue, 07 Jan 2025 17:07:31 -0500 Received: from lists.gnu.org ([2001:470:142::17]:44658) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <brian@kubisiak.com>) id 1tVHjV-0001W5-KR for submit@debbugs.gnu.org; Tue, 07 Jan 2025 17:07:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <brian@kubisiak.com>) id 1tVHjQ-0003h6-41 for guix-patches@gnu.org; Tue, 07 Jan 2025 17:07:24 -0500 Received: from [75.171.110.13] (helo=mail.kubisiak.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <brian@kubisiak.com>) id 1tVHjO-0000Du-HS for guix-patches@gnu.org; Tue, 07 Jan 2025 17:07:23 -0500 dkim-signature: v=1; a=rsa-sha256; d=kubisiak.com; s=s1; c=relaxed/relaxed; q=dns/txt; h=From:Subject:Date:Message-ID:To:MIME-Version:Content-Type; bh=z3P+xDg4AWC99qk9lv8KbckI1gpKos0hET3VQMy91GI=; b=QDHnl7S+HKaGdJ8cc2ti2O4d3Y2ShhdMpgS1kxJFTmDLTjgCt9dGc99J26o1b3B4R0fBPMWFhuhNkUlkQK2fSLQ+s1rqsGB1t8UtN7/jvV89dprLLAIuRP0peAPU69sXtjRih6e5+Ts7S1xff9O6cIed9ErnykJKuaF5wcb9D5qhAgqbWa0l9LxfpsaHpEx9hJS30IivcVqSMBynfa3U814Q8zIirZ+xJ3vd3IOmfgBt3EK5qyH8UE75PA OMZXbLpTpfV1cc98B2jtcwtlfUX0E9DQlfjB/UAlV5paSvQLSuNvgHZsu5PJsfM0Eos/sOmq8t0xPIgRWTrGkNj2dLLQ== Received: from peregrine (135-180-130-213.dsl.dynamic.sonic.net [135.180.130.213]) (envelope-sender <brian@kubisiak.com>) by mail.kubisiak.com with ESMTPSA id <0b8b70e2ec03a5e37f7fa71946f61c793c95b2ee.1736287537.git.brian@kubisiak.com> for <guix-patches@gnu.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256) ; Tue, 7 Jan 2025 16:07:17 -0600 Date: Tue, 7 Jan 2025 14:07:16 -0800 From: Brian Kubisiak <brian@kubisiak.com> Message-ID: <0b8b70e2ec03a5e37f7fa71946f61c793c95b2ee.1736287537.git.brian@kubisiak.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Host-Lookup-Failed: Reverse DNS lookup failed for 75.171.110.13 (failed) Received-SPF: pass client-ip=75.171.110.13; envelope-from=brian@kubisiak.com; helo=mail.kubisiak.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
| Series |
[bug#75425] gnu: appimage-type2-runtime: Fix cross-compiling.
|
|
Commit Message
Brian Kubisiak
Jan. 7, 2025, 10:07 p.m. UTC
* gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use CC-FOR-TARGET and add "-Wno-int-conversion". Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e --- gnu/packages/appimage.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0 prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5
Comments
user guix usertag 75425 + reviewed-looks-good thanks Guix QA review form submission: Cross build works for aarch64-linux-gnu and riscv-linux-gnu. I also checked that AppImage packs still work. Thanks for the patch! Items marked as checked: Lint warnings, Package builds, Commit messages
Brian Kubisiak <brian@kubisiak.com> writes: > * gnu/packages/appimage.scm (appimage-type2-runtime)[arguments]<#:make-flags>: Use > CC-FOR-TARGET and add "-Wno-int-conversion". > > Change-Id: I5dd9c6cb81e30713f17d474e9a5e11817db7158e > --- > gnu/packages/appimage.scm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm > index 1d0caada46..620628c053 100644 > --- a/gnu/packages/appimage.scm > +++ b/gnu/packages/appimage.scm > @@ -49,11 +49,13 @@ (define-public appimage-type2-runtime > (list > #:make-flags > #~(list "-Csrc/runtime" "runtime-fuse3" > + (string-append "CC=" #$(cc-for-target)) > (string-append > "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/" > " -DGIT_COMMIT='\"" "guix-" #$version "\"'" > " -D_FILE_OFFSET_BITS=64" > - " -static")) > + " -static" > + " -Wno-int-conversion")) > #:modules > `((guix build gnu-build-system) > (guix build utils) > > base-commit: a76f2d5927c86e4a76a1d3b49c1a37054612f6c0 > prerequisite-patch-id: b7500f0446826469bbf2f858e044cc3e0eae98c5 pushed, closing. And fix squashfuse-for-appimage's name, indentation.
diff --git a/gnu/packages/appimage.scm b/gnu/packages/appimage.scm index 1d0caada46..620628c053 100644 --- a/gnu/packages/appimage.scm +++ b/gnu/packages/appimage.scm @@ -49,11 +49,13 @@ (define-public appimage-type2-runtime (list #:make-flags #~(list "-Csrc/runtime" "runtime-fuse3" + (string-append "CC=" #$(cc-for-target)) (string-append "CFLAGS=" "-I" #$(this-package-input "fuse") "/include/fuse/" " -DGIT_COMMIT='\"" "guix-" #$version "\"'" " -D_FILE_OFFSET_BITS=64" - " -static")) + " -static" + " -Wno-int-conversion")) #:modules `((guix build gnu-build-system) (guix build utils)