diff mbox series

[bug#66038] gnu: muchsync: Update to 7.

Message ID 0b38d5ae8f6461cf5c95c9965bfc3970d043e598.1694900842.git.hendursaga@aol.com
State New
Headers show
Series [bug#66038] gnu: muchsync: Update to 7. | expand

Commit Message

Hendursaga Sept. 16, 2023, 9:48 p.m. UTC 
* gnu/packages/mail.scm (muchsync): Update to 7.
---
 gnu/packages/mail.scm | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)


base-commit: 952a0ce2800e4fe9165184151412858ed8d34760

Comments

Christopher Baines Sept. 25, 2023, 10:56 a.m. UTC | #1 
Hendursaga via Guix-patches via <guix-patches@gnu.org> writes:

> * gnu/packages/mail.scm (muchsync): Update to 7.
> ---
>  gnu/packages/mail.scm | 22 ++++++++++------------
>  1 file changed, 10 insertions(+), 12 deletions(-)

Thanks for the patch. I've tweaked the patch to remove the indentation
changes, as I wasn't sure those were intentional, and I've added a bit
to the commit message about the change to https, as that seems sensible.

Pushed to master as 7a563a4fafba05db0f423d9c4a7badc8f394182f.

Chris
Hendursaga Sept. 25, 2023, 5:21 p.m. UTC | #2 
Christopher Baines <mail@cbaines.net> writes:

> Thanks for the patch. I've tweaked the patch to remove the indentation
> changes, as I wasn't sure those were intentional[...]

I ran it through `guix style` as I thought one was supposed to do.
Should I have added something to the ChangeLog message to make that more
clear, perhaps?

I don't think I've replied to a "done" issue before, so I hope my
automagically generated Cc's are appropriate!

~ Hendursaga
Christopher Baines Sept. 25, 2023, 5:54 p.m. UTC | #3 
Hendursaga <hendursaga@aol.com> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> Thanks for the patch. I've tweaked the patch to remove the indentation
>> changes, as I wasn't sure those were intentional[...]
>
> I ran it through `guix style` as I thought one was supposed to do.
> Should I have added something to the ChangeLog message to make that more
> clear, perhaps?

Something to the commit message maybe, and it can also be useful to keep
stylistic changes and functional changes in separate commits. So you
would have a "apply guix style" commit and a "update to X" commit.

> I don't think I've replied to a "done" issue before, so I hope my
> automagically generated Cc's are appropriate!

Yep, I think it's fine.
diff mbox series

Patch

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index ecaab1c7cd..d070cf9518 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -1621,19 +1621,17 @@  (define-public bower
 (define-public muchsync
   (package
     (name "muchsync")
-    (version "6")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "http://www.muchsync.org/src/"
-                           "muchsync-" version ".tar.gz"))
-       (sha256
-        (base32 "1s799kx16nm5ry1fcqcc0grgxrwnnp4cnzd0hzwbkvc5v2sf6g8b"))))
+    (version "7")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.muchsync.org/src/" "muchsync-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1b5ylf0xgb59x6hna5gllm6nb1jn50wqvp7xfls83x0frmpjygpq"))))
     (build-system gnu-build-system)
-    (native-inputs
-     (list pandoc pkg-config))
-    (inputs
-     (list openssl notmuch sqlite xapian))
+    (native-inputs (list pandoc pkg-config))
+    (inputs (list openssl notmuch sqlite xapian))
     (home-page "https://www.muchsync.org/")
     (synopsis "Synchronize notmuch mail across machines")
     (description