From patchwork Wed Mar 22 04:54:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Bavier X-Patchwork-Id: 48563 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5235216FAA; Wed, 22 Mar 2023 04:55:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7863B16F9A for ; Wed, 22 Mar 2023 04:55:20 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peqV7-0005f1-6n; Wed, 22 Mar 2023 00:55:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peqV4-0005ej-Td for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peqV4-00024B-Jh for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peqV4-0007u3-Dj for guix-patches@gnu.org; Wed, 22 Mar 2023 00:55:02 -0400 Subject: bug#60266: [PATCH] gnu: Add form. Resent-From: Eric Bavier Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60266 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: Antero Mejr , Liliana Marie Prikler Cc: 60266-done@debbugs.gnu.org Mail-Followup-To: 60266@debbugs.gnu.org, bavier@posteo.net, antero@mailbox.org Received: via spool by 60266-done@debbugs.gnu.org id=D60266.167946086330323 (code D ref 60266); Wed, 22 Mar 2023 04:55:02 +0000 Received: (at 60266-done) by debbugs.gnu.org; 22 Mar 2023 04:54:23 +0000 Received: from localhost ([127.0.0.1]:33201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUR-0007t1-5E for submit@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peqUO-0007sm-Jj for 60266-done@debbugs.gnu.org; Wed, 22 Mar 2023 00:54:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 20DD9240533 for <60266-done@debbugs.gnu.org>; Wed, 22 Mar 2023 05:54:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679460854; bh=0NvzuAPzPNBHS6w6zsq9QaT7PIB1BMOh94Bhyef9aJI=; h=Subject:From:To:Cc:Date:From; b=B/wkq4CwWxHHBPC32IBVnwzonaKnXqMlITMoaoTLE5w0BHXaxDfyz0SXbNSkld1Ud FoolEwTVm8QrmplB1dVhh8I4I9NGrosLipTRI5DKqK1SEvxIE42sxl8uAgN5AGnYJ+ Il1BtL1DhNWUSnNqEqEG3+x7AXVs9g5iY4eon/dM4VNpXGmXrL/wy+CCPT/5JZBKL8 GOr0J90lW8wuBv9+ANRSFQQMlzLNrRarQtcWRZCl7UPoQYlGcny2s7RyRNfrf2pLpE 5SREYiK2B8mbHnSbKGmqxXa7uBgr2EZyyR1ISABusREE8vG67rdMWnZ4OiPr78iafj NHJJHwmRq8dRQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PhGN34dqDz9rxM; Wed, 22 Mar 2023 05:54:11 +0100 (CET) Message-ID: <07209d425a70f9e21169478617feba541de5ca13.camel@posteo.net> From: Eric Bavier Date: Wed, 22 Mar 2023 04:54:00 +0000 In-Reply-To: <87cz523ph5.fsf@mailbox.org> References: <20221223011551.32708-1-antero@mailbox.org> <92910915624cad61de6c1fc75cbe6ac2b8c6fe27.camel@posteo.net> <871qlpzebc.fsf@mailbox.org> <73af16a03efa3f4dad83bde3571731ce7a277360.camel@gmail.com> <87cz523ph5.fsf@mailbox.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Antero, Thank you for your effort in this review. On Tue, 2023-03-21 at 18:53 +0000, Antero Mejr wrote: > > > > Guix usually assumes `SSE2` capabilities for x86_64 targets, iirc. > > It does, but not for i386 to i686, which also often see sse2 flags in > > build systems. > > I did some benchmarks on a few workloads with millions of terms. The > "tunable" optimizations didn't consistently improve the > performance. Sometimes it would be a couple percent faster, sometimes > slower. So I didn't mark the package as tunable. I was watching my system load while `parform` was running its tests, and things did not seem compute bound, so the package being not tunable seems fine to me. > > > I used the other homepage so people can skip the weird "license > > > agreement" page at https://www.nikhef.nl/~form/. > > Calling the GPL a license agreement is weird, and it doesn't help that > > https://www.nikhef.nl/~form/maindir/ also refers to it. Perhaps we can > > raise an issue about that upstream? > > I would prefer not to bother upstream further regarding the website, > since I already had to ask them to change an invalid license statement > in a file header (which they did). Version 1 of the GPL used the term "license agreement" when describing itself, so the phrasing is not *super* weird, just maybe a bit outdated. There are also plenty of free software projects, e.g. nodejs, that present users with an "accept this license agreement" prompt in their M$ installers. I've pushed these patches in 15ee08ebf23ea6bc5be9fa157889419aa079076a and 31bed61b8278d3736cc29055d60db068a1160071 with a small adjustment to appease `guix lint`: Thanks again, `~Eric --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -1873,6 +1873,9 @@ (define-public form answers are returned in a textual mathematical representation. The size of the considered expressions in FORM is only limited by the available disk space and not by the available RAM.") + ;; XXX: Ignore this CVE to work around a name clash with the unrelated + ;; "neos/forms" package. + (properties '((lint-hidden-cve . ("CVE-2021-32697")))) ;; x86_64 only due to test failures on other platforms. ;; Developers say other platforms are not "tier 1" supported: ;; https://github.com/vermaseren/form/issues/426