diff mbox series

[bug#76712,1/7] gnu: vips: Build with OpenEXR 3.

Message ID 06d641635020158f92e009ad1a58b2f1830a9709.1741010255.git.monego@posteo.net
State New
Headers
Series Refactor and update libvips-related packages |

Commit Message

Vinicius Monego March 3, 2025, 2:02 p.m. UTC 
* gnu/packages/image-processing.scm (vips)[inputs]: Replace openexr-2 by
openexr.

Change-Id: I47fe672a7f9f27abe8e8b5d286ea00c1643e5c9f
---
 gnu/packages/image-processing.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Enge May 1, 2025, 7:11 a.m. UTC | #1 
Hello Vinicius,

would you like to take up this patch set again?
There is a slightly newer patch release of vips.

Concerning propagated inputs, I am not sure whether moving is the
correct approach. I understood that packages required during build
additionally need to be present as regular inputs. But this should
be easy to test. In any case, it would be helpful to add a comment
why inputs are propagated (for instance, a reference to the vips.pc
file).

Since you have commit rights, please feel free to push the patches
yourself once you have made sure that all depending packages build.

Thanks,

Andreas
Vinicius Monego May 4, 2025, 11:51 p.m. UTC | #2 
Em 01/05/2025 04:11, Andreas Enge escreveu:
> Hello Vinicius,

Hello Andreas,

> would you like to take up this patch set again?
> There is a slightly newer patch release of vips.
>
> Concerning propagated inputs, I am not sure whether moving is the
> correct approach. I understood that packages required during build
> additionally need to be present as regular inputs. But this should
> be easy to test. In any case, it would be helpful to add a comment
> why inputs are propagated (for instance, a reference to the vips.pc
> file).

I'm not sure whether this is documented, but it seems to be the common 
procedure. e.g. openexr propagates its private inputs (libdeflate and 
imath). I added a comment in vips on why those inputs are being propagated.

> Since you have commit rights, please feel free to push the patches
> yourself once you have made sure that all depending packages build.
>
> Thanks,
>
> Andreas
>
Done and pushed the series except for the last patch (will rethink it), 
thanks.
diff mbox series

Patch

diff --git a/gnu/packages/image-processing.scm b/gnu/packages/image-processing.scm
index 405f90ca9a..2f865e7192 100644
--- a/gnu/packages/image-processing.scm
+++ b/gnu/packages/image-processing.scm
@@ -810,7 +810,7 @@  (define-public vips
            libwebp
            matio
            niftilib
-           openexr-2
+           openexr
            orc
            pango
            poppler))