From patchwork Sat Feb 25 18:58:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Victal X-Patchwork-Id: 47313 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D22CE16B70; Sat, 25 Feb 2023 19:00:12 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 0124516AF4 for ; Sat, 25 Feb 2023 19:00:12 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVzmC-0002b1-5T; Sat, 25 Feb 2023 14:00:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVzm9-0002XT-GR for guix-patches@gnu.org; Sat, 25 Feb 2023 14:00:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pVzm9-00011W-59 for guix-patches@gnu.org; Sat, 25 Feb 2023 14:00:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pVzm9-000822-14 for guix-patches@gnu.org; Sat, 25 Feb 2023 14:00:05 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#61789] [PATCH 25/27] services: spice: Deprecate 'spice-vdagent-service' procedure. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Feb 2023 19:00:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61789 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61789@debbugs.gnu.org Cc: Bruno Victal Received: via spool by 61789-submit@debbugs.gnu.org id=B61789.167735156630735 (code B ref 61789); Sat, 25 Feb 2023 19:00:04 +0000 Received: (at 61789) by debbugs.gnu.org; 25 Feb 2023 18:59:26 +0000 Received: from localhost ([127.0.0.1]:41504 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVzlV-0007za-RT for submit@debbugs.gnu.org; Sat, 25 Feb 2023 13:59:26 -0500 Received: from smtpm8.myservices.hosting ([185.26.105.209]:46080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVzky-0007vL-Ua for 61789@debbugs.gnu.org; Sat, 25 Feb 2023 13:58:55 -0500 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm8.myservices.hosting (Postfix) with ESMTP id 1023A20D5D for <61789@debbugs.gnu.org>; Sat, 25 Feb 2023 19:58:27 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id C2ED080079; Sat, 25 Feb 2023 19:58:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id uzf6gadtJqK6; Sat, 25 Feb 2023 19:58:26 +0100 (CET) Received: from guix-nuc.home.arpa (bl9-119-177.dsl.telepac.pt [85.242.119.177]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id AA1C7800A3; Sat, 25 Feb 2023 19:58:25 +0100 (CET) From: Bruno Victal Date: Sat, 25 Feb 2023 18:58:11 +0000 Message-Id: <0645b758f5fb1d1b371ecd6fe57cb8ad18d768f7.1677350250.git.mirai@makinata.eu> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches * doc/guix.texi (Miscellaneous Services): Replace 'spice-vdagent-service' with 'spice-vdagent-service-type'. Document . * gnu/services/spice.scm (spice-vdagent-service): Deprecate procedure. --- doc/guix.texi | 25 ++++++++++++++++++------- gnu/services/spice.scm | 7 ++++--- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 466c6c98c9..7aa9f3a5e8 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -37751,16 +37751,27 @@ Miscellaneous Services @c TODO: Document , preferably by refactoring this to use @c define-configuration and generating documentation from it. -@cindex spice -@subsubheading Spice Service +@cindex SPICE +@subsubheading SPICE Service The @code{(gnu services spice)} module provides the following service. -@deffn {Scheme Procedure} spice-vdagent-service [#:spice-vdagent] -Returns a service that runs @url{https://www.spice-space.org,VDAGENT}, a daemon -that enables sharing the clipboard with a vm and setting the guest display -resolution when the graphical console window resizes. -@end deffn +@defvar spice-vdagent-service-type +Type of the service that runs @url{https://www.spice-space.org, VDAGENT}, +a daemon that enables sharing the clipboard with a vm and setting the +guest display resolution when the graphical console window resizes. +@end defvar + +@deftp {Data Type} spice-vdagent-configuration +Data type representing the configuration of +@code{spice-vdagent-service-type}. + +@table @asis +@item @code{spice-vdagent} (default: @code{spice-vdagent}) (type: file-like) +Package object for VDAGENT. + +@end table +@end deftp @cindex inputattach @subsubheading inputattach Service diff --git a/gnu/services/spice.scm b/gnu/services/spice.scm index e5ec46b9b5..b8d2f8486e 100644 --- a/gnu/services/spice.scm +++ b/gnu/services/spice.scm @@ -21,12 +21,13 @@ (define-module (gnu services spice) #:use-module (gnu packages spice) #:use-module (gnu services) #:use-module (gnu services shepherd) + #:use-module (guix deprecation) #:use-module (guix gexp) #:use-module (guix records) #:export (spice-vdagent-configuration spice-vdagent-configuration? spice-vdagent-service-type - spice-vdagent-service)) + spice-vdagent-service)) ; deprecated (define-record-type* spice-vdagent-configuration make-spice-vdagent-configuration @@ -74,8 +75,8 @@ (define spice-vdagent-service-type from the @code{spice-vdagent} package to enable window resizing and clipboard sharing for @acronym{VM, virtual machine} guests."))) -(define* (spice-vdagent-service - #:optional (config (spice-vdagent-configuration))) +(define-deprecated (spice-vdagent-service + #:optional (config (spice-vdagent-configuration))) "Start the @command{vdagentd} and @command{vdagent} daemons from @var{spice-vdagent} to enable guest window resizing and clipboard sharing."