mbox

[bug#45132,0/2] QC Ren'py package

Message ID 02e03c983db083b554991ee295b366adedd95bc5.camel@student.tugraz.at
Headers show

Message

Leo Prikler Dec. 9, 2020, 2:55 p.m. UTC 
Hello Guix,

perhaps a bit overdue, the 10th of October marks the anniversary of my
first contribution to Guix.  A bit later and with a broken git setup,
I've added a package for Ren'py, which was finally upstreamed towards
the end of October.

Today, I am again revisiting that package, as back then there were
several steps skipped in packaging, that should not have been skipped. 
The following patch set drops generated sources from both Ren'py and
its fork of pygame, and also has Ren'py use the already existing
fribidi package.

Regards,
Leo

Comments

Nicolas Goaziou Dec. 10, 2020, 11:09 a.m. UTC | #1 
Hello,

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> perhaps a bit overdue, the 10th of October marks the anniversary of my
> first contribution to Guix.  A bit later and with a broken git setup,
> I've added a package for Ren'py, which was finally upstreamed towards
> the end of October.

Time flies!

> Today, I am again revisiting that package, as back then there were
> several steps skipped in packaging, that should not have been skipped. 
> The following patch set drops generated sources from both Ren'py and
> its fork of pygame, and also has Ren'py use the already existing
> fribidi package.

It looks good. I suggest adding #t at the end of the snippet as long as
next core-updates merge has not happened.

Could you also mention the origin of the patch (unless it is yours, of
course, in which case you can mention your name)?

Otherwise, LGTM.

Regards,