Message ID | -nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com |
---|---|
State | Accepted |
Headers | show |
Series | [bug#41181] adds emacs-interleave | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | fail | View Laminar job |
Hello, rdes <rdes@protonmail.com> writes: > Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New > variable. Thank you for the updated patch. Some comments follow. > +(define-public emacs-interleave > + (package > + (name "emacs-interleave") > + (version "1.4.0") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/rudolfochrist/interleave") > + (commit (string-append "interleave-" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb")))) Could you move the hash on the line above? > + (build-system emacs-build-system) > + (home-page > + "https://github.com/rudolfochrist/interleave") Could you move the URI on the line above, too? > + (synopsis > + "A minor mode that presents a document buffer next to an orgmode buffer") A synopsis does not start with "A". You may want to use "guix lint" to spot this. You might use the summary from the home page: (synopsis "Emacs minor mode to interleave notes and text books") > + (description > + "Interleave is a minor mode that presents a document viewer side > +by side to an orgmode buffer with your notes relevant to the current > page.") "orgmode buffer" -> "an Org buffer" Could you send an updated patch and merge this with the copyright line you sent? Regards,
From 28d87ed5f3d7372a759475b28bc9993560953d2d Mon Sep 17 00:00:00 2001 From: Ryan Desfosses <ryan@desfo.org> Date: Fri, 15 May 2020 16:53:02 -0400 Subject: [PATCH] * gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 45ccced99e..b70b9fffb8 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -6052,6 +6052,31 @@ the Hydra very seamless; it's like a minor mode that disables itself automatically.") (license license:gpl3+))) +(define-public emacs-interleave + (package + (name "emacs-interleave") + (version "1.4.0") + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/rudolfochrist/interleave") + (commit (string-append "interleave-" version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0l5b681mrpk12lx5c16m7kc13p29z6zismwg1llsjg7cdmrmsrcb")))) + (build-system emacs-build-system) + (home-page + "https://github.com/rudolfochrist/interleave") + (synopsis + "A minor mode that presents a document buffer next to an orgmode buffer") + (description + "Interleave is a minor mode that presents a document viewer side +by side to an orgmode buffer with your notes relevant to the current page.") + (license license:gpl3+))) + (define-public emacs-ivy (package (name "emacs-ivy") -- 2.26.2