diff mbox series

[bug#41863] services: Fix gdm-autologin pam service.

Message ID -CkK6xCmE4SCUTOS1nupxqCONmgZkMEUjRUNRiBXxpuT9bRhVj74k6fTGlkQg4xu8r6BAWNhSpod7a0vH4ufBiNT1GR_fxHbc0U5Vqr-xMw=@ajgrf.com
State Accepted
Headers show
Series [bug#41863] services: Fix gdm-autologin pam service. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

guix--- via Guix-patches via June 14, 2020, 11:24 p.m. UTC 
This patch fixes GDM's auto-login feature.

See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)

--
Alex Griffin

Comments

Marius Bakke Oct. 2, 2020, 5:54 p.m. UTC | #1 
Alex Griffin via Guix-patches via <guix-patches@gnu.org> writes:

> This patch fixes GDM's auto-login feature.
>
> See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)

[...]

> @@ -925,7 +926,7 @@ the GNOME desktop environment.")
>      (inherit (unix-pam-service "gdm-autologin"
>                                 #:login-uid? #t))
>      (auth (list (pam-entry
> -                 (control "[success=ok default=1]")
> +                 (control "optional")

This is one of the alternatives Timothy proposed in #35674 back in May
last year(!).  As long as GDM still rejects wrong or blank passwords, I
think it is good to go.

It would be good to get it in 1.2.0.  :-)
guix--- via Guix-patches via Oct. 7, 2020, 7:12 p.m. UTC | #2 
Fixed in commit d8258177fe.

--
Alex Griffin

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, October 7th, 2020 at 7:11 PM, Alex Griffin <a@ajgrf.com> wrote:

> Fixed in commit d8258177fe.
>
> --
> Alex Griffin
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Friday, October 2nd, 2020 at 5:54 PM, Marius Bakke marius@gnu.org wrote:
>
> > Alex Griffin via Guix-patches via writes:
> >
> > > This patch fixes GDM's auto-login feature.
> >
> > > See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
> >
> > [...]
> >
> > > @@ -925,7 +926,7 @@ the GNOME desktop environment.")
> >
> > > (inherit (unix-pam-service "gdm-autologin"
> >
> > > #:login-uid? #t))
> >
> > > (auth (list (pam-entry
> >
> > > -   (control "[success=ok default=1]")
> >
> > > -   (control "optional")
> >
> > This is one of the alternatives Timothy proposed in #35674 back in May
> >
> > last year(!). As long as GDM still rejects wrong or blank passwords, I
> >
> > think it is good to go.
> >
> > It would be good to get it in 1.2.0. :-)
guix--- via Guix-patches via Oct. 7, 2020, 7:13 p.m. UTC | #3 
Fixed in commit d8258177fe.

--
Alex Griffin

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Wednesday, October 7th, 2020 at 7:12 PM, Alex Griffin <a@ajgrf.com> wrote:

> Fixed in commit d8258177fe.
>
> --
> Alex Griffin
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>
> On Wednesday, October 7th, 2020 at 7:11 PM, Alex Griffin a@ajgrf.com wrote:
>
> > Fixed in commit d8258177fe.
> >
> > --
> >
> > Alex Griffin
> >
> > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >
> > On Friday, October 2nd, 2020 at 5:54 PM, Marius Bakke marius@gnu.org wrote:
> >
> > > Alex Griffin via Guix-patches via writes:
> > >
> > > > This patch fixes GDM's auto-login feature.
> > >
> > > > See the discussions in #35674 and #40411. It works for me, but I don't want to just commit it because I don't really understand PAM. (Then again, who does?)
> > >
> > > [...]
> > >
> > > > @@ -925,7 +926,7 @@ the GNOME desktop environment.")
> > >
> > > > (inherit (unix-pam-service "gdm-autologin"
> > >
> > > > #:login-uid? #t))
> > >
> > > > (auth (list (pam-entry
> > >
> > > > -   (control "[success=ok default=1]")
> > >
> > > > -   (control "optional")
> > >
> > > This is one of the alternatives Timothy proposed in #35674 back in May
> > >
> > > last year(!). As long as GDM still rejects wrong or blank passwords, I
> > >
> > > think it is good to go.
> > >
> > > It would be good to get it in 1.2.0. :-)
diff mbox series

Patch

From 2d07fab70a4051189e013a20a95cfbb08c904803 Mon Sep 17 00:00:00 2001
From: Alex Griffin <a@ajgrf.com>
Date: Sun, 14 Jun 2020 17:58:47 -0500
Subject: [PATCH] services: Fix gdm-autologin pam service.

* gnu/services/xorg.scm (gdm-pam-service): Mark pam_gdm.so optional.
---
 gnu/services/xorg.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index ca39994516..4590709187 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -7,6 +7,7 @@ 
 ;;; Copyright © 2019 Tim Gesthuizen <tim.gesthuizen@yahoo.de>
 ;;; Copyright © 2020 shtwzrd <shtwzrd@protonmail.com>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
+;;; Copyright © 2020 Alex Griffin <a@ajgrf.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -925,7 +926,7 @@  the GNOME desktop environment.")
     (inherit (unix-pam-service "gdm-autologin"
                                #:login-uid? #t))
     (auth (list (pam-entry
-                 (control "[success=ok default=1]")
+                 (control "optional")
                  (module (file-append (gdm-configuration-gdm config)
                                       "/lib/security/pam_gdm.so")))
                 (pam-entry
-- 
2.26.2