mbox series

[bug#54561,0/4] Add service declarations for Samba

Message ID yguwngi8ljt.fsf@netpanic.org
Headers show
Series Add service declarations for Samba | expand

Message

Simon Streit March 25, 2022, 8:48 a.m. UTC 
Hello!

Please find attached several patches to add Samba and wsdd as service
declaration for Guix.  My Samba service declaration has been cut down in length
since I am preparing a serialiser, which has not been finalised yet.

But I'd rather still have these patch posted here to see it pushed eventually.
Or others can test it to see if there are any other improvements that should
be done and in case I've missed something.  Though the service definition is
rather simple for now.


Kind regards
Simon Streit (4):
  services: Add samba service.
  doc: Add "Samba" chapter.
  doc: Add documentation for WSDD service.
  services: Add wsdd service.

 doc/guix.texi          | 119 ++++++++++++++++++
 gnu/services/samba.scm | 280 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 399 insertions(+)
 create mode 100644 gnu/services/samba.scm

--
2.34.0

Comments

Simon Streit Aug. 8, 2022, 2:56 p.m. UTC | #1 
From: Simon Streit <simon@netpanic.org>

Hello, here my third iteration preparing this patch series.

Now there are tests included too.  There is a slight modification in samba's
package declaration to include avahi as a dependency.  Samba uses avahi to
advertise instances to other hosts that understand mDNS through avahi.

Simon Streit (4):
  gnu: samba: Add avahi to inputs.
  services: Add samba service.
  gnu: Add wsdd.
  services: Add wsdd service.

 doc/guix.texi          | 122 ++++++++++++++++++
 gnu/local.mk           |   2 +
 gnu/packages/samba.scm |  31 +++++
 gnu/services/samba.scm | 285 +++++++++++++++++++++++++++++++++++++++++
 gnu/tests/samba.scm    | 217 +++++++++++++++++++++++++++++++
 po/guix/POTFILES.in    |   1 +
 6 files changed, 658 insertions(+)
 create mode 100644 gnu/services/samba.scm
 create mode 100644 gnu/tests/samba.scm

--
2.37.1
Lars-Dominik Braun Sept. 24, 2022, 7:48 a.m. UTC | #2 
Hi Simon,

> Hello, here my third iteration preparing this patch series.
thanks for the update. I’ve been running it on my NAS for a few days
and it works quite well. I addressed Ludo’s remaining comments,
adjusted your commit messages and pushed your contribution as commit
4cbc1622961f62f8fc3613de0c8f215e0cde6494 and following.

Thank you very much,
Lars
Lars-Dominik Braun Sept. 25, 2022, 8:22 a.m. UTC | #3 
Hi,

> > Hello, here my third iteration preparing this patch series.
> thanks for the update. I’ve been running it on my NAS for a few days
> and it works quite well. I addressed Ludo’s remaining comments,
> adjusted your commit messages and pushed your contribution as commit
> 4cbc1622961f62f8fc3613de0c8f215e0cde6494 and following.
I had to revert the commit adding avahi to samba in commit
dc7191302e6d099a26673e08b78eb5f4b2a2b17b and added it to core-updates
as commit 4d0befe66ae7fa731b566090b471107bc4828018 instead, because it
caused too many rebuilds.

Lars