Message ID | y761qqadpgr.wl-hako@ultrarare.space |
---|---|
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 978CE27BBEA; Fri, 11 Nov 2022 05:35:29 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8CD9A27BBE9 for <patchwork@mira.cbaines.net>; Fri, 11 Nov 2022 05:35:28 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1otMgz-0006Wy-Ag; Fri, 11 Nov 2022 00:35:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otMgx-0006WW-7y for guix-patches@gnu.org; Fri, 11 Nov 2022 00:35:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otMgw-0001kA-Rk for guix-patches@gnu.org; Fri, 11 Nov 2022 00:35:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1otMgw-0003f9-Nf for guix-patches@gnu.org; Fri, 11 Nov 2022 00:35:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59188] [PATCH 0/4] gnu: node-lts: Update to 18.12.1. Resent-From: Hilton Chain <hako@ultrarare.space> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 11 Nov 2022 05:35:02 +0000 Resent-Message-ID: <handler.59188.B.166814488314047@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59188@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166814488314047 (code B ref -1); Fri, 11 Nov 2022 05:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Nov 2022 05:34:43 +0000 Received: from localhost ([127.0.0.1]:44851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1otMgc-0003eV-Vg for submit@debbugs.gnu.org; Fri, 11 Nov 2022 00:34:43 -0500 Received: from lists.gnu.org ([209.51.188.17]:37832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hako@ultrarare.space>) id 1otMga-0003eN-7L for submit@debbugs.gnu.org; Fri, 11 Nov 2022 00:34:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <hako@ultrarare.space>) id 1otMgZ-0006U0-VW for guix-patches@gnu.org; Fri, 11 Nov 2022 00:34:40 -0500 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <hako@ultrarare.space>) id 1otMgY-0001hD-Ej for guix-patches@gnu.org; Fri, 11 Nov 2022 00:34:39 -0500 Date: Fri, 11 Nov 2022 13:34:12 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1668144874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Lo01j2u+IfjcsyizUs9JsGfRAShhWCJEYg1o3en+HyM=; b=x90udLzPQSWQed8pi9O23TR5pizUGVPXDAS5pMgmBaTfe/wfY6hUEzxEBXl7vmeNag/a1l wjBTEVXi0tPcvrkjDv7Ah/zxLpM7JcNkKUmsnFuE5UUDk+0+Flw4sQwdLWYNpmQr+lMgzE MRV/5aUnn90V5kJNCLVXMf3xUdz1Ooa5WKVEZww3+wPfjBHf0cJlGTo5LbBjgudH90umGm fBNVw9KsG76OduJiUaZt0QfuBEU8xHngwHcxtarTrxNisO6GxSe6QZcEw+mxmbJsxXMriT 0eAW71PJuxHtqM6EPcnllBtBmovd9eB4DhFxBK3+OtXKZ9+kX6eIyDZBTsv8Lw== Message-ID: <y761qqadpgr.wl-hako@ultrarare.space> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-Spamd-Bar: / Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Hilton Chain <hako@ultrarare.space> X-ACL-Warn: , Hilton Chain via Guix-patches <guix-patches@gnu.org> From: Hilton Chain via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
gnu: node-lts: Update to 18.12.1.
|
|
Message
Hilton Chain
Nov. 11, 2022, 5:34 a.m. UTC
Hilton Chain (4): gnu: libuv-for-node: Update to 1.43.0. gnu: llhttp-bootstrap: Update to 6.0.10. gnu: node-lts: Update to 18.12.1. gnu: libnode: Use node-lts as base. gnu/local.mk | 1 - gnu/packages/libevent.scm | 4 +- gnu/packages/node.scm | 44 +++++--- .../llhttp-bootstrap-CVE-2020-8287.patch | 100 ------------------ 4 files changed, 30 insertions(+), 119 deletions(-) delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch base-commit: 70df5c47a89f4f353a1df94467581a0f0da599a4 -- 2.38.1
Comments
v1 -> v2: Fix libnode path for r-v8. Hilton Chain (4): gnu: libuv-for-node: Update to 1.43.0. gnu: llhttp-bootstrap: Update to 6.0.10. gnu: node-lts: Update to 18.12.1. gnu: libnode: Use node-lts as base. gnu/local.mk | 1 - gnu/packages/cran.scm | 2 +- gnu/packages/libevent.scm | 4 +- gnu/packages/node.scm | 44 +++++--- .../llhttp-bootstrap-CVE-2020-8287.patch | 100 ------------------ 5 files changed, 31 insertions(+), 120 deletions(-) delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch base-commit: 70df5c47a89f4f353a1df94467581a0f0da599a4 -- 2.38.1
Hi, Did you make progress with this patch? Is there a way I can help you? Best wishes, Arne
From: Jelle Licht <jlicht@fsfe.org>
Folks,
This should at least build for x86_64, and I'm sending in a 'new' patch series
in the hopes of QA picking things up this time.
Hilton, I've taken the liberty of adding in a copyright line for your node-lts
update: I've also tweaked some versions so there would be less manual patching
and backports to do, namely:
* libuv-for-node to 1.44.2
* node-lts to 18.14.0
I needed to tweak some of our existing packages so they actually explicitly
state which dependencies they do not care about; with the npm bundled with
node < 16, things "Just Worked", but since then npm has become a bit stricter.
After applying my patches they should build with either node@14 (current
packaged version) or node@18 (Hilton's version).
Hilton Chain (4):
gnu: libuv-for-node: Update to 1.44.2.
gnu: llhttp-bootstrap: Update to 6.0.10.
gnu: node-lts: Update to 18.14.0.
gnu: libnode: Use node-lts as base.
Jelle Licht (12):
gnu: node-acorn: Disable tests.
gnu: node-acorn: Remove lifecycle script.
gnu: node-acorn: Fix broken transpilation.
gnu: node-buffer-crc32: Ignore development dependencies.
gnu: node-crx3: Ignore development dependencies.
gnu: node-minimist: Ignore development dependencies.
gnu: node-pbf: Ignore development dependencies.
gnu: node-protocol-buffers-schema: Ignore development dependencies.
gnu: node-resolve-protobuf-schema: Ignore development dependencies.
gnu: node-ieee754: Ignore development dependencies.
gnu: node-yazl: Ignore development dependencies.
gnu: node-uglify-js: Update to 3.14.2.
gnu/local.mk | 1 -
gnu/packages/cran.scm | 2 +-
gnu/packages/libevent.scm | 4 +-
gnu/packages/node-xyz.scm | 110 +++++++++++++-----
gnu/packages/node.scm | 49 +++++---
.../llhttp-bootstrap-CVE-2020-8287.patch | 100 ----------------
gnu/packages/uglifyjs.scm | 4 +-
7 files changed, 121 insertions(+), 149 deletions(-)
delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch
base-commit: 07e74b63d4969de0b51c48edb586f0d7d8c08db7
From: Jelle Licht <jlicht@fsfe.org>
To prevent bitrot, I rebased and built it all locally.
Changes in v4:
- node-lts to 18.14.2
Hilton Chain (4):
gnu: libuv-for-node: Update to 1.44.2.
gnu: llhttp-bootstrap: Update to 6.0.10.
gnu: node-lts: Update to 18.14.2.
gnu: libnode: Use node-lts as base.
Jelle Licht (12):
gnu: node-acorn: Disable tests.
gnu: node-acorn: Remove lifecycle script.
gnu: node-acorn: Fix broken transpilation.
gnu: node-buffer-crc32: Ignore development dependencies.
gnu: node-crx3: Ignore development dependencies.
gnu: node-minimist: Ignore development dependencies.
gnu: node-pbf: Ignore development dependencies.
gnu: node-protocol-buffers-schema: Ignore development dependencies.
gnu: node-resolve-protobuf-schema: Ignore development dependencies.
gnu: node-ieee754: Ignore development dependencies.
gnu: node-yazl: Ignore development dependencies.
gnu: node-uglify-js: Update to 3.14.2.
gnu/local.mk | 1 -
gnu/packages/cran.scm | 2 +-
gnu/packages/libevent.scm | 4 +-
gnu/packages/node-xyz.scm | 110 +++++++++++++-----
gnu/packages/node.scm | 49 +++++---
.../llhttp-bootstrap-CVE-2020-8287.patch | 100 ----------------
gnu/packages/uglifyjs.scm | 4 +-
7 files changed, 121 insertions(+), 149 deletions(-)
delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch
From: Jelle Licht <jlicht@fsfe.org>
Changes in v5:
- node build system needs an additional --install-links to work with newer npm.
- node-lts to 18.15.0
Hilton Chain (4):
gnu: libuv-for-node: Update to 1.44.2.
gnu: llhttp-bootstrap: Update to 6.0.10.
gnu: node-lts: Update to 18.15.0.
gnu: libnode: Use node-lts as base.
Jelle Licht (13):
build-system: node: Use `--install-links' with `npm install'.
gnu: node-acorn: Disable tests.
gnu: node-acorn: Remove lifecycle script.
gnu: node-acorn: Fix broken transpilation.
gnu: node-buffer-crc32: Ignore development dependencies.
gnu: node-crx3: Ignore development dependencies.
gnu: node-minimist: Ignore development dependencies.
gnu: node-pbf: Ignore development dependencies.
gnu: node-protocol-buffers-schema: Ignore development dependencies.
gnu: node-resolve-protobuf-schema: Ignore development dependencies.
gnu: node-ieee754: Ignore development dependencies.
gnu: node-yazl: Ignore development dependencies.
gnu: node-uglify-js: Update to 3.14.2.
gnu/local.mk | 1 -
gnu/packages/cran.scm | 2 +-
gnu/packages/libevent.scm | 4 +-
gnu/packages/node-xyz.scm | 110 +++++++++++++-----
gnu/packages/node.scm | 49 +++++---
.../llhttp-bootstrap-CVE-2020-8287.patch | 100 ----------------
gnu/packages/uglifyjs.scm | 4 +-
guix/build/node-build-system.scm | 3 +-
8 files changed, 123 insertions(+), 150 deletions(-)
delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch
From: Jelle Licht <jlicht@fsfe.org>
Changes in v6:
- Fix build of node-openzwave-shared
- Fix build of node-serialport
- Rebase on master
Hilton Chain (4):
gnu: libuv-for-node: Update to 1.44.2.
gnu: llhttp-bootstrap: Update to 6.0.10.
gnu: node-lts: Update to 18.15.0.
gnu: libnode: Use node-lts as base.
Jelle Licht (15):
build-system: node: Use `--install-links' with `npm install'.
gnu: node-acorn: Disable tests.
gnu: node-acorn: Remove lifecycle script.
gnu: node-acorn: Fix broken transpilation.
gnu: node-buffer-crc32: Ignore development dependencies.
gnu: node-crx3: Ignore development dependencies.
gnu: node-minimist: Ignore development dependencies.
gnu: node-pbf: Ignore development dependencies.
gnu: node-protocol-buffers-schema: Ignore development dependencies.
gnu: node-resolve-protobuf-schema: Ignore development dependencies.
gnu: node-ieee754: Ignore development dependencies.
gnu: node-yazl: Ignore development dependencies.
gnu: node-uglify-js: Update to 3.14.2.
gnu: node-serialport: Avoid gyp rebuilds.
gnu: node-openzwave-shared: Fix compilation for new versions of node
gnu/local.mk | 1 -
gnu/packages/cran.scm | 2 +-
gnu/packages/libevent.scm | 4 +-
gnu/packages/node-xyz.scm | 112 ++++++++++++++----
gnu/packages/node.scm | 49 +++++---
.../llhttp-bootstrap-CVE-2020-8287.patch | 100 ----------------
gnu/packages/uglifyjs.scm | 4 +-
gnu/packages/zwave.scm | 5 +
guix/build/node-build-system.scm | 3 +-
9 files changed, 130 insertions(+), 150 deletions(-)
delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch
From: Jelle Licht <jlicht@fsfe.org>
Node-based things are broken on armhf, but that has been the case for a good
while already. If nobody objects, I'm planning to push this to master after a
'green light' (modulo armhf results) from the QA service, somewhere in the
coming days.
Changes in v7:
- Build emacs-nodejs-repl with node-lts
- Rebase on master
- Update node-lts to 18.16.0
Hilton Chain (4):
gnu: libuv-for-node: Update to 1.44.2.
gnu: llhttp-bootstrap: Update to 6.0.10.
gnu: node-lts: Update to 18.16.0.
gnu: libnode: Use node-lts as base.
Jelle Licht (16):
build-system: node: Use `--install-links' with `npm install'.
gnu: node-acorn: Disable tests.
gnu: node-acorn: Remove lifecycle script.
gnu: node-acorn: Fix broken transpilation.
gnu: node-buffer-crc32: Ignore development dependencies.
gnu: node-crx3: Ignore development dependencies.
gnu: node-minimist: Ignore development dependencies.
gnu: node-pbf: Ignore development dependencies.
gnu: node-protocol-buffers-schema: Ignore development dependencies.
gnu: node-resolve-protobuf-schema: Ignore development dependencies.
gnu: node-ieee754: Ignore development dependencies.
gnu: node-yazl: Ignore development dependencies.
gnu: node-uglify-js: Update to 3.14.2.
gnu: node-serialport: Avoid gyp rebuilds.
gnu: node-openzwave-shared: Fix compilation for new versions of node
gnu: emacs-nodejs-repl: Build with node-lts.
gnu/local.mk | 1 -
gnu/packages/cran.scm | 2 +-
gnu/packages/emacs-xyz.scm | 2 +-
gnu/packages/libevent.scm | 4 +-
gnu/packages/node-xyz.scm | 112 ++++++++++++++----
gnu/packages/node.scm | 49 +++++---
.../llhttp-bootstrap-CVE-2020-8287.patch | 100 ----------------
gnu/packages/uglifyjs.scm | 4 +-
gnu/packages/zwave.scm | 5 +
guix/build/node-build-system.scm | 3 +-
10 files changed, 131 insertions(+), 151 deletions(-)
delete mode 100644 gnu/packages/patches/llhttp-bootstrap-CVE-2020-8287.patch
Pushed to master, with some minor adjustments to make things work after the core-updates merge. Thanks for the patience and feedback! - Jelle