From patchwork Thu Nov 21 12:40:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gabriel Wicki X-Patchwork-Id: 3017 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AABF327BBE9; Thu, 21 Nov 2024 12:41:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id CB47927BBE2 for ; Thu, 21 Nov 2024 12:41:26 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tE6Uc-0003h0-QA; Thu, 21 Nov 2024 07:41:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tE6UZ-0003gU-LL for guix-patches@gnu.org; Thu, 21 Nov 2024 07:41:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tE6UZ-0005ZF-C2 for guix-patches@gnu.org; Thu, 21 Nov 2024 07:41:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:From:Date:To:Subject; bh=ZlKpNxyVHgoD8V0XzgLxXieNry2CiWnnGd6urKJj+eg=; b=YV9YHpyESsw83yl9Wo4B4Zn7xw6aDwyGMoUBc9f4NAKn6lDAwO9IkyU9nBzPLzZ9ZVS6GIaqowmSvxsLU+2eUYs1lm/nvVBr/xnvbxMqOZm5dfoypFfrpemVOIv/j2DyyCjyWZiP3brftXnowq0SHy4FXrTo6CBpWJ0EBekIIE0ZfjWvnjsue2w9TVLY/AwLp1WaZPwqkRBN6k5ZoXHjb09ED1FgmJtXygJFy/iU5wEHfmzWvL7YjISXKpvW2/+yYoX0FjfPBfEPqWtqygKdAH0evV/zmHprpPpLc7icl072d0gNxdjOgMiHy/Lftw6CYPiKnVNuEtT8Yv+4SKXi1Q==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tE6UY-0000Ls-5q for guix-patches@gnu.org; Thu, 21 Nov 2024 07:41:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74459] [PATCH 0/8] Linter improvements (eliminate false positives)=?utf-8?q?=1B?= Resent-From: Gabriel Wicki Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 21 Nov 2024 12:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74459 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74459@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.17321928551330 (code B ref -1); Thu, 21 Nov 2024 12:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 21 Nov 2024 12:40:55 +0000 Received: from localhost ([127.0.0.1]:49417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tE6UR-0000LD-9X for submit@debbugs.gnu.org; Thu, 21 Nov 2024 07:40:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:33970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tE6UO-0000L3-PE for submit@debbugs.gnu.org; Thu, 21 Nov 2024 07:40:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tE6UO-0003dr-IA for guix-patches@gnu.org; Thu, 21 Nov 2024 07:40:52 -0500 Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tE6UJ-0005Xj-Q3 for guix-patches@gnu.org; Thu, 21 Nov 2024 07:40:52 -0500 Received: from localhost (antispam.ee.ethz.ch [129.132.2.16]) by cotopaxi.ee.ethz.ch (Postfix) with ESMTP id A358520026 for ; Thu, 21 Nov 2024 13:40:44 +0100 (CET) X-Virus-Scanned: by amavisd at antispam.ee.ethz.ch Received: from cotopaxi.ee.ethz.ch ([129.132.148.196]) by localhost (antispam.ee.ethz.ch [129.132.2.16]) (amavisd-new, port 10028) with ESMTP id S1l3TIQN0v7o for ; Thu, 21 Nov 2024 13:40:43 +0100 (CET) Received: from blackbox (212-51-128-25.fiber7.init7.net [212.51.128.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gabriel) by cotopaxi.ee.ethz.ch (Postfix) with ESMTPSA for ; Thu, 21 Nov 2024 13:40:43 +0100 (CET) Date: Thu, 21 Nov 2024 13:40:40 +0100 From: Gabriel Wicki Message-ID: MIME-Version: 1.0 Content-Disposition: inline Received-SPF: permerror client-ip=129.132.148.196; envelope-from=gabriel@erlikon.ch; helo=cotopaxi.ee.ethz.ch X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi there! In my recent venture where i linted each and every packages' description and synopsis, I found quite a bunch of false positives. These usually don't hurt when we lint single packages, but are quite annoying when linting all of them. Hence I summed my findings up in some code improvements. Have a nice week! gabber Gabriel Wicki (8): guix: lint: Fix indentation. guix: lint: Refine description start check logic. guix: lint: Allow texinfo markup at beginning of description. guix: lint: Allow texinfo markup at beginning of synopsis. guix: lint: Prevent false positives in description typo check. guix: lint: Ignore initials from double space check. guix: lint: More abbreviations. gnu: Move depending packages next to each other. gnu/packages/cpp.scm | 50 +++++++++++++++++------------------ guix/lint.scm | 56 +++++++++++++++++++++++++-------------- tests/lint.scm | 62 +++++++++++++++++++++++++++++++++++++------- 3 files changed, 114 insertions(+), 54 deletions(-) base-commit: 33665c52c4670bc3b4d337c89ac9cc6c4c69b26f