From patchwork Thu May 8 17:47:40 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Abramov X-Patchwork-Id: 2996 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E212C27BC49; Thu, 8 May 2025 18:51:40 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 624E827BC4C for ; Thu, 8 May 2025 18:51:38 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uD5P3-0005Sm-QC; Thu, 08 May 2025 13:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uD5Ol-0005ET-Fj for guix-patches@gnu.org; Thu, 08 May 2025 13:51:16 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uD5Oi-0001uv-Hh; Thu, 08 May 2025 13:51:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=zx3xs4f26ClyskIYO8KiP7bJYSGzJDm5/+F9d7WBpQk=; b=NrmGB7O1O5D092v2yuA5Z6Q5Az3roTUa2oBqXZ0znvifG6hIbfca+swLcB/wp7PFePqDwfyTZWxKWmCRPOEKu8ZSH+QY2J68p4Q8td0eMktO4dPbaltr7hgPsyn6ZIv1Jj+8E1oN8kMus6QYXDIhqoJp5ZRRcVdu4cqzxaSOg7tFXaO3yPn7DWAl7/SrJHLDKMA1UlyeNzhXHYRTTC54sA0fc52Ohn97qjO3Zj33fncm2/1juv04YLyLvmRpYoULXuIPFTgVZEl7Reoxj0qqHrrOtLsQ1kD1ywwsDfd+/2PmPQ7k5jCUtYcww4QRKtVkMAyLMRKaD1FpzGoDqUg4ww==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1uD5Og-0007g5-A9; Thu, 08 May 2025 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77204] [PATCH v4 0/3] dnsmasq service changes References: In-Reply-To: Resent-From: Alexey Abramov Original-Sender: "Debbugs-submit" Resent-CC: gabriel@erlikon.ch, ludo@gnu.org, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Thu, 08 May 2025 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77204@debbugs.gnu.org Cc: Gabriel Wicki , Ludovic =?utf-8?q?Court=C3=A8s?= , Maxim Cournoyer X-Debbugs-Original-Xcc: Gabriel Wicki , Ludovic =?utf-8?q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 77204-submit@debbugs.gnu.org id=B77204.174672663329406 (code B ref 77204); Thu, 08 May 2025 17:51:02 +0000 Received: (at 77204) by debbugs.gnu.org; 8 May 2025 17:50:33 +0000 Received: from localhost ([127.0.0.1]:59713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uD5OD-0007eD-9w for submit@debbugs.gnu.org; Thu, 08 May 2025 13:50:33 -0400 Received: from mail.mmer.org ([178.22.65.174]:51192) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uD5OA-0007dp-Ui for 77204@debbugs.gnu.org; Thu, 08 May 2025 13:50:31 -0400 Received: from mail.mmer.org (localhost [127.0.0.1]) by mail.mmer.org (OpenSMTPD) with ESMTP id 83efe286 for <77204@debbugs.gnu.org>; Thu, 8 May 2025 17:50:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=mmer.org; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=/bR/1xdqUnOecdlNp32VKD9yk0Ov6sQGQQ1+B8wdQDQ=; b=jxY/ WTbIGiF/3tKl8EukDyg+P/5TyslrcnqeNzXIVQVUP2mjP6cLvDmXHm59REV2FtEA oqaTbWwvR9PTF6Fd357OWjUBdztTdvtNJ3X5YV/Sm4BnLAiKau03KkOUeswmkEuT GTYH8n0xsTEjOIYpET2LQiSXJ7FZSOdsHvw4rZs= Received: from delta (208-91-20-31.ftth.glasoperator.nl [31.20.91.208]) by mail.mmer.org (OpenSMTPD) with ESMTPSA id 3f16029e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <77204@debbugs.gnu.org>; Thu, 8 May 2025 17:50:22 +0000 (UTC) Date: Thu, 8 May 2025 19:47:40 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Alexey Abramov X-ACL-Warn: , Alexey Abramov via Guix-patches X-Patchwork-Original-From: Alexey Abramov via Guix-patches via From: Alexey Abramov Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Thank you, Maxim, for your thorough review. With v4 I did address all your suggestions (I hope I didn't miss anything ;)). I had an impression that `M-q' would do a proper formating of sentences, but apparently `sentence-end-double-space' is a hint to just break lines. Am i missing something? Regarding the commit messages, I kinda used to go to diff in magit and press `C' on a hunk and it does add things to the commit message. I did check git log and see people use different ways like (), [] and <>. Seems like a more personal stuff, but I would like to know more... With these v4 series: - I moved documentation of actions to the manual and not in the action procedures themselves. herd doc prints texi markups as is. - I removed indentation of fields. Alexey Abramov (3): services: dnsmasq: Add shepherd-provision and shepherd-requirement fields. services: dnsmasq: Add pid-file, conf-file and conf-dir configuration fields. services: dnsmasq: Add stats and reload shepherd actions. doc/guix-cookbook.texi | 4 +- doc/guix.texi | 78 +++++++++++++++++++++++++++-- gnu/services/dns.scm | 104 +++++++++++++++++++++++++++++++++++---- gnu/tests/networking.scm | 98 ++++++++++++++++++++++++++++++++++++ 4 files changed, 269 insertions(+), 15 deletions(-) base-commit: ac2d792aae241f5233ee3fdfa29cd3dbaeb9338c