From patchwork Thu Apr 17 20:19:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 2933 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 9273727BC4B; Thu, 17 Apr 2025 21:21:48 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5B71027BC49 for ; Thu, 17 Apr 2025 21:21:48 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u5VjS-0006DQ-7p; Thu, 17 Apr 2025 16:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5VjQ-0006D1-2X for guix-patches@gnu.org; Thu, 17 Apr 2025 16:21:08 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u5VjP-0000nn-69; Thu, 17 Apr 2025 16:21:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=dG+m/YzPYlKGgbqTnFfMXWVM4r0gWRNR3YXE+eeh/Z0=; b=K53bhwYq3u0IQpHmH0wh0oyUVOJhpfeoN7PrY3+e8EOQHn+7BEC7fjNqOI9ywMs44TdQ4ovAbl4feX/slALdrcw+FiESiL+oM53rKH8/VLkb5xhkHl9+dfwNFMbmcykvzN0YXhIn2s6+XS+EpQjsi2baLGMQqXDJ1FRRxPSJeyLR8G8z9JucuMD3WXrC2rZXqd136GOhFed1fsJpycPCqKE3SYxJmygzjuycme+qP1UT1X5ooSDY9/ZOTtRLOg8yYcWFQU0lQ6dgZYPVT/rotwyKXM4oYcsgwGSoYHjigLhHqfgsMGetEr4MlhlPgfmh1VFYAcFDdVF9DhbSOBtxwA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1u5VjJ-0006Na-QR; Thu, 17 Apr 2025 16:21:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77875] [PATCH 0/2] Use 'graph-descendant?' from Guile-Git instead of custom code Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Thu, 17 Apr 2025 20:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77875 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77875@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Tomas Volf <~@wolfsden.cz>, Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.174492123724273 (code B ref -1); Thu, 17 Apr 2025 20:21:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Apr 2025 20:20:37 +0000 Received: from localhost ([127.0.0.1]:48566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u5Viv-0006JQ-0m for submit@debbugs.gnu.org; Thu, 17 Apr 2025 16:20:37 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49518) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u5Vip-0006Ha-08 for submit@debbugs.gnu.org; Thu, 17 Apr 2025 16:20:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5Vic-0005fZ-Ii for guix-patches@gnu.org; Thu, 17 Apr 2025 16:20:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u5ViZ-0000bB-67; Thu, 17 Apr 2025 16:20:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=dG+m/YzPYlKGgbqTnFfMXWVM4r0gWRNR3YXE+eeh/Z0=; b=P/Yn1/D/2K4O41 Y5YBGI/YpTS6CDJINajpBLl6zgJ+s6PQoRwSLcoB6OwuuGAQLD8ZXGNx5+IyZE7W211u8E4biOi42 PuWBoPlQcbPCnnYnrgKh3POTytoY5Slnz3EzmPFDfXXR4e2h8QM2Zm1q9mRoZ/efiVDzQmmAikuLz KIf1M3JSyThBdUCSVWbznmS/L7MzwEW51oFfSLFBEDOHfWHnKQykehi3ZZrxOZS11DaiKxQEeFdBR VOs286DXVAiSuKxyK4OEacnU/W+W6Ofh1a2DNkX/DdSTPuikuK74yLgJ/SCEoRcvqbxucVmEjRM7k DtZfjdQa6GYlIdhXeu7g==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Thu, 17 Apr 2025 22:19:58 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello, This is a bug fix and potentially a performance improvement (I didn’t attempt to benchmark it but if someone wants to do it, I’m curious!). Note that the existing code is kept around for now. We can remove it in a couple of months when Guile-Git 0.10.0 is considered widespread enough. This is a convenience for developers since in practice Guix itself will have switched to Guile-Git 0.10.0 within a few hours. Thanks, Ludo’. Ludovic Courtès (2): git: Use ‘graph-descendant?’ from Guile-Git >= 0.10.0 when available. git: Remove compatibility shim for Guile-Git <= 0.5.2. guix/git.scm | 90 ++++++++++++++++++++++++++++++---------------------- 1 file changed, 52 insertions(+), 38 deletions(-) base-commit: 4bd2949cfa7a8bf5dfe66adad1a76472af09708d