From patchwork Fri Apr 11 13:54:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 2922 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C2C2E27BC49; Fri, 11 Apr 2025 14:56:30 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7523627BC4B for ; Fri, 11 Apr 2025 14:56:30 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u3Erb-0002yr-Nc; Fri, 11 Apr 2025 09:56:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u3ErX-0002xO-HJ for guix-patches@gnu.org; Fri, 11 Apr 2025 09:56:07 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u3ErX-0003rX-6m; Fri, 11 Apr 2025 09:56:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=yTGXpjEQYAhhi8MXZa0kDUhpWZkv1rZbB11oQIUVvtk=; b=PPjrNZvAHk0C0NSZDOzBxp6y8xzDApq1RfM2VhFveZntvtZT8ztUUdWIbLAxNXxhkNARkJm3YKu2QawsETb3RuEIKZJKT1nwdIJoetAjXESH9pUsLMk9e5MzOzd9NRT+ZkjzkmoVUGHXNw+WgZWFfP/iIWOwRoZn5ajKuzuyABEsfNMJrYw/mHYeO8pb620IZOWbnk66h7KLia3VWgKLbXIaq5TruHFWzdBxDDhaphrtpduHPc6ZN7ReDZ7Omv95755j+UoyO193dJYGgOnVMDoMGtGNmQtTTvBXcgaDdjhwe0Kkcq13nKoIjIidrbAHg/ZTKm0t/QrmjhBZF1vt7w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1u3ErS-0007on-9G; Fri, 11 Apr 2025 09:56:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77680] [PATCH v2 0/4] Avoid 'fdatasync' calls for cache files References: In-Reply-To: Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Fri, 11 Apr 2025 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 77680 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77680@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 77680-submit@debbugs.gnu.org id=B77680.174437974329856 (code B ref 77680); Fri, 11 Apr 2025 13:56:02 +0000 Received: (at 77680) by debbugs.gnu.org; 11 Apr 2025 13:55:43 +0000 Received: from localhost ([127.0.0.1]:49884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3Er6-0007lD-Jz for submit@debbugs.gnu.org; Fri, 11 Apr 2025 09:55:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57566) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3Er3-0007jG-Kx for 77680@debbugs.gnu.org; Fri, 11 Apr 2025 09:55:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u3Eqx-0003nm-LE; Fri, 11 Apr 2025 09:55:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=yTGXpjEQYAhhi8MXZa0kDUhpWZkv1rZbB11oQIUVvtk=; b=jJqZd9fCjEJYkv y/E8cEttcuRv1E+h4WisuqieUK9k9jLXb5X5vCMjvzSKDw+XNtPYzuagmcY+tty88D61RRq5P1RXt t9rVEx1j5lTOlo/21HbzsfF3bZdwi399QXM8f2yfrST7xArkuub+bwkr0+CppeaIM8O7S1w1damV8 HVERoo1p/zj0479Ljkv0NPVFc6hwkqbWqn72H4z0JY4geO4SlNheJzdn8DZvHTu9oUBiC8yRuxYT4 1wAcpHtCzQZnKTqDi1NmVqxTCP2MU0oC+W6LaltZ1lSoAI08zCXD8Z1eksxiQ475v7YUf+9XAeSSO V5CuyvA5UCCTHVqlrTgg==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Fri, 11 Apr 2025 15:54:56 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Changes since v1: • Patch #3 only tolerates empty narinfo files instead of doing (false-if-exception (read p)), as suggested by Chris. Ludo'. Ludovic Courtès (4): cache: Remove unused import. utils: Add #:sync? parameter to ‘with-atomic-file-output’. substitutes: Ignore corrupt cached narinfos. guix: Avoid ‘fdatasync’ call for caches and regular files. guix/cache.scm | 1 - guix/git-authenticate.scm | 5 +++-- guix/http-client.scm | 5 +++-- guix/scripts/discover.scm | 3 ++- guix/scripts/style.scm | 5 +++-- guix/substitutes.scm | 5 ++++- guix/utils.scm | 14 ++++++++++---- 7 files changed, 25 insertions(+), 13 deletions(-) base-commit: 772b70455d0d5972fdad80d8529647dce20f409a