[bug#77680,v2,0/4] Avoid 'fdatasync' calls for cache files

Message ID cover.1744379552.git.ludo@gnu.org
Headers
Series Avoid 'fdatasync' calls for cache files |

Message

Ludovic Courtès April 11, 2025, 1:54 p.m. UTC
  Changes since v1:

  • Patch #3 only tolerates empty narinfo files instead of
    doing (false-if-exception (read p)), as suggested by Chris.

Ludo'.

Ludovic Courtès (4):
  cache: Remove unused import.
  utils: Add #:sync? parameter to ‘with-atomic-file-output’.
  substitutes: Ignore corrupt cached narinfos.
  guix: Avoid ‘fdatasync’ call for caches and regular files.

 guix/cache.scm            |  1 -
 guix/git-authenticate.scm |  5 +++--
 guix/http-client.scm      |  5 +++--
 guix/scripts/discover.scm |  3 ++-
 guix/scripts/style.scm    |  5 +++--
 guix/substitutes.scm      |  5 ++++-
 guix/utils.scm            | 14 ++++++++++----
 7 files changed, 25 insertions(+), 13 deletions(-)


base-commit: 772b70455d0d5972fdad80d8529647dce20f409a
  

Comments

Ludovic Courtès April 14, 2025, 9:08 p.m. UTC | #1
Ludovic Courtès <ludo@gnu.org> writes:

> Changes since v1:
>
>   • Patch #3 only tolerates empty narinfo files instead of
>     doing (false-if-exception (read p)), as suggested by Chris.
>
> Ludo'.
>
> Ludovic Courtès (4):
>   cache: Remove unused import.
>   utils: Add #:sync? parameter to ‘with-atomic-file-output’.
>   substitutes: Ignore corrupt cached narinfos.
>   guix: Avoid ‘fdatasync’ call for caches and regular files.

Pushed as dfac0a5a9526805334bd7f72926b77b5d46f59db, following our
discussion on #guix today.