From patchwork Wed Apr 9 14:21:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 2915 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 77A6B27BC4B; Wed, 9 Apr 2025 15:23:51 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id F008A27BC49 for ; Wed, 9 Apr 2025 15:23:50 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u2WKd-0003EP-RZ; Wed, 09 Apr 2025 10:23:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2WKb-0003EB-64 for guix-patches@gnu.org; Wed, 09 Apr 2025 10:23:09 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1u2WKa-0002jV-Qi; Wed, 09 Apr 2025 10:23:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=oirkk7njtJ8auGsVs5bco3S8SASX5ZLFC1nVurNaJq4=; b=G8NbKcufzJ77m78jX8osQr8IoHSCIB5kAq9Wt6CxVuTcb/axoLInJwwwEZRDwOrcJG87GakY6mH1NnE1z8W6M9/8ca7PUXffc6M/4z7UJvGpKZ6u3XMGNQWn43Iz0fAkL9J/70pptOLO2oPGp0IQbJr3ZnmZaonvPreP4Vrj8I516aLEEUqPHkJB8uOyBNlg6G+CmXUkWIoK+vvQRbo7rEAcytkdygAwmDowLd3B+Oc0cv+kPIPlzueRyjNicUMO41LaVeewDlPUmxEVmglRs5Ukb/ULw+hxSedQW1cEQqP4If4CAFjeNLNJIF6vU6Dj/nQShJCekXgf/QbivDwiNQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1u2WKV-0007QL-Ec; Wed, 09 Apr 2025 10:23:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77680] [PATCH 0/4] Avoid 'fdatasync' calls for cache files Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Wed, 09 Apr 2025 14:23:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77680 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77680@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Christopher Baines , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by submit@debbugs.gnu.org id=B.174420852328405 (code B ref -1); Wed, 09 Apr 2025 14:23:03 +0000 Received: (at submit) by debbugs.gnu.org; 9 Apr 2025 14:22:03 +0000 Received: from localhost ([127.0.0.1]:40893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2WJW-0007O3-KU for submit@debbugs.gnu.org; Wed, 09 Apr 2025 10:22:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46164) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2WJT-0007NU-NI for submit@debbugs.gnu.org; Wed, 09 Apr 2025 10:22:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2WJO-0002w8-8b for guix-patches@gnu.org; Wed, 09 Apr 2025 10:21:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2WJM-0002dN-Lg; Wed, 09 Apr 2025 10:21:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=oirkk7njtJ8auGsVs5bco3S8SASX5ZLFC1nVurNaJq4=; b=naB2GWCXE/1AnL NWeN91rYToYeZNRu3y669t+xz4KdzjTdPtzdtJ7XJz5fMvkasUwtok6ivVkeKjE1F9NmDW4dMwPFv 6WNi7KsvqGr99GflYigXGiBJmEI0iUI1RIzam2eyn/FITzOke6ZB9JKtMx8iN7TlVPI/8rJRjKrB5 l+GALr5Si9w+WP5JDEbFM8mOY3vnghrBULlJ9hqvYjrm8kdkfRIU+W9Evo2Ra/UK3WmBZOnTTJoRy udcw4+rsaCytf8gH7pMeAGSXlpuhL+lOMMD303yOM5sqoVV0b9JYKKAnO+0hH32pM/bxLegRPZF0x lhSpOp3Ty24JXr1RsA3g==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Wed, 9 Apr 2025 16:21:27 +0200 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello, As Chris found out, calling ‘fdatasync’ for each and every narinfo cache file created by ‘guix substitute’ (and likewise for other caches) is too expensive and pointless. This patch series fixes that. Thoughts? Ludo’. Ludovic Courtès (4): cache: Remove unused import. utils: Add #:sync? parameter to ‘with-atomic-file-output’. substitutes: Ignore corrupt cached narinfos. guix: Avoid ‘fdatasync’ call for caches and regular files. guix/cache.scm | 1 - guix/git-authenticate.scm | 5 +++-- guix/http-client.scm | 5 +++-- guix/scripts/discover.scm | 3 ++- guix/scripts/style.scm | 5 +++-- guix/substitutes.scm | 8 +++++--- guix/utils.scm | 14 ++++++++++---- 7 files changed, 26 insertions(+), 15 deletions(-) base-commit: c88f98bb3ca2616baea6b1e452cc900cc9c87503