mbox series

[bug#77680,0/4] Avoid 'fdatasync' calls for cache files

Message ID cover.1744208418.git.ludo@gnu.org
Headers
Series Avoid 'fdatasync' calls for cache files |

Message

Ludovic Courtès April 9, 2025, 2:21 p.m. UTC 
  Hello,

As Chris found out, calling ‘fdatasync’ for each and every narinfo
cache file created by ‘guix substitute’ (and likewise for other caches)
is too expensive and pointless.  This patch series fixes that.

Thoughts?

Ludo’.

Ludovic Courtès (4):
  cache: Remove unused import.
  utils: Add #:sync? parameter to ‘with-atomic-file-output’.
  substitutes: Ignore corrupt cached narinfos.
  guix: Avoid ‘fdatasync’ call for caches and regular files.

 guix/cache.scm            |  1 -
 guix/git-authenticate.scm |  5 +++--
 guix/http-client.scm      |  5 +++--
 guix/scripts/discover.scm |  3 ++-
 guix/scripts/style.scm    |  5 +++--
 guix/substitutes.scm      |  8 +++++---
 guix/utils.scm            | 14 ++++++++++----
 7 files changed, 26 insertions(+), 15 deletions(-)


base-commit: c88f98bb3ca2616baea6b1e452cc900cc9c87503