mbox series

[bug#77186,00/13] Revamp the gitolite-service-type

Message ID cover.1742661305.git.~@wolfsden.cz
Headers
Series Revamp the gitolite-service-type |

Message

Tomas Volf March 22, 2025, 4:48 p.m. UTC 
  Extensions and improvements for the gitolite-service-type.

Tomas Volf (13):
  services: gitolite-rc-file-compiler: Switch to match-record.
  services: gitolite-rc-file: Add log-extra field.
  services: gitolite-rc-file: Add host-name field.
  services: gitolite-rc-file: Add extra-content field.
  services: gitolite-rc-file-compiler: Set mode of the generated file.
  services: gitolite-rc-file: Export default value for enable.
  services: gitolite-service-type: Do not install gitolite package.
  services: gitolite-accounts: Convert to match-record.
  services: gitolite-activation: Convert to match-record.
  services: Add gitolite-git-configuration.
  services: gitolite-git-configuration: Add default-branch field.
  services: gitolite-git-configuration: Add receive-fsck-objects field.
  services: gitolite-git-configuration: Add extra-content field.

 doc/guix.texi                    |  41 +++++
 gnu/packages/version-control.scm |   5 +-
 gnu/services/version-control.scm | 302 ++++++++++++++++++-------------
 3 files changed, 223 insertions(+), 125 deletions(-)

--
2.48.1

Comments

Maxim Cournoyer March 27, 2025, 5:55 a.m. UTC | #1 
Hi,

Tomas Volf <~@wolfsden.cz> writes:

> Extensions and improvements for the gitolite-service-type.
>
> Tomas Volf (13):
>   services: gitolite-rc-file-compiler: Switch to match-record.
>   services: gitolite-rc-file: Add log-extra field.
>   services: gitolite-rc-file: Add host-name field.
>   services: gitolite-rc-file: Add extra-content field.
>   services: gitolite-rc-file-compiler: Set mode of the generated file.
>   services: gitolite-rc-file: Export default value for enable.
>   services: gitolite-service-type: Do not install gitolite package.
>   services: gitolite-accounts: Convert to match-record.
>   services: gitolite-activation: Convert to match-record.
>   services: Add gitolite-git-configuration.
>   services: gitolite-git-configuration: Add default-branch field.
>   services: gitolite-git-configuration: Add receive-fsck-objects field.
>   services: gitolite-git-configuration: Add extra-content field.
>
>  doc/guix.texi                    |  41 +++++
>  gnu/packages/version-control.scm |   5 +-

Apart from my comment w.r.t to the log-extra default value in patch
2/13, this LGTM.  Could you clarify my question for said patch?

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>