mbox series

[bug#77041,00/16] Replacing mcron jobs by Shepherd timers

Message ID cover.1742073920.git.ludo@gnu.org
Headers
Series Replacing mcron jobs by Shepherd timers |

Message

Ludovic Courtès March 15, 2025, 9:27 p.m. UTC 
  Hello,

This is the last step of the Shepherd 1.0 transition, leading
to the deprecation of mcron, superseded by Shepherd timers.

Thoughts?

Ludo'.

Ludovic Courtès (16):
  services: shepherd: Factorize ‘trigger’ action.
  services: file-database: Turn into a Shepherd timer.
  services: file-database: Exclude /dev by default.
  services: package-database: Turn into a Shepherd timer.
  services: fstrim: Turn into a Shepherd timer.
  services: certbot: Turn into a Shepherd timer.
  services: wireguard: Turn monitoring into a Shepherd timer.
  tests: Make ‘operating-system-with-console-syslog’ public.
  tests: ganeti: Remove unnecessary ‘begin’.
  tests: ganeti: Write system log to /dev/console.
  tests: ganeti: Increase VM memory size.
  services: ganeti: Update to Shepherd 1.0 interface.
  services: ganeti: Produce Shepherd timers instead of mcron jobs.
  services: virtual-build-machine: Turn GC job into a Shepherd timer.
  services: mcron: Deprecate.
  DRAFT news: Add entry for mcron deprecation.

 doc/guix.texi                   |  60 +++++++---
 etc/news.scm                    |  13 +++
 gnu/home/services/mcron.scm     |   7 +-
 gnu/services/admin.scm          |  68 +++++++----
 gnu/services/backup.scm         |   6 +-
 gnu/services/certbot.scm        |  93 ++++++++-------
 gnu/services/ganeti.scm         | 135 ++++++++++-----------
 gnu/services/linux.scm          |  50 ++++----
 gnu/services/mcron.scm          |   7 +-
 gnu/services/shepherd.scm       |   8 ++
 gnu/services/virtualization.scm |  22 +++-
 gnu/services/vpn.scm            | 201 +++++++++++++++++---------------
 gnu/tests.scm                   |  21 ++++
 gnu/tests/ganeti.scm            | 120 +++++++++----------
 gnu/tests/install.scm           |  20 ----
 15 files changed, 462 insertions(+), 369 deletions(-)


base-commit: 0c497c87ac47206b3e8c6dfa2e1e9b5f3e452292

Comments

Maxim Cournoyer March 16, 2025, 12:12 p.m. UTC | #1 
Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> This is the last step of the Shepherd 1.0 transition, leading
> to the deprecation of mcron, superseded by Shepherd timers.
>
> Thoughts?

Like Florian, I've read the diffs only, haven't applied nor built nor
test, but it looks reasonable to me, except the hard deprecation and
removal, which is unnecessary.

With the hard deprecation turned into a soft deprecation, it'd LGTM.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>

--
Thanks,
Maxim