Message ID | cover.1742073920.git.ludo@gnu.org |
---|---|
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 32D1B27BBE9; Sat, 15 Mar 2025 21:29:34 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 37DBB27BBE2 for <patchwork@mira.cbaines.net>; Sat, 15 Mar 2025 21:29:33 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1ttZ49-0003D0-Cl; Sat, 15 Mar 2025 17:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZ46-0003Ck-33 for guix-patches@gnu.org; Sat, 15 Mar 2025 17:29:06 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZ44-0001oE-P7 for guix-patches@gnu.org; Sat, 15 Mar 2025 17:29:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=zFQrOc2UDjQtD9zi0EWAcx17eXRY02g4p7Q5kVduq7I=; b=vxSDQ5U0vq8Ka38pQtF1EA4Mam6/dDbVkbDXZIkU68836x4gGGsU0yk1k+J41PAc/eHzS8JfxcxN5Rp54TtkZcuJC4mzTWN9ZRjjeKsCbdmE8osmOCv1YUsBcp02lgFrvm98TMrUjR/Q/o90Z1ppDXZWByrOXHVOR7vL2oG70R6pf52DR3FKSxPnSJIrYzxJuyY5OyQOgJAN7JEj7vlPjroxAYBozSVlbmSRtlAOltYVFMEitqyEl3Fj9GNisj+V9t6aWCgc9lA4fwVr5glCU/afgCjgHJCu2XQZxgu2iBZoLE0eXcrRvdsiO6R0OAjKQ8i/DuPgJRVZUa9yH6F5Tw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ttZ43-0003KM-Bo; Sat, 15 Mar 2025 17:29:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#77041] [PATCH 00/16] Replacing mcron jobs by Shepherd timers Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: pelzflorian@pelzflorian.de, julien@lepiller.eu, guix-patches@gnu.org Resent-Date: Sat, 15 Mar 2025 21:29:02 +0000 Resent-Message-ID: <handler.77041.B.174207408812460@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77041 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 77041@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org>, Florian Pelz <pelzflorian@pelzflorian.de>, Julien Lepiller <julien@lepiller.eu> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Florian Pelz <pelzflorian@pelzflorian.de>, Julien Lepiller <julien@lepiller.eu> Received: via spool by submit@debbugs.gnu.org id=B.174207408812460 (code B ref -1); Sat, 15 Mar 2025 21:29:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2025 21:28:08 +0000 Received: from localhost ([127.0.0.1]:43791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1ttZ39-0003Eu-PR for submit@debbugs.gnu.org; Sat, 15 Mar 2025 17:28:08 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60648) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <ludo@gnu.org>) id 1ttZ35-0003Dy-Kd for submit@debbugs.gnu.org; Sat, 15 Mar 2025 17:28:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1ttZ2t-00032w-7q for guix-patches@gnu.org; Sat, 15 Mar 2025 17:27:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <ludo@gnu.org>) id 1ttZ2q-0001eu-S1; Sat, 15 Mar 2025 17:27:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=zFQrOc2UDjQtD9zi0EWAcx17eXRY02g4p7Q5kVduq7I=; b=P9Rm7ITrMVHamE KikJREQwKIPqI2V/FXJ9zeOZwWPKFnZCOzeVfxKGlaj7Z7/3aoLbkg7Q9Sv0knlJQVrEkTL3wQqva B/xX7hz/tvRvkdBm8YJ0zv0PZPouoxgXd2AS7imH3Ht9RmsB+bexjkrzPGWbI57AdFXlvHvG51KCV we2VEuDVHJAUZmj/LqXbmHgOC2rBo/6hrUxJkZymulzoXLOC6sHljYn7q+uRoVndQnBjftTM2v4qY ryGfbyDwRrAAGpiaJOee+SciILSxZ8APZLC98xvKtEMEzKQ6co/oIVYcPhjbYkipO+7nef7CZaYdv jurZwGLbR/243hEsjeXQ==; From: Ludovic =?utf-8?q?Court=C3=A8s?= <ludo@gnu.org> Date: Sat, 15 Mar 2025 22:27:24 +0100 Message-ID: <cover.1742073920.git.ludo@gnu.org> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
Replacing mcron jobs by Shepherd timers
|
|
Message
Ludovic Courtès
March 15, 2025, 9:27 p.m. UTC
Hello, This is the last step of the Shepherd 1.0 transition, leading to the deprecation of mcron, superseded by Shepherd timers. Thoughts? Ludo'. Ludovic Courtès (16): services: shepherd: Factorize ‘trigger’ action. services: file-database: Turn into a Shepherd timer. services: file-database: Exclude /dev by default. services: package-database: Turn into a Shepherd timer. services: fstrim: Turn into a Shepherd timer. services: certbot: Turn into a Shepherd timer. services: wireguard: Turn monitoring into a Shepherd timer. tests: Make ‘operating-system-with-console-syslog’ public. tests: ganeti: Remove unnecessary ‘begin’. tests: ganeti: Write system log to /dev/console. tests: ganeti: Increase VM memory size. services: ganeti: Update to Shepherd 1.0 interface. services: ganeti: Produce Shepherd timers instead of mcron jobs. services: virtual-build-machine: Turn GC job into a Shepherd timer. services: mcron: Deprecate. DRAFT news: Add entry for mcron deprecation. doc/guix.texi | 60 +++++++--- etc/news.scm | 13 +++ gnu/home/services/mcron.scm | 7 +- gnu/services/admin.scm | 68 +++++++---- gnu/services/backup.scm | 6 +- gnu/services/certbot.scm | 93 ++++++++------- gnu/services/ganeti.scm | 135 ++++++++++----------- gnu/services/linux.scm | 50 ++++---- gnu/services/mcron.scm | 7 +- gnu/services/shepherd.scm | 8 ++ gnu/services/virtualization.scm | 22 +++- gnu/services/vpn.scm | 201 +++++++++++++++++--------------- gnu/tests.scm | 21 ++++ gnu/tests/ganeti.scm | 120 +++++++++---------- gnu/tests/install.scm | 20 ---- 15 files changed, 462 insertions(+), 369 deletions(-) base-commit: 0c497c87ac47206b3e8c6dfa2e1e9b5f3e452292
Comments
Hi, Ludovic Courtès <ludo@gnu.org> writes: > Hello, > > This is the last step of the Shepherd 1.0 transition, leading > to the deprecation of mcron, superseded by Shepherd timers. > > Thoughts? Like Florian, I've read the diffs only, haven't applied nor built nor test, but it looks reasonable to me, except the hard deprecation and removal, which is unnecessary. With the hard deprecation turned into a soft deprecation, it'd LGTM. Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail.com> -- Thanks, Maxim