From patchwork Thu Feb 6 02:38:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 2673 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3FA5527BBEA; Thu, 6 Feb 2025 02:39:35 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 9547C27BBE2 for ; Thu, 6 Feb 2025 02:39:34 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tfrnM-0002Mq-PJ; Wed, 05 Feb 2025 21:39:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tfrnK-0002Ma-TX for guix-patches@gnu.org; Wed, 05 Feb 2025 21:39:11 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tfrnK-0008ET-FI for guix-patches@gnu.org; Wed, 05 Feb 2025 21:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:In-Reply-To:References:Subject; bh=1tpR/+QE+w8YcolRpBi+q7t1ni8/hePHFtcIeW9TCaY=; b=sTcJezIx4PGamjbUSxCrt2+yspH78+oYZuPhLLt4EsJWqzDjqBpu9S7TONtXe+je7BUlCnimcweAq2UePTtC0T03mPZAPfQ24ESayLl+v9DHiMB6P3CykieTADcOtU7JNG9ZjbXa57RMWbcV3WxNXooC92Nlg/CtE5OsMo+qQGFBAk+MrBRxN8Qon0Emyxur9GD+Wy9oAISaxYhDPryegvP858nFAcO3vu4fhSSnmk7Ke+OMN3LYgkjqHm4/MwtaEI5H4IdLgdRSxarETh/wRV242uHYBNPNR8t20rOP5BUxmp34Bn5d9KW5Rw1bVqszYUuiQq5RriYR4lFVofD1jg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tfrnC-0005vX-AJ; Wed, 05 Feb 2025 21:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#63508] [PATCH core-updates v5 0/3] eudev: Build with udevrulesdir pointing to /etc/udev/rules.d References: In-Reply-To: Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: felix.lechner@lease-up.com, liliana.prikler@gmail.com, mirai@makinata.eu, maxim.cournoyer@gmail.com, leo@famulari.name, w@wmeyer.eu, guix-patches@gnu.org Resent-Date: Thu, 06 Feb 2025 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63508 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63508@debbugs.gnu.org Cc: Maxim Cournoyer , Felix Lechner , Liliana Marie Prikler , Bruno Victal , Maxim Cournoyer , Leo Famulari , Wilko Meyer X-Debbugs-Original-Xcc: Felix Lechner , Liliana Marie Prikler , Bruno Victal , Maxim Cournoyer , Leo Famulari , Wilko Meyer Received: via spool by 63508-submit@debbugs.gnu.org id=B63508.173880953522767 (code B ref 63508); Thu, 06 Feb 2025 02:39:02 +0000 Received: (at 63508) by debbugs.gnu.org; 6 Feb 2025 02:38:55 +0000 Received: from localhost ([127.0.0.1]:53434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tfrn4-0005v7-V2 for submit@debbugs.gnu.org; Wed, 05 Feb 2025 21:38:55 -0500 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:51570) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tfrn0-0005uo-2K for 63508@debbugs.gnu.org; Wed, 05 Feb 2025 21:38:52 -0500 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-21effc750d2so7298735ad.3 for <63508@debbugs.gnu.org>; Wed, 05 Feb 2025 18:38:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738809523; x=1739414323; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1tpR/+QE+w8YcolRpBi+q7t1ni8/hePHFtcIeW9TCaY=; b=TZbNH5tRdefspw33arBkRAWyNCgjdNhRS1sOTAEebwvepWidHiMqokDzxKbqiJ79p0 w3vcIYfxYut41/Z6RDjaxTX8aVlRvCuFQ8V06Z3FrQVCvxixWXZYqgvP/Hl/5TBffB9k rYVtVRhAs2t2cFQb55lgDQECEBAp7OIKA0u33MdetxDHeRLNhcO0N+15RLxkOhfk40Wv HLmII5JBtaDSjd8Vi59gAdhlXxHhIBxRczo0bdgd+N/92lppkBl3UNqhd+IM3JyDhzWf 74knL72BswwCi+Ez4S/PsECISJVz1qK3e6mrh5+BDpaaneG4aSQ+Z3cMOdDJ4MqU+Vep Bxag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738809523; x=1739414323; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1tpR/+QE+w8YcolRpBi+q7t1ni8/hePHFtcIeW9TCaY=; b=Uuxb2heWky9wvwCzsTf3ZyB0ExE0vgB0hm8cqOoONIYDnbgEYTQy1c5LBEjhTK2xvU VJBYuOHwvlwE/OmfVnBcnnHhzAUL91NAqtOIx9FW6F0T9N7M5Ck+YFoKWCr2XFWnSlKa dxGmMdEAp0va/ilN0er5aJmUoJQ4i//CdWWbeipde+n7/wmhQPivCUTgfucIMp2zzfKi zM76ZTYyOteeVJ+7g+oJorgb0zyrBVI3VPIorYPs+cBBbFKK+GJcOQA2FejR9F2b+zj8 6kpJyn0jR69DOXWZ0gXgEwI7tkPAmYcx3SwvUGxPfuvMQu/y5VDrFgDyVvSQdvAieF9A Uvfw== X-Gm-Message-State: AOJu0YxFU2I871sdt9LAp0YdFayTdXM0rmAgh7kKNs6BR5Y69QpdORUO Ztfo1IcKRrsKXuc0sjxqNS9byo/AQC3qK5tDJVMgMdrnw4RVGao4SqesZg== X-Gm-Gg: ASbGncttsNGrMkGutwupLzLG8ylp+kBZABJAFRfIav0k6vdA6ErbZ2ERP+Cp5ljYDZO jA4it0TRe289Mg52B230NWCbEW02/SIJQ8JZoUtLZefxIlmAfAFQqVC4XMY4XrHdUgd/CJ6gGUH 8zyAbiYxkFvX+VgbSD8z3XEsc4uFihZ/db/s1WmDwgWhwKwG6dU+ojPyhymoItTFijrSWscuva2 X+B34vKauSRjYhWDpk9D3qLYzcbUh4hvy5uXb0JPOePULK4UncW05jG6rSmi7poEmAWbHj65+EK 2+vizOJal/YLlLWJ/1egRzE3MG3rbrAahw== X-Google-Smtp-Source: AGHT+IE8RtJmCFwTDDGvpkF4upmMZzlLBUgcXBVIGG3UxJSefCftQjd44jfX7YRehOoaOWgU76evFw== X-Received: by 2002:a05:6a21:32a8:b0:1e1:b60c:5bdb with SMTP id adf61e73a8af0-1ede88b188emr8773630637.26.1738809523166; Wed, 05 Feb 2025 18:38:43 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73048ad26c5sm179362b3a.46.2025.02.05.18.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 18:38:42 -0800 (PST) From: Maxim Cournoyer Date: Thu, 6 Feb 2025 11:38:05 +0900 Message-ID: X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Prior to this change, only the udev rules installed to eudev's prefix were consulted by tools such as udevadm, leading to problems such as when configuring network interfaces, or attempting to override its default rules. While our custom eudev patch adding support for the EUDEV_RULES_DIRECTORY environment variable could have been refined to take precedence over the package's configured udevrulesdir, this was not pursued for the following reasons: 1. Due to eudev's using inotify to detect new rules, the EUDEV_RULES_DIRECTORY is fixed in Guix System, per commit e9fa17eb98 ("services: udev: Use a fixed location for the rules directory and config.") 2. Users would have had to set EUDEV_RULES_DIRECTORY to the fixed directory themselves to have udevadm work as expected, which is inconvenient. 3. This simple solution is already implemented and tested in NixPkgs. Changes in v5: - Use #:make-flags to configure udev-rules.d prefix - Remove now unused eudev patch Felix Lechner (1): gnu: eudev: Use new project URL for Git repo and home page. Maxim Cournoyer (2): services/base: Remove extraneous UDEV_CONFIG_FILE environment variable. gnu: eudev: Build with udevrulesdir pointing to /etc/udev/rules.d. gnu/local.mk | 1 - gnu/packages/linux.scm | 35 +++++++++++++----- .../patches/eudev-rules-directory.patch | 37 ------------------- gnu/services/base.scm | 4 -- 4 files changed, 25 insertions(+), 52 deletions(-) delete mode 100644 gnu/packages/patches/eudev-rules-directory.patch base-commit: 52c05f3b120e641c8bd2d68cfcf0d6af947de27b