From patchwork Sun Nov 17 12:03:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 3003 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 95D9827BBEA; Sun, 17 Nov 2024 12:04:28 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 8891F27BBE2 for ; Sun, 17 Nov 2024 12:04:27 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCe0e-0003IW-AQ; Sun, 17 Nov 2024 07:04:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCe0Y-0003HG-N9 for guix-patches@gnu.org; Sun, 17 Nov 2024 07:04:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCe0Y-0003Bd-62 for guix-patches@gnu.org; Sun, 17 Nov 2024 07:04:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=Jq48+aJoGN1umRmH9wMo5jpUtTFp5B8LSSkz9B56dvk=; b=IF5suH9FK9+FEfcrMlHqNhLz524JMFzmAkzNbzJRiJGnZCDkUUi1/9Oc34HIyBdFsDSKEkve50fRPQWF5fsaPyDAQqG5MXKnyOj0+EhepcpWU5TwO6EVtNkTuEvovjcA7Q9hFixfRDw9Wscc7B/4pcomNKOOCsR7gwZVXtcFlx7jRjRKVUhSGwecbgSIicxsN1sNaEpoQydacq7Yzunb7ogPtB2Clit4Vsy1CgiG0cUWPhvJ/LXU/Zb00HGIJVnv13kk0FMUQoEJAQ3GuaSMnEfJOArnCQahG/mrHJjrN2OMzUf5QJPY3+ozdtA1Uyt0TEVG1O6K3Iauk4ppNMhg7w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCe0Y-0006LI-06 for guix-patches@gnu.org; Sun, 17 Nov 2024 07:04:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74394] [PATCH 0/2] Skip slow tests by default and run 'check' in Git pre-push hook. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 Nov 2024 12:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74394 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74394@debbugs.gnu.org Cc: Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173184503224362 (code B ref -1); Sun, 17 Nov 2024 12:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 17 Nov 2024 12:03:52 +0000 Received: from localhost ([127.0.0.1]:56137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCe0O-0006Ks-6F for submit@debbugs.gnu.org; Sun, 17 Nov 2024 07:03:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:35094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCe0L-0006Kj-7Y for submit@debbugs.gnu.org; Sun, 17 Nov 2024 07:03:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCe0K-0003Bk-AN for guix-patches@gnu.org; Sun, 17 Nov 2024 07:03:48 -0500 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCe0I-0002mn-5V for guix-patches@gnu.org; Sun, 17 Nov 2024 07:03:48 -0500 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20e576dbc42so22657375ad.0 for ; Sun, 17 Nov 2024 04:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731845023; x=1732449823; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Jq48+aJoGN1umRmH9wMo5jpUtTFp5B8LSSkz9B56dvk=; b=l+/SYIMIhftHdcA6ZuHqfKqRPZgezmp8AEGhx3PaQVPagf2cBsDdW1R61ec5xvM8Px SawILaOStQtgJhI33fR1iyF2upauDHQ5gQP6mRt220HTl8WFvy/JvjXuYkbI4j9tIbPz 8UO7ydFo5AZ8CWWoqY1fyTb7VL/eiMkHOsWApJc5L7a5rfIN+Amy3yQ0+FfMdFf1jPvl cXJ13huV6I1rL+5nEcbTRF3Vu5LyMZYq/pRypmNJpjM+1GveMTpUDVi/IX5tAzjhhFR0 SmXsK2GYJBFaQffvaL5I4SIgFPSom6JFj7F2PVyMCn/Wt7ipn8daC3D4iv0zaGcqNVnq F2Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731845023; x=1732449823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Jq48+aJoGN1umRmH9wMo5jpUtTFp5B8LSSkz9B56dvk=; b=wISY3Vu9SlSzFuHg8PG6TbBRDNdRTae+dEA3vCOuYpJq+wf5hx4zuzfrmzabCjmJrO W638mWQYfcmKjvjqcAPjr4ZcwTGLEMMbArlQq/crWEES3WQ5LUqGxskpNvDIlcx3MqQ/ nQMo7JoHPOJcGRuOddZS1VIpn12B1zDBMT7BWhNfw/F6RdtpeZReqDKev0njNgmCqua1 UDBg2WiYw2EB3HPg1KZUwy6GScpn0k2bvNvOaRMflmPT+t7WYNaiEK+rWqyYwhkfLxz1 GsutCrdP1HVPeBNB26evtKbGYDvOQG+DIqbMCJ788VBR+mtsYcWfrkvd9GcNqALPpoTh zk+g== X-Gm-Message-State: AOJu0Yz0coAaWO0Dbzeyz2OR4OKD8gTz62q0qJ1XQgRSi5a7HMbiZcCn XXk/BwxQ62dfxgt+0KIG4sIGjubJS2VyXXOQX9Q4XKYR3+dmNKRzMKKISg== X-Google-Smtp-Source: AGHT+IH9sCBhSxevKNOS1EteuiXDCD+RcQVIB5U3/A4gnpRPkY9hjzDjVp8vQFKekvwN/X/v2LZkqQ== X-Received: by 2002:a17:902:ecc5:b0:211:6b23:9aa8 with SMTP id d9443c01a7336-211d0ebd172mr137896385ad.36.1731845023168; Sun, 17 Nov 2024 04:03:43 -0800 (PST) Received: from localhost.localdomain ([2405:6586:be0:0:c8ff:1707:9b9:af89]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0ec7c45sm39723105ad.77.2024.11.17.04.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Nov 2024 04:03:42 -0800 (PST) From: Maxim Cournoyer Date: Sun, 17 Nov 2024 21:03:30 +0900 Message-ID: X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=maxim.cournoyer@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello, This is a simple change that should ensure test suite breakages are detected as early as possible and avoid tests breaking changes to be pushed. This is made possible by skipping a few expensive tests suite, bringing down the total test time to about 1 minute on a fast machine. We could call it a "distributed CI" approach ;-). Note: I initially pursued an Automake or Make-based approach, but it ended up far from trivial, hitting old issues such as [0] along the way. This solution simply puts the skip logic in the tests that must be skipped (a one liner). To run the complete test suite including the slow tests (as is the case prior this change): make check WITH_SLOW_TESTS=1 [0] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=74387 Maxim Cournoyer (2): build: Exclude expensive tests in check target by default. etc: Ensure test suite passes in pre-push git hook. Makefile.am | 9 ++++++++- etc/git/pre-push | 1 + tests/guix-home.sh | 5 +++++ tests/guix-package.sh | 5 +++++ tests/guix-system.sh | 4 ++++ tests/guix-time-machine.sh | 4 +++- 6 files changed, 26 insertions(+), 2 deletions(-) base-commit: 94133452aa49de672d69950b2e1a99432111074c