From patchwork Fri Nov 8 13:41:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Boilleau X-Patchwork-Id: 2977 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BDB1427BBE9; Fri, 8 Nov 2024 15:35:37 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 7B98727BBE2 for ; Fri, 8 Nov 2024 15:35:35 +0000 (GMT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t9R18-0000Ts-Lz; Fri, 08 Nov 2024 10:35:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PT1-0007ON-9K for guix-patches@gnu.org; Fri, 08 Nov 2024 08:56:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t9PT1-0005fY-0l for guix-patches@gnu.org; Fri, 08 Nov 2024 08:56:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=vONnq7BoImFu3XVKLk2TO/hGi4o3jTrome4XxDEQhbQ=; b=rQEuQoQpJFRfwryDXJ2rra+wgwdUHersThjhvIGoJvpwG5Tz6wQatdGGxiC179X22I+/aPXM+8PC2/Io65jljmGRX9vVgblZZIyoUPMb6p8LOnQD4nJhbHR3aDT+ABhig/3T9dSlxITgKei8Kcq6VWXDEYz++sgOqgW0FvowjWRbnjwdyd/9LA6FqGkpqZs+6vRrnZnVCaqSk89gHOrp61sLgJ1gcGir4dEmyeJ7wUQURQtSRoRIid1SmQu2q76ngi+egIdm+UTKd2X25FnNbrJ51k3HO7gzEDzdFIlWp2gJ3qyw8/JHECT6lZEp2VfepECRgVfIsFnZ9fYnz6ZmDw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t9PT0-0007wm-LO for guix-patches@gnu.org; Fri, 08 Nov 2024 08:56:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74258] [PATCH 0/3] Fix uninstall script Resent-From: David Boilleau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 08 Nov 2024 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 74258 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 74258@debbugs.gnu.org Cc: David Boilleau X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.173107414830522 (code B ref -1); Fri, 08 Nov 2024 13:56:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2024 13:55:48 +0000 Received: from localhost ([127.0.0.1]:51583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PSj-0007w6-3R for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:55:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:52584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t9PFB-0007JO-PJ for submit@debbugs.gnu.org; Fri, 08 Nov 2024 08:41:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFB-0002PT-Jq for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t9PFA-0003mL-1I for guix-patches@gnu.org; Fri, 08 Nov 2024 08:41:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.fr; s=s31663417; t=1731073300; x=1731678100; i=david_boilleau@gmx.fr; bh=vONnq7BoImFu3XVKLk2TO/hGi4o3jTrome4XxDEQhbQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID: MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=h1S36nnijJ44y/18hk8BdOAhanJC5wab6BgMO3AO3COmE9xBr0kTaLrmaVMa4v96 6VjTSF5Z3+iRwCLGVp5gV/qL8pX2ROOIqrIMFCxEFnV1FlLIXE6YKv3+68H4UQbBa tMSj8kS/w3nNcQ8m1xswp3MUf5T4RVWNPuOK3qH2HfzvoQ0K9Bd1du1WLsTYKj0nh slgQP+A7ggNyFzPtvCerc8geCuMlxjOHGU8o8S9aCZ97c7kbZ+DSfQPLpXwLhdNf0 vkfB+cDQPAmwezv60VG2lrulhuHaa/kgCVY+e+eAUShO+lQ8sR/3pVLKtYPi0JYg6 sZqyLA33vbIjl6OsMw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from pms ([88.126.7.20]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mqb1c-1teMLc27RQ-00ZiTv; Fri, 08 Nov 2024 14:41:40 +0100 Date: Fri, 8 Nov 2024 14:41:12 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:3EHlImKF8o7gKEbNgi+JOeI7X6Sr6HzaWG2gppNIhjabDRwEM66 9jzY2+Sfm/w0fTOvWyKpFpqCnhtvSW78x8sKvAJc/7UQvUTcOF7K9TBR52WPNFB+/ejG7c2 OZLDvxUgMoNvF9Bqc5YllTzKUOz9yAdsGIkdEreBn0XsOhOx3b5LNakGh90C2x0aEfdnySQ F7KbXPglPQ0OL5AjCUnMA== UI-OutboundReport: notjunk:1;M01:P0:+I39tI84IV4=;n2dFpReOrZJDh1ItT4VeCCHwuuS dhfYCpWplQ6/1IGfCK7UiTcNi3LiG8p9Xe4/AHvggt2lqAgQdX/aAY5f7n7WFhMWIdpon7hz1 DmokYcnglHEzv/+awRG7S/djF8ykrNl1UyNLqOj44DuDP5fAImM7eafpTfPLS9xJdOaPXiPcF d2iU1mTR1eTQ9fnGAzMUNMBWbDc7BNjDxEtDICeKV+ZjGEEMGnY5D5b5gQjWUlXoE5OQfBiyx TbeNioPXN3kLcixfHlQyejbuILUslmPVT0ePyj6oYSO3bmwVdAAa7SI9/5m6T+cWWdicLSv4h 6fKTKoNQL5HtkNA5htLryVhGaK+W7yQcFnkQHl1HrN1Ev5SwQTlGN+lfs+Z7OUYL63mEmYi78 42KehNdnuTbAgQR5SSOToAR8nDvT5iBe7mcyaTxzxssVEdJYvr6p+/sa4r3kKn+Xf2ked5Jws tG7JU0xVMz1hrsC9ewMmV/gtieurXjSp4sjBX3XxIGtqRJv4HZ5ZzcrKLGf2SuNHuYrG5t25j hpEDuMcpdbcQz39m+NpLntevs/HlNDBu0U2+q6BE05No4sDpKzNzaE7pRsPx73pQA4hK6r6rw dTofF7vp96Y0lBnjFfBhq0F5ZM9bh/w6TxXb1lKBPd60hK+w+7BLRAQJihcC8d3vC81dLMhB/ UTuSnp2+Hk4XoHgeUHW3+emHgTU3svMmGmJRNaBlnfap5Ow02JX1+6YdeJSus87AeXj9W/UrM 9Xeq13hnW1u7E4P8zt9pGM4FeCmkh05V+MDeRo9nbiuBDetv8LiCDePFmSLBmnZqusnmMD8He Y+1uzGl3aY0xn0YojLX+B98g== Received-SPF: pass client-ip=212.227.17.21; envelope-from=david_boilleau@gmx.fr; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 08 Nov 2024 08:55:40 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Mailman-Approved-At: Fri, 08 Nov 2024 10:35:20 -0500 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: David Boilleau X-ACL-Warn: , David Boilleau via Guix-patches X-Patchwork-Original-From: David Boilleau via Guix-patches via From: David Boilleau Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches I installed Guix on Ubuntu 24.04 with the script guix-install.sh, then I tried to uninstall it by running `guix-install.sh --uninstall`. The uninstall failed three times: 1. The unit gnu-store.mount was not suppressed, because the prior test on the gnu-store.mount file failed. 2. The variable ROOT_HOME did not exist, so /root/.guix-profile, /root/.config/guix and /root/.cache/guix were not suppressed. 3. The "guixbuilder" users were already removed due to the previous attempts, so the script failed to remove them and exited here. Same when it tried to remove the service guix-daemon.service. Here are propositions to fix all of this. David Boilleau (3): guix-install.sh: Test if gnu-store.mount exists before removing the unit guix-install.sh: Replace `ROOT_HOME` with `~root` guix-install.sh: Run the uninstall even if already partially done etc/guix-install.sh | 36 +++++++++++++++++++++--------------- 1 file changed, 21 insertions(+), 15 deletions(-) base-commit: 673b924ac1e30a5d498e28859af365cf2bb4a508 --- 2.43.0