mbox series

[bug#72463,00/10] Add Clojure Core packages and HTTPkit

Message ID cover.1722782570.git.roman@burningswell.com
Headers show
Series Add Clojure Core packages and HTTPkit | expand

Message

Roman Scherer Aug. 4, 2024, 2:44 p.m. UTC 
Hello Guix,

this patch series adds some Clojure Core packages and HTTPkit.

Could you please review and apply them?

Thanks, Roman.

Roman Scherer (10):
  gnu: Add clojure-data-json.
  gnu: Add clojure-data-priority-map.
  gnu: Add clojure-core-cache.
  gnu: Add clojure-core-memoize.
  gnu: Add clojure-tools-analyzer.
  gnu: Add clojure-tools-reader.
  gnu: Add clojure-tools-analyzer-jvm.
  gnu: Add clojure-tools-logging.
  gnu: Add clojure-core-async.
  gnu: Add http-kit.

 gnu/packages/clojure.scm | 291 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 291 insertions(+)


base-commit: b20956651a53a8f23828fdeb6945e1a31e6997a8
--
2.45.2

Comments

Ludovic Courtès Sept. 6, 2024, 9:55 p.m. UTC | #1 
Hi Roman,

Roman Scherer <roman@burningswell.com> skribis:

>   gnu: Add clojure-data-json.
>   gnu: Add clojure-data-priority-map.
>   gnu: Add clojure-core-cache.
>   gnu: Add clojure-core-memoize.
>   gnu: Add clojure-tools-analyzer.
>   gnu: Add clojure-tools-reader.
>   gnu: Add clojure-tools-analyzer-jvm.
>   gnu: Add clojure-tools-logging.
>   gnu: Add clojure-core-async.
>   gnu: Add http-kit.

This looks great, modulo one tiny thing: synopses shouldn’t have a
period, as flagged by ‘guix lint’, and descriptions should be proper
sentences (see
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>).

Do you think you could tweak those?

Thanks, and apologies for the delay!

Ludo’.
Roman Scherer Sept. 7, 2024, 9:53 a.m. UTC | #2 
Hi Ludo,

thanks for the review. Thanks for the review. Looks like I forgot to run
the linter on those patches. I did so now, and also updated 2 of the
packages to a newer version.

Can you have another look, please?

Thanks, Roman.

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Roman,
>
> Roman Scherer <roman@burningswell.com> skribis:
>
>>   gnu: Add clojure-data-json.
>>   gnu: Add clojure-data-priority-map.
>>   gnu: Add clojure-core-cache.
>>   gnu: Add clojure-core-memoize.
>>   gnu: Add clojure-tools-analyzer.
>>   gnu: Add clojure-tools-reader.
>>   gnu: Add clojure-tools-analyzer-jvm.
>>   gnu: Add clojure-tools-logging.
>>   gnu: Add clojure-core-async.
>>   gnu: Add http-kit.
>
> This looks great, modulo one tiny thing: synopses shouldn’t have a
> period, as flagged by ‘guix lint’, and descriptions should be proper
> sentences (see
> <https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>).
>
> Do you think you could tweak those?
>
> Thanks, and apologies for the delay!
>
> Ludo’.