From patchwork Wed May 22 10:02:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Tropin X-Patchwork-Id: 2578 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 241FF27BBEA; Wed, 22 May 2024 11:13:21 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 77DBE27BBE2 for ; Wed, 22 May 2024 11:13:19 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9iy2-00076k-4X; Wed, 22 May 2024 06:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9ixz-00075b-Tc for guix-patches@gnu.org; Wed, 22 May 2024 06:13:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9ixx-0005Cs-Jl; Wed, 22 May 2024 06:13:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9ixx-0000sx-Od; Wed, 22 May 2024 06:13:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71111] [PATCH 0/1] services: home: Use pairs instead of lists. Resent-From: Andrew Tropin Original-Sender: "Debbugs-submit" Resent-CC: pelzflorian@pelzflorian.de, ludo@gnu.org, matt@excalamus.com, maxim.cournoyer@gmail.com, guix-patches@gnu.org Resent-Date: Wed, 22 May 2024 10:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 71111 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71111@debbugs.gnu.org Cc: Richard Sent , Ludovic =?utf-8?q?Court?= =?utf-8?q?=C3=A8s?= , Andrew Tropin , Florian Pelz , Ludovic =?utf-8?q?Court=C3=A8s?= , Matthew Trzcinski , Maxim Cournoyer X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Florian Pelz , Ludovic =?utf-8?q?Court=C3=A8s?= , Matthew Trzcinski , Maxim Cournoyer Received: via spool by submit@debbugs.gnu.org id=B.17163727463375 (code B ref -1); Wed, 22 May 2024 10:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2024 10:12:26 +0000 Received: from localhost ([127.0.0.1]:54975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9ixO-0000sN-4s for submit@debbugs.gnu.org; Wed, 22 May 2024 06:12:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:46388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9ixL-0000sH-K4 for submit@debbugs.gnu.org; Wed, 22 May 2024 06:12:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9ixE-0006yX-1k for guix-patches@gnu.org; Wed, 22 May 2024 06:12:16 -0400 Received: from out-188.mta1.migadu.com ([2001:41d0:203:375::bc]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9ixB-00059K-NV for guix-patches@gnu.org; Wed, 22 May 2024 06:12:15 -0400 X-Envelope-To: guix-patches@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=trop.in; s=key1; t=1716372727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=O1MEjCi3LEstVTNirFhQ4NresQiqH20U0OH5QOzEv68=; b=Rv31OLFeAL5e2I/YWbNIDS1D7WTDqJx7b4wK8yVh6HCYnMnzlu4/UpPhAk5/n9X59sGtpk JGkpd5uYuoYbADrW9L/idIwahw9KLr91/xs3UunpFHDjyfQp8hPXdlaydegInMEjIhFsmm 1qb4qWPSgmx0Ye8mufJItb9CPwxXpgtJPvTI/siOKoFGFPi6cQSjEMtj/xyauhWwMPXbMn 6zQuFFtpUw6TucZY4wJ/Jq8B3nDrS9XxN5wSBBn/sKa+cltMjtVovqktvKfwq3VVuMMhjA r2VPoSUlXp9qi/1tJmY6lxgT02hITWz8/UHVr2lzQ6srZRMlxNx+1kY9SoqohQ== X-Envelope-To: andrew@trop.in X-Envelope-To: richard@freakingpenguin.com X-Envelope-To: ludo@gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Date: Wed, 22 May 2024 14:02:26 +0400 Message-ID: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:203:375::bc; envelope-from=andrew@trop.in; helo=out-188.mta1.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Andrew Tropin X-ACL-Warn: , Andrew Tropin via Guix-patches X-Patchwork-Original-From: Andrew Tropin via Guix-patches via From: Andrew Tropin Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches After rewriting from car/cdr to match-lambda in v2 of this patch: https://yhetil.org/guix-patches/3394b0b51f6a5a608ebcfb7a63fdc34e52fe928e.1711046203.git.richard@freakingpenguin.com/ the format changed from pairs to lists, I didn't noticed this nuance during review because the documentation still says that service should be configured and extended with pairs. Also, pairs are more apropriate data type here. And this match-lambda rewrite will break downstream RDE user's setups after migrating to upstreamed version of service. That's why I propose to go back to pairs. Andrew Tropin (1): services: home: Use pairs instead of lists. doc/guix.texi | 4 ++-- gnu/services/guix.scm | 2 +- gnu/tests/guix.scm | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) base-commit: b06a460bf5236a9d52f936f2023451051b3e622a