From patchwork Sun May 5 17:25:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Herman Rimm X-Patchwork-Id: 1952 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 531C127BBE9; Sun, 5 May 2024 18:27:06 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 49A7E27BBE2 for ; Sun, 5 May 2024 18:26:59 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3fdQ-0002yz-P9; Sun, 05 May 2024 13:26:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3fdO-0002yS-Nk for guix-patches@gnu.org; Sun, 05 May 2024 13:26:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3fdO-0001ZI-Eg; Sun, 05 May 2024 13:26:46 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3fdd-00023P-NI; Sun, 05 May 2024 13:27:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70499] [PATCH v2 0/3] Lint package order. References: <1f19f015e714d68c84cd91618b1340365c8363bb.1713722288.git.herman@rimm.ee> In-Reply-To: <1f19f015e714d68c84cd91618b1340365c8363bb.1713722288.git.herman@rimm.ee> Resent-From: Herman Rimm Original-Sender: "Debbugs-submit" Resent-CC: guix@cbaines.net, pelzflorian@pelzflorian.de, dev@jpoiret.xyz, ludo@gnu.org, othacehe@gnu.org, rekado@elephly.net, zimon.toutoune@gmail.com, me@tobias.gr, guix-patches@gnu.org Resent-Date: Sun, 05 May 2024 17:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70499 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70499@debbugs.gnu.org Cc: Christopher Baines , Florian Pelz , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice X-Debbugs-Original-Xcc: Christopher Baines , Florian Pelz , Josselin Poiret , Ludovic =?utf-8?q?Court=C3=A8s?= , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Received: via spool by 70499-submit@debbugs.gnu.org id=B70499.17149299867854 (code B ref 70499); Sun, 05 May 2024 17:27:01 +0000 Received: (at 70499) by debbugs.gnu.org; 5 May 2024 17:26:26 +0000 Received: from localhost ([127.0.0.1]:60850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3fd3-00022W-5h for submit@debbugs.gnu.org; Sun, 05 May 2024 13:26:26 -0400 Received: from 81-205-150-117.fixed.kpn.net ([81.205.150.117]:60339 helo=email.rimm.ee) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3fcx-00022O-B3 for 70499@debbugs.gnu.org; Sun, 05 May 2024 13:26:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rimm.ee; s=herman; t=1714929946; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NA0NTery0onmh7+gWRbE00dk92+tJ+hu4R/qvZR5YeM=; b=Lf2ivenLQ4cW9Mx15uupVO7rI3HpxMZwZMYlER1Q81xA+tomnyDRD+pUvvBvtOnI5euy21 o14mFu6ian9/IQV9IlJRoKUWbBjekGN8uJxXjbRsd9w+5JBz806i5+ebQk0EY6Bk1TgdHr y7e/bkPUM4PawRQDYQCWxie4og5OfaHzFwh5+ldWeeyLd7ZkJs/HkEbba9vGxtoPHJ0qHm 29jBNzm4+AAdSoBGqIe6yWL5IY3RtXvQw1iPMlTm3K/qNfiVdXgAYnA6jaJKQHgDVf0yCB hNki5Kot+foZXvkJmIV1IWzvQWGnLpG4ePDGjq3kU9Y9jsl20JX4qKJmK9NmHQ== Received: by 81-205-150-117.fixed.kpn.net (OpenSMTPD) with ESMTPSA id 3ac7301f (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for <70499@debbugs.gnu.org>; Sun, 5 May 2024 17:25:46 +0000 (UTC) Date: Sun, 5 May 2024 19:25:32 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Herman Rimm X-ACL-Warn: , Herman Rimm via Guix-patches X-Patchwork-Original-From: Herman Rimm via Guix-patches via From: Herman Rimm Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hi, I do not think 'find-unordered-packages' would be useful for e.g. guix style, so I made a similar procedure in (guix scripts lint) instead. It is implemented with 'fold-packages' to get package records to pass to the 'run-checkers' procedure. So now you can use guix lint with --whole-file to also lint the package ordering, for example: $ guix lint -f gnu/packages/matrix.scm -n gnu/packages/matrix.scm:161:0: python-matrix-nio@0.20.2: breaks from alphabetical order gnu/packages/matrix.scm:244:0: pantalaimon@0.10.5: breaks from alphabetical order However the alphabetical order lint warnings only appear once another type of lint warning is emitted, or when end of file is reached and linting finishes. So if few checkers are enabled, it takes a few seconds before anything is output for large module files, like 'crates-io.scm'. Can this be fixed easily? Cheers, Herman Herman Rimm (3): guix: Move ‘package-location