mbox series

[bug#70024,core-updates,0/4] Update enchant to 2.6.8; Add Nuspell support.

Message ID cover.1711531771.git.mail@nicolasgoaziou.fr
Headers show
Series Update enchant to 2.6.8; Add Nuspell support. | expand

Message

Nicolas Goaziou March 27, 2024, 9:30 a.m. UTC 
This patch set updates enchant and add Nuspell support. I had to fix an issue with unittest-cpp along the way..

Regards,

Nicolas Goaziou (4):
  gnu: unittest-cpp: Fix "Version" setting in ".pc" file.
  gnu: enchant: Update to 2.6.8.
  gnu: enchant: Improve package style.
  gnu: enchant: Add Nuspell support.

 gnu/packages/check.scm   |  6 +++++-
 gnu/packages/enchant.scm | 35 ++++++++++++++++++-----------------
 2 files changed, 23 insertions(+), 18 deletions(-)


base-commit: 54219dc3a440aaf86ece4a65fec1a97c0952f6f2

Comments

Nicolas Goaziou April 13, 2024, 1:57 p.m. UTC | #1 
Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> writes:

> This patch set updates enchant and add Nuspell support. I had to fix
> an issue with unittest-cpp along the way..

Friendly ping!

Or, to put it differently, may I commit this to core-updates?

Thanks.
Maxim Cournoyer April 17, 2024, 5:49 p.m. UTC | #2 
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> This patch set updates enchant and add Nuspell support. I had to fix an issue with unittest-cpp along the way..
>
> Regards,
>
> Nicolas Goaziou (4):
>   gnu: unittest-cpp: Fix "Version" setting in ".pc" file.
>   gnu: enchant: Update to 2.6.8.
>   gnu: enchant: Improve package style.
>   gnu: enchant: Add Nuspell support.
>
>  gnu/packages/check.scm   |  6 +++++-

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
Nicolas Goaziou April 18, 2024, 11:50 a.m. UTC | #3 
Hello,

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>
>> This patch set updates enchant and add Nuspell support. I had to fix an issue with unittest-cpp along the way..
>>
>> Regards,
>>
>> Nicolas Goaziou (4):
>>   gnu: unittest-cpp: Fix "Version" setting in ".pc" file.
>>   gnu: enchant: Update to 2.6.8.
>>   gnu: enchant: Improve package style.
>>   gnu: enchant: Add Nuspell support.
>>
>>  gnu/packages/check.scm   |  6 +++++-
>
> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

Thank you. I applied the patch set to core-updates.

I also bumped enchant to 2.6.9, assuming nothing had been pre-built
during the QA process. If my assumption is wrong, and this change delays
core-update merge too much, it can be reverted.

Regards,
Maxim Cournoyer April 19, 2024, 3:27 p.m. UTC | #4 
Hi,

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>> This patch set updates enchant and add Nuspell support. I had to fix an issue with unittest-cpp along the way..
>>>
>>> Regards,
>>>
>>> Nicolas Goaziou (4):
>>>   gnu: unittest-cpp: Fix "Version" setting in ".pc" file.
>>>   gnu: enchant: Update to 2.6.8.
>>>   gnu: enchant: Improve package style.
>>>   gnu: enchant: Add Nuspell support.
>>>
>>>  gnu/packages/check.scm   |  6 +++++-
>>
>> Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>
>
> Thank you. I applied the patch set to core-updates.
>
> I also bumped enchant to 2.6.9, assuming nothing had been pre-built
> during the QA process. If my assumption is wrong, and this change delays
> core-update merge too much, it can be reverted.

Only the core set of packages is currently being built by the CI for
core-updates, so this impacts core-updates hacker more that anything
else.  I think we should setup a branch for core-updates-frozen and have
that fully built anyway.