| Message ID | cover.1710439598.git.vivien@planete-kraus.eu |
|---|---|
| Headers | show |
| Series | Make the glibmm-2.76 variable public in (gnu packages glib) | expand |
Am Donnerstag, dem 14.03.2024 um 19:06 +0100 schrieb Vivien Kraus: > Dear Guix, > > Telegram-desktop wants to be built with glibmm@2.76. I originally > added it to (gnu packages telegram), but in this revision, I add it > to (gnu packages glib). What do you think? I won't be able to build it on my machine, but assuming you tested it LGTM.
Liliana Marie Prikler <liliana.prikler@gmail.com> writes: > Am Donnerstag, dem 14.03.2024 um 19:06 +0100 schrieb Vivien Kraus: >> Dear Guix, >> >> Telegram-desktop wants to be built with glibmm@2.76. I originally >> added it to (gnu packages telegram), but in this revision, I add it >> to (gnu packages glib). What do you think? > > I won't be able to build it on my machine, but assuming you tested it > LGTM. Thanks both, I've pushed this to gnome-team as aa9aebce615f014070797e7068baca40b4f25c37. Chris
Hi, Vivien Kraus <vivien@planete-kraus.eu> writes: > Dear Guix, > > Telegram-desktop wants to be built with glibmm@2.76. I originally added it to > (gnu packages telegram), but in this revision, I add it to (gnu packages > glib). What do you think? Is there an incompatibility between our latest glibmm and this version, or is it just the build system being overly strict? If the later, it'd be better to patch it so that it allows our current version.
Hello! Le samedi 16 mars 2024 à 21:31 -0400, Maxim Cournoyer a écrit : > > Telegram-desktop wants to be built with glibmm@2.76. I originally > > added it to > > (gnu packages telegram), but in this revision, I add it to (gnu > > packages > > glib). What do you think? > > Is there an incompatibility between our latest glibmm and this > version, > or is it just the build system being overly strict? If the later, > it'd > be better to patch it so that it allows our current version. I did not choose the correct words, sorry. There is an incompatibility between the 2.76 API and the 2.78 that we use, and this version of the telegram package can only build against 2.76. Best regards, Vivien
Am Sonntag, dem 17.03.2024 um 08:29 +0100 schrieb Vivien Kraus: > Hello! > > Le samedi 16 mars 2024 à 21:31 -0400, Maxim Cournoyer a écrit : > > > Telegram-desktop wants to be built with glibmm@2.76. I originally > > > added it to (gnu packages telegram), but in this revision, I add > > > it to (gnu packages glib). What do you think? > > > > Is there an incompatibility between our latest glibmm and this > > version, or is it just the build system being overly strict? If > > the later, it'd be better to patch it so that it allows our current > > version. > > I did not choose the correct words, sorry. There is an > incompatibility between the 2.76 API and the 2.78 that we use, and > this version of the telegram package can only build against 2.76. Could you give a more detailed explanation of this API incompatibility? The whole point of major versions would be to avoid this kind of thing, no?
Le dimanche 17 mars 2024 à 09:30 +0100, Liliana Marie Prikler a écrit : > > I did not choose the correct words, sorry. There is an > > incompatibility between the 2.76 API and the 2.78 that we use, and > > this version of the telegram package can only build against 2.76. > Could you give a more detailed explanation of this API > incompatibility? > The whole point of major versions would be to avoid this kind of > thing, > no? I don’t have much information, other than “it does not build with glibmm 2.78”. The Github merge request for a relevant issue does not give much information either: https://github.com/desktop-app/lib_base/pull/186
Am Donnerstag, dem 21.03.2024 um 19:25 +0100 schrieb Vivien Kraus: > Le dimanche 17 mars 2024 à 09:30 +0100, Liliana Marie Prikler a > écrit : > > > I did not choose the correct words, sorry. There is an > > > incompatibility between the 2.76 API and the 2.78 that we use, > > > and > > > this version of the telegram package can only build against 2.76. > > Could you give a more detailed explanation of this API > > incompatibility? > > The whole point of major versions would be to avoid this kind of > > thing, no? > I don’t have much information, other than “it does not build with > glibmm 2.78”. The Github merge request for a relevant issue does not > give much information either: > > https://github.com/desktop-app/lib_base/pull/186 Hmm, could we still use that patch and make it "Fix build with glibmm- 2.78" From a cursory glance, it looks like some type signatures might have changed, but that's a guess.
Le jeudi 21 mars 2024 à 19:49 +0100, Liliana Marie Prikler a écrit : > > https://github.com/desktop-app/lib_base/pull/186 > Hmm, could we still use that patch and make it "Fix build with > glibmm- > 2.78" > > From a cursory glance, it looks like some type signatures might have > changed, but that's a guess. I tried to find a combination of patches to backport, but it does not work very well (this patch ignores other things that were changed earlier, but that we would need to backport). It’s also not possible to point lib_base to this exact commit, because it is too recent for other parts of telegram. This is not great but hopefully a full upgrade of telegram will fix everything.