mbox series

[bug#68556,gnome-team,v5,0/8] Wrap gnome-shell-extensions with gobject-introspection in native-inputs

Message ID cover.1706558199.git.vivien@planete-kraus.eu
Headers show
Series Wrap gnome-shell-extensions with gobject-introspection in native-inputs | expand

Message

Vivien Kraus Jan. 29, 2024, 7:56 p.m. UTC 
Dear guix,

I think I made a mistake. gobject-introspection should probably be in
native-inputs. We only use this package so that GI_TYPELIB_PATH is set up at
build time. Gjs probably has all the girepository infrastructure it needs
already.

What do you think?

Best regards,

Vivien

Vivien Kraus (8):
  gnu: gnome-menus: Build GObject Introspection data.
  gnu: gnome-shell-extensions: Wrap apps-menu.
  gnu: gnome-shell-extensions: Wrap all the extensions.
  gnu: gnome-shell-extension-noannoyance: Switch to fork.
  gnu: gnome-shell-extension-topicons-redux: Deprecate.
  gnu: Remove gnome-shell-extension-jiggle.
  gnu: Remove gnome-shell-extension-transparent-window.
  gnu: Remove gnome-shell-extension-sound-output-device-chooser.

 gnu/packages/gnome-xyz.scm | 171 ++++---------------------------------
 gnu/packages/gnome.scm     |  51 ++++++++++-
 2 files changed, 65 insertions(+), 157 deletions(-)


base-commit: 2e7d78b1f02a8eae82c34e5183134c9d1a0d02b3

Comments

Liliana Marie Prikler Jan. 29, 2024, 8:53 p.m. UTC | #1 
Am Montag, dem 29.01.2024 um 20:56 +0100 schrieb Vivien Kraus:
> Dear guix,
> 
> I think I made a mistake. gobject-introspection should probably be in
> native-inputs.  We only use this package so that GI_TYPELIB_PATH is
> set up at build time.  Gjs probably has all the girepository
> infrastructure it needs already.
> 
> What do you think?
Note: if you set GI_TYPELIB_PATH at build time, you could get
confusions between build/host libs.  It's unlikely, but you might want
to make sure that your paths are sound.

Anyhow, this series mostly LGTM on first glance.  Does this issue also
affect the extensions already pushed?


Cheers
Vivien Kraus Jan. 29, 2024, 9:45 p.m. UTC | #2 
Le lundi 29 janvier 2024 à 21:53 +0100, Liliana Marie Prikler a écrit :
> Am Montag, dem 29.01.2024 um 20:56 +0100 schrieb Vivien Kraus:
> > Dear guix,
> > 
> > I think I made a mistake. gobject-introspection should probably be
> > in native-inputs.  We only use this package so that GI_TYPELIB_PATH
> > is set up at build time.  Gjs probably has all the girepository
> > infrastructure it needs already.
> > 
> > What do you think?
> Note: if you set GI_TYPELIB_PATH at build time, you could get
> confusions between build/host libs.  It's unlikely, but you might
> want
> to make sure that your paths are sound.
Is there a solution for this? As far as I understand, GI_TYPELIB_PATH
at build time has a mix of native inputs and inputs + propagated
inputs, and we only want the latter. If I understand correctly, we
can’t use search-input-directory because it would be from only 1
package.

> Does this issue also affect the extensions already pushed?
Other shell extension wrap their code for GI_TYPELIB_PATH, by getting
the environment variable value at build time.

Vivien