From patchwork Wed Oct 4 21:37:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vivien Kraus X-Patchwork-Id: 1852 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 66CB327BBE9; Wed, 4 Oct 2023 22:44:55 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 4A1A627BBE2 for ; Wed, 4 Oct 2023 22:44:54 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qo9fj-0003Oj-ML; Wed, 04 Oct 2023 17:44:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qo9fg-0003OK-Vx for guix-patches@gnu.org; Wed, 04 Oct 2023 17:44:45 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qo9fg-0007FK-O2 for guix-patches@gnu.org; Wed, 04 Oct 2023 17:44:44 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qo9fy-00057V-7v for guix-patches@gnu.org; Wed, 04 Oct 2023 17:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66099] [PATCH gnome-team v6 0/5] Update eudev, udev-service-type, upower Resent-From: Vivien Kraus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 04 Oct 2023 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66099 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , maxim.cournoyer@gmail.com, 66099@debbugs.gnu.org Cc: rg@raghavgururajan.name Received: via spool by 66099-submit@debbugs.gnu.org id=B66099.169645589019644 (code B ref 66099); Wed, 04 Oct 2023 21:45:02 +0000 Received: (at 66099) by debbugs.gnu.org; 4 Oct 2023 21:44:50 +0000 Received: from localhost ([127.0.0.1]:45486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo9fm-00056l-E8 for submit@debbugs.gnu.org; Wed, 04 Oct 2023 17:44:50 -0400 Received: from planete-kraus.eu ([89.234.140.182]:32950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qo9fk-00056b-JS for 66099@debbugs.gnu.org; Wed, 04 Oct 2023 17:44:49 -0400 Received: from planete-kraus.eu (localhost.lan [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 384862d9; Wed, 4 Oct 2023 21:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:in-reply-to:references:from:date:subject:mime-version :content-type:content-transfer-encoding:to:cc; s=albinoniB; bh=4 wn9kvRS7cYkyT+zzTkLJWwn9yY=; b=HkyN8CKW/CqJuIATuiYVTTBz8q5bER+vU aFgd+k3O/fDwxmaWOVTOJAChxEs5InNlj0XBYgT/sQbkKEO9HCdxRB4yl70OW0MF Ba+7bSsqh+sBVa9z0EO5z6sCQe/YPEjQMHkyWwb7I/hZ8ZC+L5yvF7kFVmHDuUF1 9dJT8V/V3nLB+U7Py6PpRz0Ds/2luARkExeH6CCFz9uIPGbPla1ieibm6F1ftRfx UORcNdfDkFdGI4v8e8tjI7GFaeDA3Bm91VS6vK4czmKBBMGa9hFnnZcnjvinxVqD Zz0JItNP45LY9R1AI/f/cJbPo+0ePtBeTELiAaxwgmRQW4BzEv9EA== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 450b09e5 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Wed, 4 Oct 2023 21:44:28 +0000 (UTC) Message-ID: In-Reply-To: <42e4b490bce80a94f1afb7f5843d77823058150a.camel@gmail.com> References: <42e4b490bce80a94f1afb7f5843d77823058150a.camel@gmail.com> Date: Wed, 4 Oct 2023 23:37:02 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.46.4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Vivien Kraus X-ACL-Warn: , Vivien Kraus via Guix-patches X-Patchwork-Original-From: Vivien Kraus via Guix-patches via From: Vivien Kraus Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Dear guix, Le mercredi 04 octobre 2023 à 18:52 +0200, Liliana Marie Prikler a écrit : > Am Montag, dem 02.10.2023 um 21:08 +0200 schrieb Vivien Kraus: > > The "rules" field in the udev-configuration record can now hold both rules > > and hwdb files. > > > > The udev-rules-union has been made generic, so that it works with either > > rules or hwdb files. > Maybe we should rename this to udev-configuration-union and deprecate the > former in favor of the latter (if it can be used outside of the module)? Yes, we should, "things" is ugly in a function name. However, the udev-*-union are not accessed from outside of the module, so we can just drop them. > > Some udev-related auxiliary functions in (gnu services base) had non- > > texinfo variable references in their docstrings ("FILE-NAME" instead of > > "@var{file-name}"). > > > > udev-rule and file->udev-rule have very similar effects. file->udev-rule > > operates on a file-like, and udev-rule on plain string contents. Now > > udev-rule calls file->udev-rule with a plain-file file-like object. > I think the patch would be a little easier to read if you did this > refactoring in a separate one. The commit log would read something like: > > "services: udev: unify udev-rule and fine->udev-rule. > > * gnu/services/base.scm (udev-rule): Implement in terms of > file->udev-rule. Use texinfo in docstring." You are right, it is way better! Best regards, Vivien Vivien Kraus (5): gnu: eudev: Update libudev version to 251. services: udev: unify udev-rule and file->udev-rule. gnu: udev-service-type: accept hwdb file extensions. gnu: libgudev: Update to 238. gnu: upower: Update to 1.90.2. doc/guix.texi | 52 +++++++-- gnu/local.mk | 1 + gnu/packages/gnome.scm | 43 +++++--- gnu/packages/linux.scm | 55 +++++++--- .../patches/eudev-rules-directory.patch | 9 +- .../patches/eudev-set-version-to-3.2.12.patch | 25 +++++ gnu/services/base.scm | 103 ++++++++++++++---- 7 files changed, 215 insertions(+), 73 deletions(-) create mode 100644 gnu/packages/patches/eudev-set-version-to-3.2.12.patch base-commit: b18b2d13488f2a92331ccad2dc8cbb54ee15582f