From patchwork Fri Sep 22 22:27:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 1827 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 468F727BBEA; Fri, 22 Sep 2023 23:29:24 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 519B727BBE9 for ; Fri, 22 Sep 2023 23:29:20 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjods-0001gq-LX; Fri, 22 Sep 2023 18:28:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjodp-0001gL-NE for guix-patches@gnu.org; Fri, 22 Sep 2023 18:28:53 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjodp-0005sf-9Z for guix-patches@gnu.org; Fri, 22 Sep 2023 18:28:53 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjodz-0006lB-II for guix-patches@gnu.org; Fri, 22 Sep 2023 18:29:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65866] [PATCH v2 0/8] Add built-in builder for Git checkouts Resent-From: Ludovic =?utf-8?q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 22 Sep 2023 22:29:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 65866@debbugs.gnu.org Cc: Ludovic =?utf-8?q?Court=C3=A8s?= , Maxim Cournoyer Received: via spool by 65866-submit@debbugs.gnu.org id=B65866.169542174225959 (code B ref 65866); Fri, 22 Sep 2023 22:29:03 +0000 Received: (at 65866) by debbugs.gnu.org; 22 Sep 2023 22:29:02 +0000 Received: from localhost ([127.0.0.1]:37406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjodt-0006kK-V3 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 18:29:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjodn-0006jE-7L for 65866@debbugs.gnu.org; Fri, 22 Sep 2023 18:28:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjodW-0005lU-5W; Fri, 22 Sep 2023 18:28:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:References:In-Reply-To:Date:Subject:To: From; bh=lk47iO4kQzqe0QpNVs9Y830SM9FGaIUAEeD/pw9Aqbo=; b=hKBU41HT/Sg8QDjk9/Kk 3WDTAxsYDmVv5ynGBwGNHkaOafcf6fPTlTIsmIeu4tz5uCBCD4uyBvajGEuW/D/akftXcpN0kByOH PDO+FSW7vHDEzXrw+iDxS05rcZhcbf8fzoLO2wet1iBeB84xKEFjzjtFjyzLTvSd8YT2Nhnl134R+ /gf0nnmMQbppZi7HbTT1agiW8z29qwdzqXPZWk7K/E4avFmQinH7RIvPgOxSVJ9pPh/SJtVMU63H3 50EE+feos3RKdf3fIzQlhmStf7Za9ZESQa9nl8AnmZMaR8jRzb/bs0BdVPVcoOe3vbs1/7sLQ8kil BEeWLyyazrlYZA==; From: Ludovic =?utf-8?q?Court=C3=A8s?= Date: Sat, 23 Sep 2023 00:27:56 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: <87o7hwas61.fsf@gnu.org> References: <87o7hwas61.fsf@gnu.org> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches Hello, Changes compared to v1: • The ‘output’ parameter of the ‘perform-download’ and ‘perform-git-download’ procedures is now mandatory. Consequently, the confusing ‘output*’ variable is gone. • The docstring of these two procedures has been clarified accordingly. • I think there’s no third item. Let me know if I missed something! Thanks, Ludo’. Ludovic Courtès (8): git-download: Move fallback code to (guix build git). git-download: Honor the ‘GUIX_DOWNLOAD_FALLBACK_TEST’ environment variable. perform-download: Remove unused one-argument clause. daemon: Add “git-download” built-in builder. build: Add dependency on Git. perform-download: Use the ‘git’ command captured at configure time. git-download: Use “builtin:git-download” when available. tests: Assume ‘git’ is always available. configure.ac | 7 ++ doc/guix.texi | 1 + guix/build/git.scm | 44 ++++++++++- guix/config.scm.in | 6 +- guix/git-download.scm | 122 ++++++++++++++++++------------ guix/scripts/perform-download.scm | 67 +++++++++++----- guix/self.scm | 10 ++- nix/libstore/builtins.cc | 5 +- tests/builders.scm | 29 ++++++- tests/channels.scm | 7 +- tests/derivations.scm | 94 ++++++++++++++++++++++- tests/git-authenticate.scm | 1 - tests/git.scm | 10 --- tests/import-git.scm | 18 ----- 14 files changed, 309 insertions(+), 112 deletions(-) base-commit: 3d8d67ef6928f5d81118c97f03372cd341eab8b0