Message ID | cover.1689427041.git.hako@ultrarare.space |
---|---|
Headers |
Return-Path: <guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org> X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5B96C27BBEA; Sat, 15 Jul 2023 16:05:30 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FROM_SUSPICIOUS_NTLD,MAILING_LIST_MULTI,PDS_OTHER_BAD_TLD, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id DB17527BBE9 for <patchwork@mira.cbaines.net>; Sat, 15 Jul 2023 16:05:26 +0100 (BST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <guix-patches-bounces@gnu.org>) id 1qKgpU-0002hG-UF; Sat, 15 Jul 2023 11:05:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qKgpT-0002gr-Eo for guix-patches@gnu.org; Sat, 15 Jul 2023 11:05:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qKgpT-0005Ix-6n for guix-patches@gnu.org; Sat, 15 Jul 2023 11:05:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qKgpR-0008VC-S0; Sat, 15 Jul 2023 11:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode. Resent-From: Hilton Chain <hako@ultrarare.space> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: andrew@trop.in, liliana.prikler@gmail.com, guix-patches@gnu.org Resent-Date: Sat, 15 Jul 2023 15:05:01 +0000 Resent-Message-ID: <handler.59552.B59552.168943345532623@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59552 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch moreinfo To: 59552@debbugs.gnu.org Cc: Hilton Chain <hako@ultrarare.space>, Nicolas Goaziou <mail@nicolasgoaziou.fr>, Andrew Tropin <andrew@trop.in>, Liliana Marie Prikler <liliana.prikler@gmail.com> X-Debbugs-Original-Xcc: Andrew Tropin <andrew@trop.in>, Liliana Marie Prikler <liliana.prikler@gmail.com> Received: via spool by 59552-submit@debbugs.gnu.org id=B59552.168943345532623 (code B ref 59552); Sat, 15 Jul 2023 15:05:01 +0000 Received: (at 59552) by debbugs.gnu.org; 15 Jul 2023 15:04:15 +0000 Received: from localhost ([127.0.0.1]:45754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1qKgog-0008U6-P0 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 11:04:15 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:34806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <hako@ultrarare.space>) id 1qKgoe-0008Tx-9O for 59552@debbugs.gnu.org; Sat, 15 Jul 2023 11:04:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1689433205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+LICoIeOeyo9JqqHeZ905kdZy+UzQMvI8YzofGeY/64=; b=FiMpmcShCYYfElC+KfNsp7gGHWjW1j4zbHu7i+yAg0TwzbEZkKHTFVA+uL3Ge3jWLD/vYD q67XWEI0SXWzHGyW8TUAVKhse74/Ccwd4l2l1SKI8FrdLOKB4GBvxKCweZkN7n4UOmSpwy I+2ne0PK0SS3iPBV2xGG/+JYYkCeqfbo9yBdR1uivK6jDrWDgF26LO82lf0pW60p/k5Nk4 AQMAf8rgyjUL7GVGe5z4B2hKieF8/x5WqchLKP/h5vcUGYQBxL/Eavhb49rFUWuVpHCL8n LqVQU62nIcnP43VvH+KuJZqd/ZW+CGsKLLGLeebf9ifnoNK5vKVODqsMiprNZg== Date: Sat, 15 Jul 2023 23:01:40 +0800 Message-ID: <cover.1689427041.git.hako@ultrarare.space> In-Reply-To: <20221125011530.12585-1-hako@ultrarare.space> References: <20221125011530.12585-1-hako@ultrarare.space> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: / Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: <guix-patches.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/guix-patches> List-Post: <mailto:guix-patches@gnu.org> List-Help: <mailto:guix-patches-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>, <mailto:guix-patches-request@gnu.org?subject=subscribe> Reply-to: Hilton Chain <hako@ultrarare.space> X-ACL-Warn: , Hilton Chain via Guix-patches <guix-patches@gnu.org> From: Hilton Chain via Guix-patches via <guix-patches@gnu.org> Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org X-getmail-retrieved-from-mailbox: Patches |
Series |
gnu: Add emacs-wakatime-mode.
|
|
Message
Hilton Chain
July 15, 2023, 3:01 p.m. UTC
Hello Guix! After looking through waktime-mode's source and Guix's build phases, I think it's OK to add the package first without packaging the wakatime-cli program. (Actually I managed to package all the dependencies of that go program locally, but it eventually failed to build without a clear error...) For the package definition itself, phase 'patch-el-files is still deleted because of the following error: --8<---------------cut here---------------start------------->8--- In guix/build/emacs-build-system.scm: 148:13 3 (loop (#(" ((file-exists-p (format \"/bin/%s\" …" …)) …) In ice-9/boot-9.scm: 1685:16 2 (raise-exception _ #:continuable? _) 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: patch-el-files: unable to locate "%s" --8<---------------cut here---------------end--------------->8--- I added a comment before suggesting that wakatime-cli is not available, but that was inaccurate. The real cause is that 'patch-el-files can't handle the following code: --8<---------------cut here---------------start------------->8--- (defun wakatime-find-binary (program) "Find the full path to an executable program." (cond [...] ((file-exists-p (format "/bin/%s" program)) (format "/bin/%s" program)) [...])) --8<---------------cut here---------------end--------------->8--- This seems to be a bug of the phase, as it shouldn't handle unformatted "/bin/%s" at all. And for the function finding an executable, it's unnecessary to patch it, then I think it's fine to delete the phase. And finally, it's wakatime-mode-test.el, the cases are so outdated that none of them could pass... There's no Makefile for 'check phase to run the test either, so no need to adjust for it. As a result, I think it's OK to add the package first without packaging the wakatime-cli program. Hilton Chain (1): gnu: Add emacs-wakatime-mode. gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) base-commit: 01412c6c6a98e4da10676560638640d0f33e1a02 -- 2.41.0